New issue
Advanced search Search tips

Issue 692737 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

DataUseMeasurement should initialize byte counts using Android TrafficStats

Project Member Reported by tbansal@chromium.org, Feb 15 2017

Issue description

DataUseMeasurement should initialize byte counts using Android TrafficStats
 

Comment 1 by bengr@chromium.org, Feb 16 2017

Please explain what this means in more detail.
There are couple of minor issues in how data usage is recorded using Android traffic stats API:
(i) |rx_bytes_os_| and |tx_bytes_os_| are not initialized in the constructor. This means we are losing some of the data.
(ii) Lot of samples in the DataUse.Bytes.*.OS histograms have 0-value.

This should be a quick fix.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e10fdac86b82f2e64a63815a9e08789582e6c8f9

commit e10fdac86b82f2e64a63815a9e08789582e6c8f9
Author: tbansal <tbansal@chromium.org>
Date: Wed Feb 22 23:50:27 2017

DataUse: Initialize byte counts using Android TrafficStats.

Also, a minor optimization to not record 0-value samples in the
histograms.

BUG= 692737 

Review-Url: https://codereview.chromium.org/2696193004
Cr-Commit-Position: refs/heads/master@{#452280}

[modify] https://crrev.com/e10fdac86b82f2e64a63815a9e08789582e6c8f9/components/data_use_measurement/core/data_use_measurement.cc

Status: Fixed (was: Untriaged)
Owner: tbansal@chromium.org

Sign in to add a comment