New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 692733 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Flaky test : compositing/overflow/overflow-positioning.html

Project Member Reported by jaydasika@chromium.org, Feb 15 2017

Issue description

compositing/overflow/overflow-positioning.html and virtual/prefer_compositing_to_lcd_text/compositing/overflow/overflow-positioning.html are flaky on chromium.webkit/WebKit Win7 (dbg)

One of these tests (or both) have failed 6 times in the last 9 builds (9014-9022) but the failure is there even in an earlier build (9000)

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29

 
 
Components: Blink>Compositing

Comment 2 by mgiuca@chromium.org, Feb 16 2017

Cc: samli@chromium.org
Labels: OS-Windows
Owner: ericwilligers@chromium.org
Status: Assigned (was: Untriaged)
+eric, sam who last touched this file (compositing/overflow/overflow-positioning.html).

It may just need a rebaseline. Disabling test.

Comment 3 by mgiuca@chromium.org, Feb 16 2017

The disable CL (may take awhile):
https://codereview.chromium.org/2698883002/
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/692a40f16ec4aa032bf3e7cfce23ccc680014401

commit 692a40f16ec4aa032bf3e7cfce23ccc680014401
Author: mgiuca <mgiuca@chromium.org>
Date: Thu Feb 16 07:49:28 2017

Disable flaky test overflow-positioning.html on Win7 Debug.

BUG= 692733 

TBR=ericwilligers@chromium.org

Review-Url: https://codereview.chromium.org/2698883002
Cr-Commit-Position: refs/heads/master@{#450891}

[modify] https://crrev.com/692a40f16ec4aa032bf3e7cfce23ccc680014401/third_party/WebKit/LayoutTests/TestExpectations

My change
-    -webkit-transition: -webkit-transform 1000s;
+    transition: transform 1000s;
didn't make this flaky.

Same for samli's change
-    -webkit-transform: translate(0px, 100px);
+    transform: translate(0px, 100px);

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6773ab42490210d02468d50e4298c7587209d6aa

commit 6773ab42490210d02468d50e4298c7587209d6aa
Author: ericwilligers <ericwilligers@chromium.org>
Date: Mon Feb 20 03:25:17 2017

Compositing: avoid flakes in overflow-positioning.html

To force a style recalc before triggering the transition, we explicitly
use getComputedStyle instead of hoping setTimeout(0) will suffice.

We pause the transition instead of hoping a 1000s transitions makes
little progress during a setTimeout(0).

BUG= 692733 

Review-Url: https://codereview.chromium.org/2704583003
Cr-Commit-Position: refs/heads/master@{#451552}

[modify] https://crrev.com/6773ab42490210d02468d50e4298c7587209d6aa/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/6773ab42490210d02468d50e4298c7587209d6aa/third_party/WebKit/LayoutTests/compositing/overflow/overflow-positioning.html

Status: Fixed (was: Started)

Sign in to add a comment