New issue
Advanced search Search tips

Issue 692724 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 623160



Sign in to add a comment

Convert WebAudio Media nodes to use testharness

Project Member Reported by rtoy@chromium.org, Feb 15 2017

Issue description

Convert the layout tests to use testharness for the MediaElementAudioSource, MediaStreamAudioDestination, and MediaStreamAudioSource nodes to use testharness.

There are only a handful of tests so I lumped them all together in this one issue.

 

Comment 1 by rtoy@chromium.org, Feb 15 2017

Blocking: 623160
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f98597ba6a3add1e39d0f824fc8e96ee4f663b7

commit 8f98597ba6a3add1e39d0f824fc8e96ee4f663b7
Author: rtoy <rtoy@chromium.org>
Date: Tue Mar 07 19:53:04 2017

Convert MediaStreamAudioSource test to testharness

Manually convert the test to use testharness and new Audit.

BUG= 692724 
TEST=mediastreamaudiosourcenode.html

Review-Url: https://codereview.chromium.org/2690343005
Cr-Commit-Position: refs/heads/master@{#455182}

[delete] https://crrev.com/2fc04cd1fea6d3c1fc5d8e1bd5fa2528b2a462d8/third_party/WebKit/LayoutTests/webaudio/MediaStreamAudioSource/mediastreamaudiosourcenode-expected.txt
[modify] https://crrev.com/8f98597ba6a3add1e39d0f824fc8e96ee4f663b7/third_party/WebKit/LayoutTests/webaudio/MediaStreamAudioSource/mediastreamaudiosourcenode.html

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d342a948f3809c5f65941cf454c068771718cf0a

commit d342a948f3809c5f65941cf454c068771718cf0a
Author: rtoy <rtoy@chromium.org>
Date: Tue Mar 07 20:55:14 2017

Convert MediaStreamAudioDestination tests to testharness

Manually converted the file to use testharness and updated to use new
Audit instead of old.

BUG= 692724 
TEST=mediastreamaudiodestinationnode.html

Review-Url: https://codereview.chromium.org/2694173006
Cr-Commit-Position: refs/heads/master@{#455212}

[delete] https://crrev.com/f2ef57e81267138c5f8fabc2ea7044b59600238a/third_party/WebKit/LayoutTests/webaudio/MediaStreamAudioDestination/mediastreamaudiodestinationnode-expected.txt
[modify] https://crrev.com/d342a948f3809c5f65941cf454c068771718cf0a/third_party/WebKit/LayoutTests/webaudio/MediaStreamAudioDestination/mediastreamaudiodestinationnode.html

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/973641c0ccf64c6c4c0919ed93cd3cd1f609b2e7

commit 973641c0ccf64c6c4c0919ed93cd3cd1f609b2e7
Author: rtoy <rtoy@chromium.org>
Date: Mon Mar 20 19:05:11 2017

Convert MediaElementAudioSource tests to testharness.

These were all converted by hand to use testharness and new Audit.

BUG= 692724 
TEST=mediaelementaudiosourcenode.html

Review-Url: https://codereview.chromium.org/2695283003
Cr-Commit-Position: refs/heads/master@{#458141}

[delete] https://crrev.com/8fe439b946c4f1f5e4a15cd5d8be32cfb9e279a0/third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-expected.txt
[modify] https://crrev.com/973641c0ccf64c6c4c0919ed93cd3cd1f609b2e7/third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode.html

Comment 5 by rtoy@chromium.org, Mar 21 2017

Owner: rtoy@chromium.org
Status: Fixed (was: Available)
The following files are not going to be converted because they call gc():

MediaElementAudioSource/mediaelementaudiosourcenode-gc.html
MediaElementAudioSource/mediaelementaudiosourcenode-wrapper.html

Closing as fixed; we'll file another bug if we want to convert these.

Sign in to add a comment