Issue metadata
Sign in to add a comment
|
Remove KeyboardEvent#which and MouseEvent#which |
||||||||||||||||||||||||||||||||||||||||||||
Issue descriptionThese APIs are currently commented as non-standard APIs. Gecko has them too. I suppose we should try to standardize them?
,
Feb 15 2017
,
Feb 17 2017
,
Feb 23 2017
This is issue https://github.com/w3c/uievents/issues/35 mustaq@ I believe it was decided that we would standardize on UIEvent.which. Can you own this (ie; forcing gary to update the spec :-)) and then removing the implementation for the IDLs in KeyboardEvent and MouseEvent but leaving it for UIEvent?
,
Feb 23 2017
,
Mar 9 2017
,
Apr 27 2017
We already have Issue 543785 for the UIEvent spec work. Let's use this bug to remove Mouse/KeyboardEvent.which.
,
Apr 27 2017
foolip@ I think we can remove both {Mouse,Keyboard}Event.which without waiting for the spec work on UIEvent.which, right? We will then match FF. The current state across the browsers is terrible anyways:
https://github.com/w3c/uievents/issues/35#issuecomment-297822323
,
Apr 28 2017
,
Apr 28 2017
,
Apr 28 2017
,
May 2 2017
mustaq@, yep, I think this change can be done without waiting for anything else.
,
May 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf13270c47f29b21ce7a8c937f598989cd66c840 commit cf13270c47f29b21ce7a8c937f598989cd66c840 Author: mustaq <mustaq@chromium.org> Date: Wed May 24 12:33:29 2017 Removed |which| from KeyboardEvent and MouseEvent. Also changed the type of UIEvent.which to unsigned as per the spec. Blink intent thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/6V4iHkqZXvQ BUG= 692717 , 496400 Review-Url: https://codereview.chromium.org/2855613002 Cr-Commit-Position: refs/heads/master@{#474261} [modify] https://crrev.com/cf13270c47f29b21ce7a8c937f598989cd66c840/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/cf13270c47f29b21ce7a8c937f598989cd66c840/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/cf13270c47f29b21ce7a8c937f598989cd66c840/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/cf13270c47f29b21ce7a8c937f598989cd66c840/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/cf13270c47f29b21ce7a8c937f598989cd66c840/third_party/WebKit/Source/core/events/KeyboardEvent.cpp [modify] https://crrev.com/cf13270c47f29b21ce7a8c937f598989cd66c840/third_party/WebKit/Source/core/events/KeyboardEvent.h [modify] https://crrev.com/cf13270c47f29b21ce7a8c937f598989cd66c840/third_party/WebKit/Source/core/events/KeyboardEvent.idl [modify] https://crrev.com/cf13270c47f29b21ce7a8c937f598989cd66c840/third_party/WebKit/Source/core/events/MouseEvent.cpp [modify] https://crrev.com/cf13270c47f29b21ce7a8c937f598989cd66c840/third_party/WebKit/Source/core/events/MouseEvent.h [modify] https://crrev.com/cf13270c47f29b21ce7a8c937f598989cd66c840/third_party/WebKit/Source/core/events/MouseEvent.idl [modify] https://crrev.com/cf13270c47f29b21ce7a8c937f598989cd66c840/third_party/WebKit/Source/core/events/UIEvent.cpp [modify] https://crrev.com/cf13270c47f29b21ce7a8c937f598989cd66c840/third_party/WebKit/Source/core/events/UIEvent.h [modify] https://crrev.com/cf13270c47f29b21ce7a8c937f598989cd66c840/third_party/WebKit/Source/core/events/UIEvent.idl [modify] https://crrev.com/cf13270c47f29b21ce7a8c937f598989cd66c840/third_party/WebKit/Source/core/frame/UseCounter.h
,
May 24 2017
|
|||||||||||||||||||||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||||||||||||||||||||
Comment 1 by lunalu@chromium.org
, Feb 15 2017