webui resources should not contain 2x images |
||||
Issue descriptionMost images that are stored as 1x and 2x wind up living within chrome_100_percent.pak and chrome_200_percent.pak (and chrome_300_percent.pak) It looks like https://cs.chromium.org/chromium/src/ui/webui/resources/webui_resources.grd is including these assets directly in resources.pak though. This matters on Android because we purposefully don't ship the 2x variants in order to save space.
,
Feb 21 2017
Maybe... Do you know how I'd test this change? (e.g. navigate to X, which uses these resources?) As an aside, are there any scripts that ensure we don't have unused resources in: https://cs.chromium.org/chromium/src/ui/webui/resources/webui_resources.grd? The compiler-warning-based unused resource stripper doesn't work when grit generates .cc files for resources.
,
Feb 28 2017
i don't really know how you'd test that your change didn't break something, but things might not compile if the resource is flattened (and it doesn't exist). we probably don't have any scripts that look for unused resources in that file.
,
May 9 2017
,
Sep 21 2017
,
Sep 24
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||||
►
Sign in to add a comment |
||||
Comment 1 by dbeam@chromium.org
, Feb 15 2017Labels: -Pri-3 Pri-2
Owner: ----
Status: Available (was: Assigned)