Issue metadata
Sign in to add a comment
|
A cancelled touch-start should disable touch slop suppression |
||||||||||||||||||||||
Issue descriptionWe recently moved this into TouchEventManager but needed to move the check for cancelled touch-start as well.
,
Feb 16 2017
The CL causing this regression in M58 is crrev.com/2669663002. We merged the CL to M57 beta then switched back. So M57 is unaffected.
,
Feb 16 2017
Great, glad to hear M57 isn't affected - thanks! Marking this Pri-1 for M58 to indicate we really don't want to ship this regression (it's subtle but pretty bad for drawing apps).
,
Feb 17 2017
,
Feb 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be77e3f3b19b056f8ef9c5464ebadcc2d5bf25ac commit be77e3f3b19b056f8ef9c5464ebadcc2d5bf25ac Author: lanwei <lanwei@chromium.org> Date: Tue Feb 21 18:08:10 2017 Touchmoves should not be suppressed if the touchstart is consumed In a touch sequence starting with a touchstart, if the touchstart is consumed (prevent-defaulted), we will not suppress the following touchmoves even if they are in the slop regions. BUG= 692702 Review-Url: https://codereview.chromium.org/2701553002 Cr-Commit-Position: refs/heads/master@{#451796} [modify] https://crrev.com/be77e3f3b19b056f8ef9c5464ebadcc2d5bf25ac/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/be77e3f3b19b056f8ef9c5464ebadcc2d5bf25ac/third_party/WebKit/LayoutTests/fast/events/pointerevents/multi-pointer-event-in-slop-region.html [add] https://crrev.com/be77e3f3b19b056f8ef9c5464ebadcc2d5bf25ac/third_party/WebKit/LayoutTests/fast/events/pointerevents/pointer-event-consumed-touchstart-in-slop-region.html [modify] https://crrev.com/be77e3f3b19b056f8ef9c5464ebadcc2d5bf25ac/third_party/WebKit/LayoutTests/fast/events/pointerevents/pointer-event-in-slop-region.html [modify] https://crrev.com/be77e3f3b19b056f8ef9c5464ebadcc2d5bf25ac/third_party/WebKit/Source/core/input/TouchEventManager.cpp
,
Feb 21 2017
,
Feb 22 2017
,
Feb 28 2017
How does it affect mouse events PointerEvents? Do we need to call e.preventDefault() on touchstart event to prevent slop suppression even when using a digitizer pen or a mouse? In Chrome 56 slop suppression is affecting pen and mouse in paint apps.
,
Feb 28 2017
There is no slop suppression for non-touch events. Perhaps you should open a new bug and provide details there.
,
Feb 28 2017
Any PointerEvent based app that used to be affected by slop suppression will be fixed on M58, see Issue 593061 . Please comment on that bug if your problems are not fixed in M58. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rbyers@chromium.org
, Feb 16 2017