Issue metadata
Sign in to add a comment
|
Composition appears on previous line after typing "Enter" |
||||||||||||||||||||||
Issue descriptionChrome Version: 58.0.3012.0, Gboard 6.0.80.144232215 1) Go to textarea.org, delete all text if any 2) Type 'Abcde' 3) Type enter 4) Type 'Abcde' again Observe the first line of "Abcde" has the composition underline, not the second. From http://crbug.com/683387#c9 , bisected to http://crrev.com/2568093003 "Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText()" in #12
,
Feb 16 2017
,
Feb 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6923513dcedf4c6b55bc923fc0146aff71b3da46 commit 6923513dcedf4c6b55bc923fc0146aff71b3da46 Author: rlanday <rlanday@chromium.org> Date: Wed Feb 22 06:57:32 2017 Fix bug on Android causing composition underlines to appear in the wrong place The previous code I introduced in DocumentMarkerController::setComposition() was passing an offset measured in DOM children to addCompositionUnderlines() (and it wasn't even measured correctly) when it should have been passing an offset measured in plain text characters. Oops I'd like to add a test case for this bug, unfortunately I'm having trouble reproducing it in a test. BUG= 692699 Review-Url: https://codereview.chromium.org/2689233006 Cr-Commit-Position: refs/heads/master@{#451903} [modify] https://crrev.com/6923513dcedf4c6b55bc923fc0146aff71b3da46/third_party/WebKit/Source/core/editing/InputMethodController.cpp [modify] https://crrev.com/6923513dcedf4c6b55bc923fc0146aff71b3da46/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp
,
Feb 22 2017
,
Feb 22 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21aa8273bfcc29e0a7048213f667a0542451fa8c commit 21aa8273bfcc29e0a7048213f667a0542451fa8c Author: Alexandre Elias <aelias@chromium.org> Date: Wed Feb 22 22:05:12 2017 Fix bug on Android causing composition underlines to appear in the wrong place The previous code I introduced in DocumentMarkerController::setComposition() was passing an offset measured in DOM children to addCompositionUnderlines() (and it wasn't even measured correctly) when it should have been passing an offset measured in plain text characters. Oops I'd like to add a test case for this bug, unfortunately I'm having trouble reproducing it in a test. BUG= 692699 Review-Url: https://codereview.chromium.org/2689233006 Cr-Commit-Position: refs/heads/master@{#451903} (cherry picked from commit 6923513dcedf4c6b55bc923fc0146aff71b3da46) Review-Url: https://codereview.chromium.org/2709343002 . Cr-Commit-Position: refs/branch-heads/2987@{#646} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/21aa8273bfcc29e0a7048213f667a0542451fa8c/third_party/WebKit/Source/core/editing/InputMethodController.cpp [modify] https://crrev.com/21aa8273bfcc29e0a7048213f667a0542451fa8c/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp
,
Feb 22 2017
,
Mar 2 2017
verified on Acer Predator / LMY47I vs 57.0.2987.88
,
Mar 2 2017
Verified on Chrome Beta release "57.0.2987.88" |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by aelias@chromium.org
, Feb 15 2017