New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 692695 link

Starred by 13 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 674593


Show other hotlists

Hotlists containing this issue:
Non-Standard-IDL


Sign in to add a comment

Standardize or remove event.srcElement and event.returnValue

Project Member Reported by lunalu@chromium.org, Feb 15 2017

Issue description

Right now in Blink, it is commented as a non-standard API. Should we standardize it or remove it to improve interoperability? 
 

Comment 1 by foolip@chromium.org, Feb 16 2017

This is being added to DOM in https://github.com/whatwg/dom/pull/407, when that's merged we should update our IDL and make sure the implementation matches.
Owner: hayato@chromium.org
Status: assigned (was: Untriaged)
Cc: foolip@chromium.org

Comment 5 by tkent@chromium.org, Mar 15 2017

Components: -Blink>DOM>Events Blink>DOM
Remove Blink>DOM>Events

Comment 6 by hayato@chromium.org, Aug 28 2017

Owner: ----
Status: Available (was: Assigned)

Comment 7 by hayato@chromium.org, Aug 28 2017

Labels: Hotlist-GoodFirstBug

Comment 8 by hayato@chromium.org, Aug 28 2017

The PR for DOM hasn't been merged yet. I'll update IDL after it is merged.

Comment 9 by foolip@chromium.org, Sep 22 2017

 Issue 692698  has been merged into this issue.
Cc: kdub...@mozilla.com mi...@mozilla.com rbyers@chromium.org
Labels: Hotlist-Interop
Summary: Standardize or remove window.event, event.srcElement and event.returnValue (was: Standardize or remove Event#returnValue)
Updating the title to reflect all of the changes in https://github.com/whatwg/dom/pull/407.

This is a real problem for Firefox, and so we should prioritize helping get this standardized, to document whatever our behavior is and write tests for that.

Comment 11 Deleted

Comment 12 by kochi@chromium.org, Nov 29 2017

Can this be merged into  issue 223749 ?
Summary: Standardize or remove event.srcElement and event.returnValue (was: Standardize or remove window.event, event.srcElement and event.returnValue)
I'll drop window.event from the title of this one, allowing  issue 223749  to track that.
Cc: domfarolino@gmail.com
WebKit has changed their returnValue implementation to match the new spec:
https://bugs.webkit.org/show_bug.cgi?id=184415

Comment 17 by ratsu...@gmail.com, Jun 24 2018

I'd like to work on this issue and have a question

Seems |prevent_default_called_during_passive_| and |prevent_default_called_on_uncancelable_event_| are used to do some statistics, should |setReturnValue| set these flags too or just set the cancel flag per standard?
Cc: dtapu...@chromium.org tkent@chromium.org
 Issue 277851  has been merged into this issue.
ratsunny@

> Seems |prevent_default_called_during_passive_| and |prevent_default_called_on_uncancelable_event_| are used to do some statistics, 

Could you kindly explain what "do some statistics" means?
If possible, it's totally fine to update a CL to discuss there.
Hi hayato@
|prevent_default_called_during_passive_| is used to do metric here
https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/dom/events/event_target.cc?gsn=passive_forced_histogram&l=837

|prevent_default_called_on_uncancelable_event_| used to have metrics but seems it has been removed
You can check original CL here (at line 633): https://codereview.chromium.org/2137483003/diff/100001/third_party/WebKit/Source/core/events/EventTarget.cpp

Sign in to add a comment