Offline forced page should take priority over previews |
||||||
Issue descriptionIf a user opens an offline page after downloading (via the notification bar for instance), they should be shown the normal offline page UI regardless of if the conditions to show a preview are met. Right now, the previews info bar is shown when the user is in the previews enabled group and the network is slow for these types of navigations.
,
Feb 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfe9f69720945551289fd7dba30f1b825e72c830 commit dfe9f69720945551289fd7dba30f1b825e72c830 Author: ryansturm <ryansturm@chromium.org> Date: Wed Feb 15 23:01:19 2017 Re-ordering triggering priority of offline pages Force offline when connected should be higher priority than offline previews. When users force an offline page, it makes little sense to show the offline previews UI, as chrome did not intervene to show a preview. BUG= 692690 Review-Url: https://codereview.chromium.org/2697113002 Cr-Commit-Position: refs/heads/master@{#450829} [modify] https://crrev.com/dfe9f69720945551289fd7dba30f1b825e72c830/chrome/browser/android/offline_pages/offline_page_request_job.cc
,
Feb 15 2017
Please apply appropriate OS labels. Thank you.
,
Feb 15 2017
,
Feb 16 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1589975e43f4456175169c1d379fe5382244096f commit 1589975e43f4456175169c1d379fe5382244096f Author: Ryan Sturm <ryansturm@chromium.org> Date: Thu Feb 16 17:36:49 2017 Re-ordering triggering priority of offline pages Force offline when connected should be higher priority than offline previews. When users force an offline page, it makes little sense to show the offline previews UI, as chrome did not intervene to show a preview. BUG= 692690 Review-Url: https://codereview.chromium.org/2697113002 Cr-Commit-Position: refs/heads/master@{#450829} (cherry picked from commit dfe9f69720945551289fd7dba30f1b825e72c830) Review-Url: https://codereview.chromium.org/2699933002 . Cr-Commit-Position: refs/branch-heads/2987@{#549} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/1589975e43f4456175169c1d379fe5382244096f/chrome/browser/android/offline_pages/offline_page_request_job.cc
,
Feb 16 2017
,
Apr 27 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ryansturm@chromium.org
, Feb 15 2017Labels: M-57 Merge-Request-57