Page info button tooltip isn't consistent between Mac and Win/Linux |
||||
Issue descriptionChrome Version: (copy from chrome://version) OS: (e.g. Win7, OSX 10.9.5, etc...) What steps will reproduce the problem? (1) Go to google.com (2) Hover over the "Secure" text in the omnibox What is the expected result? On Mac, the text reads "Secure. View site information". On Windows/Linux, it only says "View site information". What happens instead? Mac change was made in crrev.com/2407853002 for accessibility. Windows/Linux should probably do the same.
,
Feb 15 2017
Also see Issue 685818 (iOS page security button VoiceOver does not read security level).
,
Mar 13 2017
The Mac version copies the Security Chip's verbose state text into the tooltip; that includes "Dangerous" or the EV certificate information, etc. No additional string is shown when the chip is empty (e.g. showing the (i) icon on a HTTP site). It's not clear to me how valuable the addition of this text is if we don't need it copied there for accessibility purposes?
,
Mar 13 2017
I guess one nice benefit is that if the Omnibox is small and the Security chip is elipsized, the text of the tooltip would contain the full string. Update looks simple enough, update LocationIconView::GetTooltipText with the contents of label()->text() + ". " + l10n_util::GetStringUTF16(IDS_TOOLTIP_LOCATION_ICON)
,
Mar 14 2017
,
Mar 14 2017
Thanks for taking this Eric! Maybe not for this bug, but we might also want to have two different strings for this instead of building one by appending strings, as it might not work for all locales.
,
Mar 14 2017
I don't have strong feelings, but if I were doing this from scratch, I'd split the text across two lines: [Verbose State Text] [Fixed String: Click to view information] I think this poses fewer loc concerns and it looks better. (It's what IE does.)
,
Mar 14 2017
That SGTM too.
,
Mar 14 2017
Mail sent to the Harmony UI experts.
,
Mar 14 2017
Consider that not all users (even on "desktop") use a mouse (there's keyboard nav/accessibility/touch) => may want to use "press" instead of "click"?
,
Mar 14 2017
Re 10: The actual fixed text is just "View site information"
,
Mar 14 2017
It turns out that the ellipsis justification is already void on Windows; if the text has been ellipsized, it already shows the full text if you hover over the text (not the icon). That behavior comes from the Label() control in the IconLabelBubbleView. https://cs.chromium.org/chromium/src/ui/views/controls/label.h?type=cs&l=123 On Mac, the system seems to automatically wrap long tooltips; visiting washingtonpost.com with a narrow window, it already uses two lines for the message.
,
Mar 16 2017
After discussion with the UX team, the string "View site information" should remain the tooltip and the Mac version should change to update its accessibility info using a mechanism other than the tooltip. I've filed Issue 702406 to change the Mac implementation. |
||||
►
Sign in to add a comment |
||||
Comment 1 by mea...@chromium.org
, Feb 15 2017