New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 692669 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Simplify DEFINE_THREAD_SAFE_STATIC_LOCAL()

Reported by sigbjo...@opera.com, Feb 15 2017

Issue description

With issue 686866, threadsafe statics are now enabled when compiling Chromium + Blink.

Follow up on the Blink side and simplify away DEFINE_THREAD_SAFE_STATIC_LOCAL() usage.
 

Comment 1 by sigbjo...@opera.com, Feb 16 2017

Summary: Simplify DEFINE_THREAD_SAFE_STATIC_LOCAL() (was: Replace DEFINE_THREAD_SAFE_STATIC_LOCAL() with DEFINE_STATIC_LOCAL()s.)

Comment 2 by sigbjo...@opera.com, Feb 17 2017

Owner: sigbjo...@opera.com
Status: Fixed (was: Untriaged)
Mea culpa, unintentionally left out this issue on the BUG= line -
 https://codereview.chromium.org/2680843006/

I'm leaning towards having to explicitly declare a static-local as being either cross-thread- or single-thread accessible; it conveys useful threading information, but also catches out attempts to use the single-thread version across threads.

Sign in to add a comment