The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12d8162192a87421118c38875939be33fda31d9a

commit 12d8162192a87421118c38875939be33fda31d9a
Author: martiniss <martiniss@chromium.org>
Date: Wed Feb 15 22:58:24 2017

Disable smoothness.maps on windows builders

It was re-enabled in c2e7e0a2c9fb07ddc5cb71ef91ac0c157330fb61,
but still fails on windows.

BUG= 692663 

Review-Url: https://codereview.chromium.org/2696243002
Cr-Commit-Position: refs/heads/master@{#450827}

[modify] https://crrev.com/12d8162192a87421118c38875939be33fda31d9a/tools/perf/benchmarks/smoothness.py

This is disappointing. Looking at the logs from one of these runs:
https://build.chromium.org/p/chromium.perf/builders/Win%207%20Nvidia%20GPU%20Perf/builds/401

Specifically:
https://chromium-swarm.appspot.com/task?id=345b59dc966a5f10&refresh=10&show_raw=1

the log is as follows:

----------
WARNING:root:Exception was raised in the with statement block, the end of interaction record is not marked.
INFO:root:*************** BROWSER STANDARD OUTPUT ***************
INFO:root:
INFO:root:*********** END OF BROWSER STANDARD OUTPUT ************
INFO:root:********************* BROWSER LOG *********************
INFO:root:No log file
INFO:root:***************** END OF BROWSER LOG ******************
Traceback (most recent call last):
  File "c:\b\s\w\irdiybsa\third_party\catapult\telemetry\telemetry\internal\story_runner.py", line 97, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "c:\b\s\w\irdiybsa\third_party\catapult\common\py_trace_event\py_trace_event\trace_event_impl\decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "c:\b\s\w\irdiybsa\third_party\catapult\telemetry\telemetry\page\shared_page_state.py", line 299, in RunStory
    self._current_page.Run(self)
  File "c:\b\s\w\irdiybsa\third_party\catapult\telemetry\telemetry\page\__init__.py", line 112, in Run
    self.RunPageInteractions(action_runner)
  File "c:\b\s\w\irdiybsa\tools\perf\page_sets\maps.py", line 33, in RunPageInteractions
    'window.testMetrics != undefined', timeout=120)
  File "c:\b\s\w\irdiybsa\third_party\catapult\common\py_trace_event\py_trace_event\trace_event_impl\decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "c:\b\s\w\irdiybsa\third_party\catapult\telemetry\telemetry\internal\actions\action_runner.py", line 254, in WaitForJavaScriptCondition2
    return self._tab.WaitForJavaScriptCondition2(*args, **kwargs)
  File "c:\b\s\w\irdiybsa\third_party\catapult\common\py_trace_event\py_trace_event\trace_event_impl\decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "c:\b\s\w\irdiybsa\third_party\catapult\telemetry\telemetry\internal\browser\web_contents.py", line 209, in WaitForJavaScriptCondition2
    return self._inspector_backend.WaitForJavaScriptCondition2(*args, **kwargs)
  File "c:\b\s\w\irdiybsa\third_party\catapult\common\py_trace_event\py_trace_event\trace_event_impl\decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "c:\b\s\w\irdiybsa\third_party\catapult\telemetry\telemetry\internal\backends\chrome_inspector\inspector_backend.py", line 294, in WaitForJavaScriptCondition2
    e.message + '\n' + debug_message)
TimeoutException: Timed out while waiting 120s for IsJavaScriptExpressionTrue.
Console output:


c:\b\s\w\irdiybsa\third_party\catapult\telemetry\telemetry\internal\image_processing\_bitmap.py:152: UserWarning: Using pure python png decoder, which could be very slow. To speed up, consider installing numpy & cv2 (OpenCV).
  'Using pure python png decoder, which could be very slow. To speed up, '
INFO:root:Chrome version: 3014
ERROR:root:Error when deleting c:\b\s\w\ithok1ut\tmpnqlfwx, will try again at exit.
Traceback (most recent call last):
  File "c:\b\s\w\irdiybsa\third_party\catapult\telemetry\telemetry\internal\platform\tracing_controller_backend.py", line 285, in CollectAgentTraceData
    os.remove(self._trace_log)
WindowsError: [Error 32] The process cannot access the file because it is being used by another process: 'c:\\b\\s\\w\\ithok1ut\\tmpnqlfwx'
[  FAILED  ] http://localhost:8000/performance.html (148132 ms)
INFO:root:Successfully shut down browser cooperatively
INFO:py_utils.cloud_storage:Uploading c:\b\s\w\ithok1ut\tmpdceq3d.png to gs://chrome-telemetry-output/profiler-file-id_0-2017-02-15_09-46-0172965.png
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ]  http://localhost:8000/performance.html

1 FAILED TEST
----------

This test is running reliably on the chromium.gpu and chromium.gpu.fyi bots, including on Windows on similar hardware.

I noticed that the graphics driver on this machine is two years old:

INFO:root:Discovered ephemeral port 50114
INFO:root:OS: win win7
INFO:root:GPU device 0: VENDOR = 0x10de (Nvidia), DEVICE = 0x104a
INFO:root:GPU device 1: VENDOR = 0x102b, DEVICE = 0x534
INFO:root:GPU Attributes:
INFO:root:  amd_switchable      : False
INFO:root:  basic_info_state    : 1
INFO:root:  context_info_state  : 1
INFO:root:  direct_rendering    : True
INFO:root:  driver_date         : 3-13-2015
INFO:root:  driver_vendor       : NVIDIA
INFO:root:  driver_version      : 9.18.13.4788
I

Where the maps_pixel_test run on this machine:
https://build.chromium.org/p/chromium.gpu/builders/Win7%20Release%20%28NVIDIA%29/builds/63806

indicates a more recent driver:
https://chromium-swarm.appspot.com/task?id=3460ee1219873710&refresh=10&show_raw=1

(INFO) 2017-02-16 10:09:31,798 browser._LogBrowserInfo:123  GPU device 0: VENDOR = 0x10de (Nvidia), DEVICE = 0x104a
(INFO) 2017-02-16 10:09:31,798 browser._LogBrowserInfo:123  GPU device 1: VENDOR = 0x102b, DEVICE = 0x534
(INFO) 2017-02-16 10:09:31,798 browser._LogBrowserInfo:125  GPU Attributes:
(INFO) 2017-02-16 10:09:31,798 browser._LogBrowserInfo:127    amd_switchable      : False
(INFO) 2017-02-16 10:09:31,799 browser._LogBrowserInfo:127    basic_info_state    : 1
(INFO) 2017-02-16 10:09:31,799 browser._LogBrowserInfo:127    context_info_state  : 1
(INFO) 2017-02-16 10:09:31,799 browser._LogBrowserInfo:127    direct_rendering    : True
(INFO) 2017-02-16 10:09:31,799 browser._LogBrowserInfo:127    driver_date         : 8-11-2016
(INFO) 2017-02-16 10:09:31,799 browser._LogBrowserInfo:127    driver_vendor       : NVIDIA
(INFO) 2017-02-16 10:09:31,799 browser._LogBrowserInfo:127    driver_version      : 21.21.13.7254


Could that be part of the problem?

Ken@: In general, should we always updated to driver to the latest/most common? In general, I think the gpu driver version on the perf bot we use should match what GPU team for correctness testing, wdyt?

The benchmark runs OK on my local Win7 machine. 

The failures happened only on windows-2008serverr2-sp1 bots (nvidia and ati). For some reason JS code is not signalling the end of run within 120 seconds. 

Win 10 High-DPI Perf and Win Zenbook Perf failures linked in the first post are unrelated to the benchmark.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fa06ed06c2ff9051db06432e631dd45b32f7b1d

commit 5fa06ed06c2ff9051db06432e631dd45b32f7b1d
Author: kbr <kbr@chromium.org>
Date: Mon Jun 26 17:38:14 2017

Attempt to re-enable smoothness.maps on Windows.

BUG= 692663 

Review-Url: https://codereview.chromium.org/2957493002
Cr-Commit-Position: refs/heads/master@{#482308}

[modify] https://crrev.com/5fa06ed06c2ff9051db06432e631dd45b32f7b1d/tools/perf/benchmarks/smoothness.py

Taking this bug. It seems clear that the test's failing because of a problem with the WPR server.

Blocked this on xunjieli@'s rewrite of the WPR server in Go per https://bugs.chromium.org/p/chromium/issues/detail?id=737657#c5 .

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e569358d483e0c2b8eb1a4f4868267589d96d17

commit 0e569358d483e0c2b8eb1a4f4868267589d96d17
Author: Kenneth Russell <kbr@chromium.org>
Date: Fri Jul 07 01:59:27 2017

Disable smoothness.maps on Windows again.

There's a race condition in the WPR server still preventing it from
running reliably.

BUG= 692663 ,  737657 
TBR=nednguyen@google.com
NOTRY=true

Change-Id: Ic2d0f9d85747958e752705536f85b41823977b71
Reviewed-on: https://chromium-review.googlesource.com/562749
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484788}
[modify] https://crrev.com/0e569358d483e0c2b8eb1a4f4868267589d96d17/tools/perf/benchmarks/smoothness.py

 Issue 737144  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80638c164335ae4a97d134544f789c26c9493597

commit 80638c164335ae4a97d134544f789c26c9493597
Author: Kenneth Russell <kbr@chromium.org>
Date: Thu Aug 24 16:52:09 2017

Re-enable smoothness.maps on Windows again.

Now that it's been converted to the new wprgo server in  Issue 756002 ,
it should run reliably on Windows.

BUG= 692663 

Change-Id: Iad6a29c4f5652008df32f665132c466da6a1b19a
Reviewed-on: https://chromium-review.googlesource.com/631138
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497087}
[modify] https://crrev.com/80638c164335ae4a97d134544f789c26c9493597/tools/perf/benchmarks/smoothness.py

In this first build containing the re-enabled test:
https://luci-milo.appspot.com/buildbot/chromium.perf/Win%207%20Nvidia%20GPU%20Perf/1174

It passed on top-of-tree Chromium, but failed on the reference build. Is it possible a bad reference build was picked the last time it was rolled?

The Win7 ATI GPU Perf bot looks in bad shape:
https://luci-milo.appspot.com/buildbot/chromium.perf/Win%207%20ATI%20GPU%20Perf/

The first results haven't come back from Win10 High-DPI Perf:
https://luci-milo.appspot.com/buildbot/chromium.perf/Win%2010%20High-DPI%20Perf/

Finally, Win Zenbook Perf isn't running any tests:
https://luci-milo.appspot.com/buildbot/chromium.perf/Win%20Zenbook%20Perf/

The current builds on the Win7 NVIDIA and Win10 High-DPI perf bots are looking good. The benchmark is passing.

https://luci-milo.appspot.com/buildbot/chromium.perf/Win%207%20Nvidia%20GPU%20Perf/1177

https://luci-milo.appspot.com/buildbot/chromium.perf/Win%2010%20High-DPI%20Perf/934

Closing as fixed.

Turning around blocking/blocked on relationship for a few bugs.