New issue
Advanced search Search tips

Issue 692662 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 671375



Sign in to add a comment

Clear auto-opening settings is missing from MD settings

Project Member Reported by mahmadi@chromium.org, Feb 15 2017

Issue description

Please see the attachment.
Tested on 58.0.3013.0 canary (64-bit)
 
md-settings-downloads_CLIPCHAMP_1080p.mp4
3.9 MB View Download
Components: UI>Settings
Blocking: 671375
Cc: tbuck...@chromium.org
Labels: -Pri-3 Hotlist-MD-Settings-Downloads Proj-MaterialDesign-WebUI Pri-1
Owner: dbeam@chromium.org
Status: Assigned (was: Untriaged)
@dbeam who could take this on? Marked as Pri-1 since it is missing functionality.

See also  Issue 460379 

Comment 3 by dbeam@chromium.org, Feb 21 2017

Cc: tommycli@chromium.org
Owner: ----
tommycli@ loves obscure things from old options
Owner: tommycli@chromium.org
Yeah, love this stuff <3
Cc: bettes@chromium.org
bettes, tbuckley:

You guys have a specific UI in mind?

Maybe just a Settings row with the message:

"You have chosen to open certain file types automatically after downloading." (same as Options) with a Clear button on the right? 

And the whole row is hidden when there's no auto-open file types?

This would be the same format as the first row in People and Appearance.
@tommycli the UI from #5 sounds good, thanks!
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/915915168110d5bc831be6bfdae58a106f1a3cfe

commit 915915168110d5bc831be6bfdae58a106f1a3cfe
Author: tommycli <tommycli@chromium.org>
Date: Tue Feb 28 21:31:42 2017

MD Settings: Add "Auto Open" setting to Downloads page UI.

BUG= 692662 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2713343003
Cr-Commit-Position: refs/heads/master@{#453707}

[modify] https://crrev.com/915915168110d5bc831be6bfdae58a106f1a3cfe/chrome/app/settings_strings.grdp
[modify] https://crrev.com/915915168110d5bc831be6bfdae58a106f1a3cfe/chrome/browser/resources/settings/downloads_page/compiled_resources2.gyp
[add] https://crrev.com/915915168110d5bc831be6bfdae58a106f1a3cfe/chrome/browser/resources/settings/downloads_page/downloads_browser_proxy.html
[add] https://crrev.com/915915168110d5bc831be6bfdae58a106f1a3cfe/chrome/browser/resources/settings/downloads_page/downloads_browser_proxy.js
[modify] https://crrev.com/915915168110d5bc831be6bfdae58a106f1a3cfe/chrome/browser/resources/settings/downloads_page/downloads_page.html
[modify] https://crrev.com/915915168110d5bc831be6bfdae58a106f1a3cfe/chrome/browser/resources/settings/downloads_page/downloads_page.js
[modify] https://crrev.com/915915168110d5bc831be6bfdae58a106f1a3cfe/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/915915168110d5bc831be6bfdae58a106f1a3cfe/chrome/browser/ui/webui/settings/downloads_handler.cc
[modify] https://crrev.com/915915168110d5bc831be6bfdae58a106f1a3cfe/chrome/browser/ui/webui/settings/downloads_handler.h
[modify] https://crrev.com/915915168110d5bc831be6bfdae58a106f1a3cfe/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/915915168110d5bc831be6bfdae58a106f1a3cfe/chrome/test/data/webui/settings/cr_settings_browsertest.js
[add] https://crrev.com/915915168110d5bc831be6bfdae58a106f1a3cfe/chrome/test/data/webui/settings/downloads_page_test.js

Status: Fixed (was: Assigned)

Sign in to add a comment