New issue
Advanced search Search tips

Issue 692650 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

decode-audio-data-basic.html needs to test decoding after context closure correctly.

Project Member Reported by hongchan@chromium.org, Feb 15 2017

Issue description

The last task in decode-audio-data-basic.html is not testing
what it is supposed to.

Fix the task so we can test:
- decodeAudioData() works correctly after the context closure.
- Use the same audio context for the comparison of decoded buffers.
 
Status: Assigned (was: Available)
We have a conflict for the second task. With the resolution of  issue 704679 , we cannot decode a same ArrayBuffer twice thus comparing two decoded results between the active and the closed context is impossible. (The buffer is supposed to be neutered after the first decoding.)

Perhaps testing the first task only would be good enough?  
Hmm. It seems like the last task is doing what it is supposed to do:
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/webaudio/decodeAudioData/decode-audio-data-basic.html?q=decode-audio-dat+package:%5Echromium$&l=128

It could use the better label, but the task looks correct.
Status: Started (was: Assigned)
Status: Verified (was: Started)
Closed with https://codereview.chromium.org/2775853002/.

Sign in to add a comment