New issue
Advanced search Search tips

Issue 692647 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

The user should be able to disable BackgroundFetch

Project Member Reported by harkness@chromium.org, Feb 15 2017

Issue description

By default, BackgroundFetch will be enabled for all origins. The limitation on use is that an in-progress notification is shown. However, if the user feels that fetch is a "bad thing" (technical term), they should be able to disable it.
 
Cc: mlamouri@chromium.org
Project Member

Comment 2 by sheriffbot@chromium.org, Mar 7 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by peter@chromium.org, Mar 7 2018

Owner: na...@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by peter@chromium.org, Mar 7 2018

Labels: -Hotlist-Recharge-Cold

Comment 5 by na...@chromium.org, May 30 2018

Status: Started (was: Assigned)
Labels: BlocksMVP
Owner: ----
Status: Available (was: Started)
After discussing my design doc with chrome security enamel, we've agreed to reuse the Automatic Downloads site setting for this.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e30a0e8ee0c46942dcf24d9af513c6661269733e

commit e30a0e8ee0c46942dcf24d9af513c6661269733e
Author: Rayan Kanso <rayankans@chromium.org>
Date: Tue Aug 14 17:18:17 2018

[Background Fetch] Register interface via RenderFrameHostImpl

In order to support permissions for Background Fetch, the
RenderFrameHost should be made available. The binding is done from
RenderFrameHostImpl now, with RendererInterfaceBinders left as
a fallback (to register from service worker contexts for example).

Bug:  692647 
Change-Id: I3e12b60f410ba104601c68392a07fe24da1cc220
Reviewed-on: https://chromium-review.googlesource.com/1172785
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582954}
[modify] https://crrev.com/e30a0e8ee0c46942dcf24d9af513c6661269733e/content/browser/background_fetch/background_fetch_service_impl.cc
[modify] https://crrev.com/e30a0e8ee0c46942dcf24d9af513c6661269733e/content/browser/background_fetch/background_fetch_service_impl.h
[modify] https://crrev.com/e30a0e8ee0c46942dcf24d9af513c6661269733e/content/browser/background_fetch/background_fetch_service_unittest.cc
[modify] https://crrev.com/e30a0e8ee0c46942dcf24d9af513c6661269733e/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/e30a0e8ee0c46942dcf24d9af513c6661269733e/content/browser/renderer_interface_binders.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/697f60cadf1089fb596260abe7ae3f6f2db776d4

commit 697f60cadf1089fb596260abe7ae3f6f2db776d4
Author: Rayan Kanso <rayankans@chromium.org>
Date: Thu Aug 23 08:10:00 2018

[Background Fetch] Incorporate DownloadRequestLimiter with BGF.

This will use the same permission model for downloads (only framed
contexts) when a fetch is started.

The permission will be checked every time a fetch starts (in the browser
process) to prevent race conditions.

Bug:  692647 
Change-Id: Id67682cadaec3c0669d4308ac69e60447353a4e8
Reviewed-on: https://chromium-review.googlesource.com/1178281
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585424}
[modify] https://crrev.com/697f60cadf1089fb596260abe7ae3f6f2db776d4/chrome/browser/background_fetch/background_fetch_browsertest.cc
[modify] https://crrev.com/697f60cadf1089fb596260abe7ae3f6f2db776d4/chrome/browser/background_fetch/background_fetch_delegate_impl.cc
[modify] https://crrev.com/697f60cadf1089fb596260abe7ae3f6f2db776d4/chrome/browser/background_fetch/background_fetch_delegate_impl.h
[modify] https://crrev.com/697f60cadf1089fb596260abe7ae3f6f2db776d4/chrome/browser/download/download_request_limiter.h
[modify] https://crrev.com/697f60cadf1089fb596260abe7ae3f6f2db776d4/chrome/test/data/background_fetch/background_fetch.js
[modify] https://crrev.com/697f60cadf1089fb596260abe7ae3f6f2db776d4/content/browser/background_fetch/background_fetch_context.cc
[modify] https://crrev.com/697f60cadf1089fb596260abe7ae3f6f2db776d4/content/browser/background_fetch/background_fetch_context.h
[modify] https://crrev.com/697f60cadf1089fb596260abe7ae3f6f2db776d4/content/browser/background_fetch/background_fetch_delegate_proxy.cc
[modify] https://crrev.com/697f60cadf1089fb596260abe7ae3f6f2db776d4/content/browser/background_fetch/background_fetch_delegate_proxy.h
[modify] https://crrev.com/697f60cadf1089fb596260abe7ae3f6f2db776d4/content/browser/background_fetch/background_fetch_delegate_proxy_unittest.cc
[modify] https://crrev.com/697f60cadf1089fb596260abe7ae3f6f2db776d4/content/browser/background_fetch/background_fetch_service_impl.cc
[modify] https://crrev.com/697f60cadf1089fb596260abe7ae3f6f2db776d4/content/browser/background_fetch/background_fetch_service_impl.h
[modify] https://crrev.com/697f60cadf1089fb596260abe7ae3f6f2db776d4/content/browser/background_fetch/mock_background_fetch_delegate.cc
[modify] https://crrev.com/697f60cadf1089fb596260abe7ae3f6f2db776d4/content/browser/background_fetch/mock_background_fetch_delegate.h
[modify] https://crrev.com/697f60cadf1089fb596260abe7ae3f6f2db776d4/content/public/browser/background_fetch_delegate.h
[modify] https://crrev.com/697f60cadf1089fb596260abe7ae3f6f2db776d4/content/shell/browser/layout_test/layout_test_background_fetch_delegate.cc
[modify] https://crrev.com/697f60cadf1089fb596260abe7ae3f6f2db776d4/content/shell/browser/layout_test/layout_test_background_fetch_delegate.h
[modify] https://crrev.com/697f60cadf1089fb596260abe7ae3f6f2db776d4/third_party/blink/public/platform/modules/background_fetch/background_fetch.mojom
[modify] https://crrev.com/697f60cadf1089fb596260abe7ae3f6f2db776d4/third_party/blink/renderer/modules/background_fetch/background_fetch_manager.cc
[modify] https://crrev.com/697f60cadf1089fb596260abe7ae3f6f2db776d4/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc
[modify] https://crrev.com/697f60cadf1089fb596260abe7ae3f6f2db776d4/third_party/blink/renderer/modules/background_fetch/background_fetch_update_ui_event.cc
[modify] https://crrev.com/697f60cadf1089fb596260abe7ae3f6f2db776d4/tools/metrics/histograms/enums.xml

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71f316c5258e0fb88fc930263836ea8ca6f0c811

commit 71f316c5258e0fb88fc930263836ea8ca6f0c811
Author: Rayan Kanso <rayankans@chromium.org>
Date: Thu Aug 23 13:27:51 2018

[Background Fetch] Only use permission UI if the frame is the top one.

For any child frames, the permission model will follow that of worker
contexts.

Bug:  692647 
Change-Id: Ibb9d8a0fde4f7f61188ae11edd8600f1775acd4c
Reviewed-on: https://chromium-review.googlesource.com/1186331
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585467}
[modify] https://crrev.com/71f316c5258e0fb88fc930263836ea8ca6f0c811/chrome/browser/background_fetch/background_fetch_browsertest.cc
[modify] https://crrev.com/71f316c5258e0fb88fc930263836ea8ca6f0c811/chrome/test/data/background_fetch/background_fetch.js
[add] https://crrev.com/71f316c5258e0fb88fc930263836ea8ca6f0c811/chrome/test/data/background_fetch/background_fetch_iframe.html
[modify] https://crrev.com/71f316c5258e0fb88fc930263836ea8ca6f0c811/content/browser/background_fetch/background_fetch_context.cc

Status: Fixed (was: Available)

Sign in to add a comment