New issue
Advanced search Search tips

Issue 692643 link

Starred by 1 user
Status: Fixed
Owner:
se...@chromium.org
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Make the normalization helper cancel after a specified delay.

Project Member Reported by se...@chromium.org, Feb 15 2017 
Change the helper to take a time limit along with the other normalization parameters. Make it call onCouldNotNormalize if the time delay is reached.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a2f0a362c5c1257d5893f973eb6e2e6696faa04

commit 5a2f0a362c5c1257d5893f973eb6e2e6696faa04
Author: sebsg <sebsg@chromium.org>
Date: Wed Feb 22 18:24:44 2017

[Payments] Add timeout to the address_normalizer.

Adds a timeout parameter to the AddressNormalizer so that the requester will always receive a response before that time limit (be it a successful normalization or not).

BUG= 692643 

Review-Url: https://codereview.chromium.org/2708933003
Cr-Commit-Position: refs/heads/master@{#452138}

[modify] https://crrev.com/5a2f0a362c5c1257d5893f973eb6e2e6696faa04/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
[modify] https://crrev.com/5a2f0a362c5c1257d5893f973eb6e2e6696faa04/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
[modify] https://crrev.com/5a2f0a362c5c1257d5893f973eb6e2e6696faa04/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/5a2f0a362c5c1257d5893f973eb6e2e6696faa04/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentResponseHelper.java
[modify] https://crrev.com/5a2f0a362c5c1257d5893f973eb6e2e6696faa04/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/5a2f0a362c5c1257d5893f973eb6e2e6696faa04/chrome/browser/autofill/android/personal_data_manager_android.h
[modify] https://crrev.com/5a2f0a362c5c1257d5893f973eb6e2e6696faa04/components/payments/BUILD.gn
[modify] https://crrev.com/5a2f0a362c5c1257d5893f973eb6e2e6696faa04/components/payments/address_normalizer.cc
[modify] https://crrev.com/5a2f0a362c5c1257d5893f973eb6e2e6696faa04/components/payments/address_normalizer.h
[add] https://crrev.com/5a2f0a362c5c1257d5893f973eb6e2e6696faa04/components/payments/address_normalizer_unittest.cc
[modify] https://crrev.com/5a2f0a362c5c1257d5893f973eb6e2e6696faa04/third_party/libaddressinput/BUILD.gn

Comment 2 by se...@chromium.org, Feb 22 2017

Status: Fixed (was: Assigned)

Comment 3 by lafo...@chromium.org, Jun 27 2017

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
►

Sign in to add a comment