New issue
Advanced search Search tips

Issue 692631 link

Starred by 2 users
Status: Fixed
Owner:
eui-sang.lim@samsung.com
Closed: Oct 1
Cc:
foolip@chromium.org
editing-dev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 674593


Show other hotlists

Hotlists containing this issue:
Non-Standard-IDL


Sign in to add a comment

Move Element#onselectstart to GlobalEventHandlers#onselectstart

Project Member Reported by lunalu@chromium.org, Feb 15 2017 
If it has been standardized please add a link to it in Element.idl

Webkit has Element#onselectstart. Gecko has it in GlobalEventHandler.

Let's make a decision what to do here to improve the interoperability here.

Thanks

Comment 1 by dominicc@chromium.org, Feb 22 2017

Components: -Blink>DOM>Events Blink>Editing
Labels: Hotlist-Interop
Owner: yosin@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by yosin@chromium.org, Feb 22 2017

Components: -Blink>Editing Blink>Editing>Selection
Owner: yoichio@chromium.org
yoichio@, you call. (^_^)

The spec[1] defines "selectstart", Element#onselectstart should be in the spec.
I think we should put Element#onselectionchange too, since it is in the spec[1].

[1] https://w3c.github.io/selection-api/#selectstart-event

Comment 3 by foolip@chromium.org, Mar 9 2017

Summary: Move Element#onselectstart to GlobalEventHandlers#onselectstart (was: Standardize or remove Element#onselectstart)
https://w3c.github.io/selection-api/#extensions-to-globaleventhandlers defines the event handler attributes, so just need to match that now.

Comment 4 by foolip@chromium.org, Mar 9 2017

Cc: foolip@chromium.org

Comment 5 by yoichio@chromium.org, Jul 20 2017

Labels: -Pri-3 Pri-2

Comment 6 by yoichio@chromium.org, Aug 2 2017

Status: Started (was: Assigned)

Comment 7 by yosin@chromium.org, Oct 4 2017

Labels: Pri-3

Comment 8 by yoichio@chromium.org, Sep 28

Owner: ----
Status: Available (was: Started)

Comment 9 by eui-sang.lim@samsung.com, Oct 1

Owner: eui-sang.lim@samsung.com
Status: Started (was: Available)
I would like take this issue. if no one is working on it.
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15fff438fcb1c05481d0f1b9bff6cccfa85af14a

commit 15fff438fcb1c05481d0f1b9bff6cccfa85af14a
Author: Amos Lim <eui-sang.lim@samsung.com>
Date: Mon Oct 01 10:20:26 2018

Move onselectionchange and onselectstart to GlobalEventHandlers

Move Document#onselectionchange, Document#onselectstart, and
Element#onselectstart to GlobalEventHandlers as per the spec[1].

[1]: https://w3c.github.io/selection-api/#extensions-to-globaleventhandlers

Bug:  692631 
Change-Id: Icc940336827f42e73e40b9f62cd8d4a6552fbd8b
Reviewed-on: https://chromium-review.googlesource.com/1252225
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Amos Lim <eui-sang.lim@samsung.com>
Cr-Commit-Position: refs/heads/master@{#595420}
[delete] https://crrev.com/dcf6a53d02cf8534f0497395cc6f42d6b7381b9b/third_party/WebKit/LayoutTests/external/wpt/selection/idlharness.window-expected.txt
[modify] https://crrev.com/15fff438fcb1c05481d0f1b9bff6cccfa85af14a/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
[modify] https://crrev.com/15fff438fcb1c05481d0f1b9bff6cccfa85af14a/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/15fff438fcb1c05481d0f1b9bff6cccfa85af14a/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
[modify] https://crrev.com/15fff438fcb1c05481d0f1b9bff6cccfa85af14a/third_party/WebKit/LayoutTests/fast/dom/event-attribute-availability-expected.txt
[modify] https://crrev.com/15fff438fcb1c05481d0f1b9bff6cccfa85af14a/third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/15fff438fcb1c05481d0f1b9bff6cccfa85af14a/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/15fff438fcb1c05481d0f1b9bff6cccfa85af14a/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/15fff438fcb1c05481d0f1b9bff6cccfa85af14a/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/15fff438fcb1c05481d0f1b9bff6cccfa85af14a/third_party/blink/renderer/core/dom/document.h
[modify] https://crrev.com/15fff438fcb1c05481d0f1b9bff6cccfa85af14a/third_party/blink/renderer/core/dom/document.idl
[modify] https://crrev.com/15fff438fcb1c05481d0f1b9bff6cccfa85af14a/third_party/blink/renderer/core/dom/element.h
[modify] https://crrev.com/15fff438fcb1c05481d0f1b9bff6cccfa85af14a/third_party/blink/renderer/core/dom/element.idl
[modify] https://crrev.com/15fff438fcb1c05481d0f1b9bff6cccfa85af14a/third_party/blink/renderer/core/dom/global_event_handlers.h
[modify] https://crrev.com/15fff438fcb1c05481d0f1b9bff6cccfa85af14a/third_party/blink/renderer/core/dom/global_event_handlers.idl

Comment 11 by eui-sang.lim@samsung.com, Oct 1

Status: Fixed (was: Started)
►

Sign in to add a comment