Allow full debugging symbols in ASan builds |
||||||
Issue descriptionOccasionally, it may be useful to debug ASan builds of Chrome under GDB. By default, when is_asan is true, we force -gline-tables-only even when is_debug=true. We may want to add a new GN flag to control whether if we do -gline-tables-only.
,
Feb 15 2017
We use debug builds for fuzzing as well, so might need some way to turn off symbols for those too explicitly.
,
Mar 9 2017
Any progress here? My (rejected) attempt at fixing it can be found here: https://codereview.chromium.org/2553043002/
,
Mar 16 2017
Who should we talk to to make this happen? Thanks!
,
Mar 16 2017
Just create a patch and find reviewer from owners file.
,
Mar 16 2017
If you want to talk in general to any dev about developer debugging expertise, talk to thakis@
,
Apr 25 2017
ping?
,
Apr 25 2017
I think we should just add a new GN var to turn on full debug symbols when building with sanitizers. I'll do it.
,
Apr 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a7ed44b0ffb4f4e8f70dd5c0c82ad0046d84964 commit 2a7ed44b0ffb4f4e8f70dd5c0c82ad0046d84964 Author: ochang <ochang@chromium.org> Date: Wed Apr 26 00:23:12 2017 Add a GN flag to allow sanitizer builds with full debugging symbols. R=thakis@chromium.org BUG= 692620 Review-Url: https://codereview.chromium.org/2843773003 Cr-Commit-Position: refs/heads/master@{#467178} [modify] https://crrev.com/2a7ed44b0ffb4f4e8f70dd5c0c82ad0046d84964/build/config/sanitizers/BUILD.gn [modify] https://crrev.com/2a7ed44b0ffb4f4e8f70dd5c0c82ad0046d84964/build/config/sanitizers/sanitizers.gni
,
Apr 26 2017
setting `sanitizer_keep_symbols = true` along with either `is_debug = true` or `symbol_level = 2` should now result in full debugging symbols for ASan builds.
,
Apr 26 2017
Yay! Thanks!
,
Apr 28 2017
Verified that this does indeed work. Thanks again! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by och...@chromium.org
, Feb 15 2017