New issue
Advanced search Search tips

Issue 692610 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 672152



Sign in to add a comment

New Audit should print out test name on entry

Project Member Reported by rtoy@chromium.org, Feb 15 2017

Issue description

Take a look at the output from Audit in https://codereview.chromium.org/2697733004/#msg7

Notice that we have

PASS < [null-audiobuffer]

I would expect a corresponding

PASS > [null-audiobuffer]

so that the "<" has a corresponding ">".  This doesn't happen if task.describe() is called.  Then there's an initial "PASS >" line.
 
Status: Started (was: Assigned)
Blocking: 672152
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8c334dedbfa6e68e78e4aa1075a4c2ef17d5796

commit c8c334dedbfa6e68e78e4aa1075a4c2ef17d5796
Author: hongchan <hongchan@chromium.org>
Date: Wed Feb 22 16:07:36 2017

Print out label and description on task entry in Audit task runner

This CL changes how to specify the label/description of a test task.

audit.define('label', taskFunc);
audit.define({ label: 'label', description: 'description' }, taskFunc);

Even if the description is not given the entry of task will be
displayed. Note that task.describe() will be deprecated.

BUG= 692610 
TEST=
LayoutTests/webaudio/unit-tests/audit.html

Review-Url: https://codereview.chromium.org/2705483002
Cr-Commit-Position: refs/heads/master@{#452074}

[modify] https://crrev.com/c8c334dedbfa6e68e78e4aa1075a4c2ef17d5796/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquadfilternode-basic-expected.txt
[modify] https://crrev.com/c8c334dedbfa6e68e78e4aa1075a4c2ef17d5796/third_party/WebKit/LayoutTests/webaudio/resources/audit.js
[modify] https://crrev.com/c8c334dedbfa6e68e78e4aa1075a4c2ef17d5796/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-expected.txt
[modify] https://crrev.com/c8c334dedbfa6e68e78e4aa1075a4c2ef17d5796/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures.html
[modify] https://crrev.com/c8c334dedbfa6e68e78e4aa1075a4c2ef17d5796/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html

Status: Verified (was: Started)

Sign in to add a comment