New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 692606 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Power benchmarks should alert per-benchmark/metric/user story rather than per-benchmark/metric

Project Member Reported by charliea@chromium.org, Feb 15 2017

Issue description

Right now, power benchmarks alert on benchmark/metric combinations, e.g. "battor.tough_video_cases/story:power_avg regressed". As suggested by nednguyen@ (and the new best practices), we should really change this to alerting on benchmark/user story/metric combinations, e.g. "battor.tough_video_cases/cat_video_1.mp4/story:power_avg regressed".

Alerting on aggregates is just a bad idea. If we have a page set with one user story with an average power of 1W, and we add a new user story to that page set with an average power of 2W, this would currently cause an alert because we changed the story:power_avg of the page set as a whole. This is a bug.

 
Status: Fixed (was: Assigned)
Just went ahead and did this. I also added monitoring for system_health.common_desktop and system_health.common_mobile, both of which were unmonitored.
Components: Test>Telemetry
Components: -Speed>Telemetry

Sign in to add a comment