New issue
Advanced search Search tips

Issue 692594 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Aug 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 585218



Sign in to add a comment

mash: Use shared memory to send crash keys to crash_reporter

Project Member Reported by jamescook@chromium.org, Feb 15 2017

Issue description

Chrome has a concept of "crash keys" which are pieces of metadata sent to the crash server when the browser crashes. They are written as part of in-process crash dumping.

For mash we're using the system crash_reporter for crashes, so we're not in-process. We need a way to export a little bit of metadata. vapier suggested environment variables.

Notes to self:
* environment is in /proc/<pid>/environ
* Record variables with setenv(), which allocates and copies strings on each call.
* For efficiency we could preallocate string buffers, use putenv() to connect them to the env variables, then copy our data into the buffers.
 
Summary: mash: Use shared memory to send crash keys to crash_reporter (was: mash: Use environment variables to send crash keys to crash_reporter)
Change of plan, we're going to use a block of shared memory for this.

See go/mustash-crash-reporter

Labels: -mustash-1
Status: Assigned (was: Started)
On hold. Not needed for Q1. Might be slightly easier after crash team finishes crash key registration refactor from  issue 598854  (and need to be sure this approach works with their new plans).

Labels: -Pri-1 Pri-3
Components: Internals>Services>Ash
Owner: ----
Status: Untriaged (was: Assigned)
Still on hold. We're using content-layer process launching for the foreseeable future, which allows us to use Chrome's crash reporter and crash keys.

It's also possible Crashpad for Chrome OS will ship before mash, which might make this easier to handle.

Status: WontFix (was: Untriaged)
We've switched back to Breakpad for mash. It looks like Crashpad for Chrome OS will happen before mash ships.

Sign in to add a comment