Issue metadata
Sign in to add a comment
|
chrome.contextMenus icons do not use high dpi resources
Reported by
ja...@agilebits.com,
Feb 15 2017
|
||||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/602.4.8 (KHTML, like Gecko) Version/10.0.3 Safari/602.4.8 Steps to reproduce the problem: 1. Install the 1Password extension in Chrome on a Retina or other high-dpi screen 2. Right click in a web page What is the expected behavior? 1Password's contextual menu displays with a Retina icon What went wrong? 1Password's contextual menu displays with a non-Retina icon Did this work before? No Does this work in other browsers? N/A Chrome version: 56.0.2924.87 (Official Build) (64-bit) Channel: stable OS Version: OS X 10.12.3 Flash Version: We include in 1Password's manifest file 16px, 48px, and 128px icon resources and https://developer.chrome.com/extensions/contextMenus only mentions the 16px variant.
,
Feb 16 2017
,
Feb 17 2017
Unable to reproduce the issue in MacBook Pro (Retina, 15-inch, Mid 2014) 10.12.2 by using chrome reported version #56.0.2924.87 and latest canary #58.0.3015.0. Steps followed to reproduce the issue are as follows: ----------- 1. Installed the 1Password extension in Chrome on a Retina screen. 2. Right clicked in a web page. 3. Observed that 1Password's contextual menu displayed with a Retina icon. Attaching screen cast for reference. Reporter@ - Could you please verify the screencast and please let us know if anything missed from our side. Also could you please check this issue on latest canary #58.0.3015.0 by creating a new profile without any apps and extensions and please let us know if the issue still persist or not. Thanks...!!
,
Feb 22 2017
I was able to reproduce in 56.0.2924.87 (64-bit) but not in 58.0.3020.0 canary (64-bit). Here's an example page to help illustrate what I'm seeing: https://com-agilebits-users.s3.amazonaws.com/jxpx777/yMGrarBubZFuEEIvceemBbAUJaxncwqF/icon-test.html I'm attaching a screencast that illustrates the mismatch I'm seeing including zooming in on the Retina and non-Retina icons to compare them to the contextual menu in the Chrome extension. If it is fixed in Canary as it seems it is, then that's fine and we'll eagerly await it to make it to stable, but I thought I would illustrate the issue anyway to give a better sense what we are seeing in the current stable build.
,
Mar 1 2017
Thank you for providing feedback. removing "Needs-Feedback" label.
,
Mar 8 2017
Able to reproduce the issue on Mac 10.12.3(Retina), Win-10 and Ubuntu 14.04 using chrome reported version #56.0.2924.87 but the same is not reproducible in the latest canary #59.0.3032.0. Reverse Bisect Information: ===================== Good build: 57.0.2956.0 Revision(439388) Bad Build : 57.0.2954.0 Revision(439279) Change Log URL: https://chromium.googlesource.com/chromium/src/+log/111fdd030ce49ce1de525ac10a983bed8fd8720e..32426e0c6511485debbf3b7c77e87791b6b3ec93 From the above change log suspecting below change Review url: https://codereview.chromium.org/2576833002 estade@ - Could you please check and merge the fix to M-57 if it is a valid candidate. Thanks...!!
,
Mar 8 2017
Indeed, the linked CL fixed this bug. But it was not a regression and I don't think there's a need to merge it. 57 has the fix and should reach stable very soon. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by erikc...@chromium.org
, Feb 16 2017