This looks very similar to  issue 462308  . However, please also note earlier  issue 454408  and https://codereview.chromium.org/907393002 - arguably that change regresses exactly this functionality.

See https://codereview.chromium.org/659863004 for the CL where I first introduced the "always run tests that do not require targets to compile, even if the patch doesn't require compile." logic.

Below is relevant code from chromium_tests/api.py , which does what you're saying, just not for DEPS. I wonder why do we do any additional filtering (is_source_file). Looks like that was introduced in https://codereview.chromium.org/1346173004 .

      # Even though the patch doesn't require a compile on this platform,
      # we'd still like to run tests not depending on
      # compiled targets (that's obviously not covered by the
      # 'analyze' step) if any source files change.
      if any(self._is_source_file(f) for f in affected_files):
        tests = [t for t in tests if not t.compile_targets(self._api_for_tests)]
      else:
        tests = []

  def _is_source_file(self, filepath):
    """Returns true iff the file is a source file."""
    _, ext = self.m.path.splitext(filepath)
    return ext in ['.c', '.cc', '.cpp', '.h', '.java', '.mm']

I think jam@'s point is that ideally we'd make some variant of analyze work correctly, rather than running things all of the time or none of the time.

It would be possible to wire up a test that specified DEPS files as data/data_deps in GN and make analyze work correctly, but there's no good way to say in GN that you care about *every* DEPS file (the usual problems with wildcards arise).

It might be reasonable to implement a coarser sort of analyze for some class of test steps like these, though.

This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

+liaoyuke - is this something you're actively working on? Please dedup if that's the case. Thanks!

Yes, I am.