New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 692574 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocked on:
issue 602968



Sign in to add a comment

Webfonts go blank upon loading multiple background tabs

Reported by jsimo...@onshape.com, Feb 15 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

Steps to reproduce the problem:
1. go to http://cad.onshape.com and create an account
2. After signing in, stay on the documents page (your lists will appear empty, follow the Tip below)
3. Middle click on the Onshape logo several times (try 5) to open multiple background tabs.
4. Once all tabs have loaded, click on some of the ones in the middle
5. NOtice that some tabs may appear with missing text

Tip: It helps if you open a few public documents first so the default list, "Recently opened", has something in it.
To do this, go to the public tab and open a few documents by clicking on their name.

What is the expected behavior?
All text should render with the Flama webfont

What went wrong?
On some tabs, the webfont is displayed as invisible text. (Screenshot 1)

When inspected, the Computed font is Helvetica Neue, one of the fallback local fonts, but that seems to be missing or not rendered.  (Screenshot 2)

NOTE: 
All fonts load correctly once the browser is resized significantly or some style is changed in the inspector.

Did this work before? N/A 

Chrome version: 56.0.2924.87  Channel: stable
OS Version: OS X 10.12.3
Flash Version: Shockwave Flash 24.0 r0

This is a duplicate of 336170, There were instructions to open a new bug if the problem resurfaced.

 
Screen Shot 2017-02-15 at 10.33.02 AM copy.png
141 KB View Download
Screen Shot 2017-02-15 at 10.47.11 AM.png
308 KB View Download

Comment 1 by rsesek@chromium.org, Feb 15 2017

Components: -UI Blink>WebFonts
Cc: krajshree@chromium.org
Labels: Needs-Feedback
Unable to reproduce the issue in Mac 10.12.2 using chrome reported version #56.0.2924.87 and latest canary #58.0.3013.0.

Steps followed to reproduce the issue are as follows:
-----------
1. Navigated to http://cad.onshape.com and created an account
2. After signing in, stayed on the recently opened page with some items in it.(Followed the tip given in issue)
3. Middle clicked on the Onshape logo several times (tried 5) to open multiple background tabs.
4. Once all tabs got loaded, clicked on some of the ones in the middle.
5. Noticed that all text rendered with the Flama web font as expected.

Attaching screen cast for reference

Reporter@ - Could you please check the screencast and please let us know if anything missed from our side.

Thanks...!!
692574.mp4
4.1 MB View Download
Labels: Needs-Triage-M56
Blockedon: 602968
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99cc846f07ae952c27c026f7a4ddc0dbfba0a83a

commit 99cc846f07ae952c27c026f7a4ddc0dbfba0a83a
Author: ksakamoto <ksakamoto@chromium.org>
Date: Fri Mar 03 07:24:10 2017

RemoteFontFaceSource should keep FontCustomPlatformData over FontResource revalidation

RemoteFontFaceSource assumed that FontResource::isLoaded() never returns
false after notifyFinished(), but FontResource can go back to "loading"
state by resource revalidation. This caused a bug where webfonts are not
displayed when loaded in one frame and immediately revalidated in
another frame.

To fix this bug, this CL does the following:
- Make FontCustomPlatformData RefCounted.
- Make RemoteFontFaceSource to get RefPtr<FontCustomPlatformData> and
  use it in RemoteFontFaceSource::createFontData().
- RemoteFontFaceSource never accesses FontResource after notifyFinished().

BUG= 602968 ,  652974 ,  692574 

Review-Url: https://codereview.chromium.org/2717123003
Cr-Commit-Position: refs/heads/master@{#454537}

[add] https://crrev.com/99cc846f07ae952c27c026f7a4ddc0dbfba0a83a/third_party/WebKit/LayoutTests/http/tests/webfont/font-face-revalidation-expected.html
[add] https://crrev.com/99cc846f07ae952c27c026f7a4ddc0dbfba0a83a/third_party/WebKit/LayoutTests/http/tests/webfont/font-face-revalidation.html
[modify] https://crrev.com/99cc846f07ae952c27c026f7a4ddc0dbfba0a83a/third_party/WebKit/Source/core/css/BinaryDataFontFaceSource.h
[modify] https://crrev.com/99cc846f07ae952c27c026f7a4ddc0dbfba0a83a/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp
[modify] https://crrev.com/99cc846f07ae952c27c026f7a4ddc0dbfba0a83a/third_party/WebKit/Source/core/css/RemoteFontFaceSource.h
[modify] https://crrev.com/99cc846f07ae952c27c026f7a4ddc0dbfba0a83a/third_party/WebKit/Source/core/loader/resource/FontResource.cpp
[modify] https://crrev.com/99cc846f07ae952c27c026f7a4ddc0dbfba0a83a/third_party/WebKit/Source/core/loader/resource/FontResource.h
[modify] https://crrev.com/99cc846f07ae952c27c026f7a4ddc0dbfba0a83a/third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp
[modify] https://crrev.com/99cc846f07ae952c27c026f7a4ddc0dbfba0a83a/third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.h
[modify] https://crrev.com/99cc846f07ae952c27c026f7a4ddc0dbfba0a83a/third_party/WebKit/Source/platform/testing/FontTestHelpers.cpp

Owner: ksakamoto@chromium.org
Status: Fixed (was: Unconfirmed)
This should be fixed in latest canary (59.0.3032.0). If not, please let us know.

Sign in to add a comment