Issue metadata
Sign in to add a comment
|
win: unit_tests calling chrome::GetChannel() are failing in official builds |
||||||||||||||||||||
Issue descriptionStarted e.g. here: https://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%20tester/builds/5438 https://build.chromium.org/p/chromium.fyi/builders/CrWinClang%20tester/builds/12195 These two bots happen to use clang in addition to doing official builds, but I bet it happens with MSVC too in official builds. https://codereview.chromium.org/2694743002 looks like a very related CL. On representation stack: [ RUN ] SearchProviderTest.LocalAndRemoteRelevances Backtrace: chrome::GetChannel [0x02C2F1BD+22] extensions::ChromeExtensionsBrowserClient::ChromeExtensionsBrowserClient [0x0370D24D+125] TestingBrowserProcess::TestingBrowserProcess [0x0258EFE2+164] TestingBrowserProcess::CreateInstance [0x0258EF35+23] ChromeUnitTestSuite::`scalar deleting destructor' [0x02590AE9+279] testing::internal::TestEventRepeater::OnTestStart [0x02744318+36] testing::TestInfo::Run [0x02742A8C+78] testing::TestCase::Run [0x02742EA8+246] testing::internal::UnitTestImpl::RunAllTests [0x02746ACA+608] testing::UnitTest::Run [0x02746792+178] base::TestSuite::Run [0x025965FD+113] base::LaunchUnitTests [0x02596FF1+397] base::LaunchUnitTests [0x02596ED4+112] main [0x04B51E1C+200] __scrt_common_main_seh [0x0565CBA9+249] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:253) BaseThreadInitThunk [0x7545338A+18] RtlInitializeExceptionChain [0x77549F72+99] RtlInitializeExceptionChain [0x77549F45+54]
,
Feb 16 2017
,
Feb 16 2017
Fix is out for review here: https://codereview.chromium.org/2696403003/
,
Feb 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a4e3a4e6fa17894c3a4cdc0f03ed3380fe468f9 commit 7a4e3a4e6fa17894c3a4cdc0f03ed3380fe468f9 Author: grt <grt@chromium.org> Date: Fri Feb 17 16:08:15 2017 Fix unit_tests assert failure. Install a default InstallDetails instance for the test binary. BUG=373987, 692568 R=phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2696403003 Cr-Commit-Position: refs/heads/master@{#451315} [modify] https://crrev.com/7a4e3a4e6fa17894c3a4cdc0f03ed3380fe468f9/chrome/test/base/run_all_unittests.cc
,
Feb 17 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by r...@chromium.org
, Feb 15 2017