ModuleEventSinkImplTest.CallsForwardedAsExpected failing on CrWinClang64(dbg) tester, ClangToTWin64(dbg) tester |
||||
Issue descriptionHas been failing for a while. Only seems to fail on 64-bit debug. Fails on pinned bots too, not roll blocker. First: https://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dbg%29%20tester/builds/4532 https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin64%28dbg%29%20tester/builds/3302 Suspect: https://codereview.chromium.org/2685213002
,
Feb 15 2017
Left a guess here: https://codereview.chromium.org/2685213002/#msg10 That guess would explain why this is only in 64-bit too.
,
Feb 15 2017
https://codereview.chromium.org/2691373003/
,
Feb 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c8e9d56d99a51c887ec4d15cbde5309533a96fb commit 2c8e9d56d99a51c887ec4d15cbde5309533a96fb Author: thakis <thakis@chromium.org> Date: Wed Feb 15 18:59:16 2017 Fix out of bounds write in ReadRemoteData https://codereview.chromium.org/2685213002 made us pass data instead of &data to ReadProcessMemory() but it didn't update the sizeof() arg. ReadRemoteData() is called with LONG and DWORDs which have size 4, but sizeof(data) on 64-bit is the size of a pointer, i.e. 8 -- so ReadProcessMemory() now reads 8 bytes into a 4-byte buffer. Fix this. BUG= 692561 Review-Url: https://codereview.chromium.org/2691373003 Cr-Commit-Position: refs/heads/master@{#450751} [modify] https://crrev.com/2c8e9d56d99a51c887ec4d15cbde5309533a96fb/chrome/browser/conflicts/module_event_sink_impl_win.cc
,
Feb 15 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by thakis@chromium.org
, Feb 15 2017