New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 692559 link

Starred by 1 user
Status: Fixed
Owner:
█ mikhail....@intel.com
Email to this user bounced
Closed: Feb 2017
Cc:
█ kenneth....@intel.com
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Sensor] Weird error messages

Project Member Reported by mikhail....@intel.com, Feb 15 2017 
The following error message is observed on a non-sensored desktop
"SensorErrorEvent {error: DOMException: An unknown error occurred within Indexed Database., type: "error", target: Gyroscope, currentTarget: Gyroscope, eventPhase: 2…}"

Apparently wrong exception is used.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/064a292ce35b28592529c5bded26f905d65833a9

commit 064a292ce35b28592529c5bded26f905d65833a9
Author: mikhail.pozdnyakov <mikhail.pozdnyakov@intel.com>
Date: Wed Feb 15 17:35:41 2017

[Sensors] Fix error type and message used

Before this change Sensor implementation used 'UnknownError' exception type (and the default message) to report errors from mojo proxies.
This led to the weird error messages like: "SensorErrorEvent {error: DOMException: An unknown error occurred within Indexed Database.,".

This patch uses 'NotReadableError' as described in the specification [1] and also simplifies the error handling code.

BUG= 692559 

[1] https://w3c.github.io/sensors

Review-Url: https://codereview.chromium.org/2699673002
Cr-Commit-Position: refs/heads/master@{#450741}

[modify] https://crrev.com/064a292ce35b28592529c5bded26f905d65833a9/third_party/WebKit/Source/modules/sensor/SensorProxy.cpp
[modify] https://crrev.com/064a292ce35b28592529c5bded26f905d65833a9/third_party/WebKit/Source/modules/sensor/SensorProxy.h

Comment 2 by mikhail....@intel.com, Feb 15 2017

Status: Fixed (was: Assigned)

Comment 3 by canx....@intel.com, Feb 20 2017 

QA verified this issue on Mac/Windows 58.0.3017.0 .
The error message is updated.
►

Sign in to add a comment