New issue
Advanced search Search tips

Issue 692548 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

[NoStatePrefetch] Enable forced prerenders from exteral applications on Wifi

Project Member Reported by droger@chromium.org, Feb 15 2017

Issue description

Forced prerenders currently only work on cellular networks.
On Wifi, they are not guaranteed to happen (a NoStatePrefetch may happen instead).

This is blocking the rollout of NoStatePrefetch.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/015400e5f61ea871e81cae45fc648df19a50eee1

commit 015400e5f61ea871e81cae45fc648df19a50eee1
Author: droger <droger@chromium.org>
Date: Wed Feb 15 17:34:19 2017

Enable forced prerenders on wifi

Forced prerenders were only enabled on cellular connections, which was
causing NoStatePrefetch to be triggered on wifi instead.
Forced prerenders are actually intended to work on all connection types.

This CL changes this behavior and also renames the functions to remove
the references to cellular networks.

external_prerender_handler_android.cc has the only behavior change.
Changes in other files are only renaming and formatting.

BUG= 692548 

Review-Url: https://codereview.chromium.org/2690393004
Cr-Commit-Position: refs/heads/master@{#450740}

[modify] https://crrev.com/015400e5f61ea871e81cae45fc648df19a50eee1/chrome/browser/prerender/external_prerender_handler_android.cc
[modify] https://crrev.com/015400e5f61ea871e81cae45fc648df19a50eee1/chrome/browser/prerender/external_prerender_handler_android.h
[modify] https://crrev.com/015400e5f61ea871e81cae45fc648df19a50eee1/chrome/browser/prerender/prerender_histograms.cc
[modify] https://crrev.com/015400e5f61ea871e81cae45fc648df19a50eee1/chrome/browser/prerender/prerender_manager.cc
[modify] https://crrev.com/015400e5f61ea871e81cae45fc648df19a50eee1/chrome/browser/prerender/prerender_manager.h
[modify] https://crrev.com/015400e5f61ea871e81cae45fc648df19a50eee1/chrome/browser/prerender/prerender_origin.h
[modify] https://crrev.com/015400e5f61ea871e81cae45fc648df19a50eee1/chrome/browser/prerender/prerender_unittest.cc

Comment 2 by droger@chromium.org, Feb 16 2017

Labels: Merge-Request-57
Status: Fixed (was: Started)
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 16 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 16 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a63d34db964df3cb96d82a889c47c608a6c734a

commit 4a63d34db964df3cb96d82a889c47c608a6c734a
Author: David Roger <droger@google.com>
Date: Thu Feb 16 12:59:22 2017

Enable forced prerenders on wifi

Forced prerenders were only enabled on cellular connections, which was
causing NoStatePrefetch to be triggered on wifi instead.
Forced prerenders are actually intended to work on all connection types.

This CL changes this behavior and also renames the functions to remove
the references to cellular networks.

external_prerender_handler_android.cc has the only behavior change.
Changes in other files are only renaming and formatting.

BUG= 692548 

Review-Url: https://codereview.chromium.org/2690393004
Cr-Commit-Position: refs/heads/master@{#450740}
(cherry picked from commit 015400e5f61ea871e81cae45fc648df19a50eee1)

Review-Url: https://codereview.chromium.org/2697513009 .
Cr-Commit-Position: refs/branch-heads/2987@{#548}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/4a63d34db964df3cb96d82a889c47c608a6c734a/chrome/browser/prerender/external_prerender_handler_android.cc
[modify] https://crrev.com/4a63d34db964df3cb96d82a889c47c608a6c734a/chrome/browser/prerender/external_prerender_handler_android.h
[modify] https://crrev.com/4a63d34db964df3cb96d82a889c47c608a6c734a/chrome/browser/prerender/prerender_histograms.cc
[modify] https://crrev.com/4a63d34db964df3cb96d82a889c47c608a6c734a/chrome/browser/prerender/prerender_manager.cc
[modify] https://crrev.com/4a63d34db964df3cb96d82a889c47c608a6c734a/chrome/browser/prerender/prerender_manager.h
[modify] https://crrev.com/4a63d34db964df3cb96d82a889c47c608a6c734a/chrome/browser/prerender/prerender_origin.h
[modify] https://crrev.com/4a63d34db964df3cb96d82a889c47c608a6c734a/chrome/browser/prerender/prerender_unittest.cc

Sign in to add a comment