New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 692534 link

Starred by 3 users
Status: Fixed
Owner:
peter@chromium.org
Closed: Mar 2017
Cc:
█ miguelg@chromium.org
mlamouri@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Define and implement the IDLs and Mojo interface for the BackgroundFetch API

Project Member Reported by harkness@chromium.org, Feb 15 2017 
The BackgroundFetch API will use a Mojo service to communicate from the renderer to the browser. This task involves the following:

* Define the IDLs required for the new API
* Define the Mojo calls which will be needed to implement the functionality defined in https://github.com/jakearchibald/background-fetch
* Implement a .mojom file which provides those calls.
* Write a platform test to validate the Mojo interface.

Comment 1 by miguelg@chromium.org, Feb 20 2017

Labels: -Pri-3 Pri-2
Owner: awdf@chromium.org

Comment 2 by awdf@chromium.org, Feb 20 2017

Description: Show this description

Comment 3 by awdf@chromium.org, Feb 20 2017

Summary: Define and implement the IDLs and Mojo interface for the BackgroundFetch API (was: Define and implement the Mojo service interface for the BackgroundFetch API)

Comment 4 by awdf@chromium.org, Feb 21 2017

Status: Started (was: Available)

Comment 5 by mlamouri@chromium.org, Feb 22 2017

Cc: mlamouri@chromium.org

Comment 6 by awdf@chromium.org, Mar 7 2017

Owner: peter@chromium.org
Status: Assigned (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/911ea3c964671fb131a49c7be4225a30ea9468e2

commit 911ea3c964671fb131a49c7be4225a30ea9468e2
Author: peter <peter@chromium.org>
Date: Fri Mar 10 17:59:41 2017

Introduce the Background Fetch module.

This CL introduces the BackgroundFetchManager object and exposes it on
the ServiceWorkerRegistration, as part of a new Background Fetch module.

More functionality and tests will be added iteratively.

Intent to Implement:
  https://groups.google.com/a/chromium.org/d/topic/blink-dev/Ia9_-CVrl1U/discussion

WPT directory addition + IDL harness tests:
  https://github.com/w3c/web-platform-tests/pull/5094

Based on the following CL by awdf@:
  https://codereview.chromium.org/2739653002/

BUG= 692534 

Review-Url: https://codereview.chromium.org/2736143003
Cr-Commit-Position: refs/heads/master@{#456102}

[add] https://crrev.com/911ea3c964671fb131a49c7be4225a30ea9468e2/third_party/WebKit/LayoutTests/http/tests/background_fetch/getTags.html
[add] https://crrev.com/911ea3c964671fb131a49c7be4225a30ea9468e2/third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/empty-worker.js
[modify] https://crrev.com/911ea3c964671fb131a49c7be4225a30ea9468e2/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/navigation-preload-origin-trial-interfaces-expected.txt
[modify] https://crrev.com/911ea3c964671fb131a49c7be4225a30ea9468e2/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/911ea3c964671fb131a49c7be4225a30ea9468e2/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/chromium/navigation-preload-origin-trial-interfaces-expected.txt
[modify] https://crrev.com/911ea3c964671fb131a49c7be4225a30ea9468e2/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/chromium/navigation-preload-origin-trial-interfaces-expected.txt
[modify] https://crrev.com/911ea3c964671fb131a49c7be4225a30ea9468e2/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/911ea3c964671fb131a49c7be4225a30ea9468e2/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/911ea3c964671fb131a49c7be4225a30ea9468e2/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/911ea3c964671fb131a49c7be4225a30ea9468e2/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/911ea3c964671fb131a49c7be4225a30ea9468e2/third_party/WebKit/Source/modules/BUILD.gn
[add] https://crrev.com/911ea3c964671fb131a49c7be4225a30ea9468e2/third_party/WebKit/Source/modules/background_fetch/BUILD.gn
[add] https://crrev.com/911ea3c964671fb131a49c7be4225a30ea9468e2/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.cpp
[add] https://crrev.com/911ea3c964671fb131a49c7be4225a30ea9468e2/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.h
[add] https://crrev.com/911ea3c964671fb131a49c7be4225a30ea9468e2/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.idl
[add] https://crrev.com/911ea3c964671fb131a49c7be4225a30ea9468e2/third_party/WebKit/Source/modules/background_fetch/OWNERS
[add] https://crrev.com/911ea3c964671fb131a49c7be4225a30ea9468e2/third_party/WebKit/Source/modules/background_fetch/ServiceWorkerRegistrationBackgroundFetch.cpp
[add] https://crrev.com/911ea3c964671fb131a49c7be4225a30ea9468e2/third_party/WebKit/Source/modules/background_fetch/ServiceWorkerRegistrationBackgroundFetch.h
[add] https://crrev.com/911ea3c964671fb131a49c7be4225a30ea9468e2/third_party/WebKit/Source/modules/background_fetch/ServiceWorkerRegistrationBackgroundFetch.idl
[modify] https://crrev.com/911ea3c964671fb131a49c7be4225a30ea9468e2/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/911ea3c964671fb131a49c7be4225a30ea9468e2/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e65af76a14bb2230117cf4bc7dfc76d5a4ed24b

commit 6e65af76a14bb2230117cf4bc7dfc76d5a4ed24b
Author: peter <peter@chromium.org>
Date: Fri Mar 10 20:08:13 2017

Implement BackgroundFetchManager::{get, fetch}()

This CL implements the get() and fetch() methods for Background Fetch.
The BackgroundFetchRegistration interface and BackgroundFetchOptions
and IconDefinition dictionary types are added too.

The method has not been hooked up with the browser process yet, as the
Mojo interface has not been implemented yet.

Tests are provided, and will be moved to the WPT directory once it has
been approved upstream:
  https://github.com/w3c/web-platform-tests/pull/5094

BUG= 692534 

Review-Url: https://codereview.chromium.org/2745543002
Cr-Commit-Position: refs/heads/master@{#456144}

[add] https://crrev.com/6e65af76a14bb2230117cf4bc7dfc76d5a4ed24b/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-manager-fetch.https.html
[add] https://crrev.com/6e65af76a14bb2230117cf4bc7dfc76d5a4ed24b/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-manager-get.https.html
[add] https://crrev.com/6e65af76a14bb2230117cf4bc7dfc76d5a4ed24b/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-manager-getTags.https.html
[delete] https://crrev.com/04ab58bf5dc99328860c1f3f3b46862bb628b0df/third_party/WebKit/LayoutTests/http/tests/background_fetch/getTags.html
[modify] https://crrev.com/6e65af76a14bb2230117cf4bc7dfc76d5a4ed24b/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/6e65af76a14bb2230117cf4bc7dfc76d5a4ed24b/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/6e65af76a14bb2230117cf4bc7dfc76d5a4ed24b/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/6e65af76a14bb2230117cf4bc7dfc76d5a4ed24b/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/6e65af76a14bb2230117cf4bc7dfc76d5a4ed24b/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/6e65af76a14bb2230117cf4bc7dfc76d5a4ed24b/third_party/WebKit/Source/modules/background_fetch/BUILD.gn
[modify] https://crrev.com/6e65af76a14bb2230117cf4bc7dfc76d5a4ed24b/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.cpp
[modify] https://crrev.com/6e65af76a14bb2230117cf4bc7dfc76d5a4ed24b/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.h
[modify] https://crrev.com/6e65af76a14bb2230117cf4bc7dfc76d5a4ed24b/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.idl
[add] https://crrev.com/6e65af76a14bb2230117cf4bc7dfc76d5a4ed24b/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchOptions.idl
[add] https://crrev.com/6e65af76a14bb2230117cf4bc7dfc76d5a4ed24b/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRegistration.cpp
[add] https://crrev.com/6e65af76a14bb2230117cf4bc7dfc76d5a4ed24b/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRegistration.h
[add] https://crrev.com/6e65af76a14bb2230117cf4bc7dfc76d5a4ed24b/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRegistration.idl
[add] https://crrev.com/6e65af76a14bb2230117cf4bc7dfc76d5a4ed24b/third_party/WebKit/Source/modules/background_fetch/IconDefinition.idl
[modify] https://crrev.com/6e65af76a14bb2230117cf4bc7dfc76d5a4ed24b/third_party/WebKit/Source/modules/modules_idl_files.gni
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c13484884ae6388d116d6d9d84c9fc42479630d

commit 4c13484884ae6388d116d6d9d84c9fc42479630d
Author: peter <peter@chromium.org>
Date: Sun Mar 12 02:34:07 2017

Implement the events for Background Fetch

This CL implements the events for Background Fetch. There are four:

  - BackgroundFetchEvent (onbackgroundfetchabort; base event)
  - BackgroundFetchClickEvent (onbackgroundfetchclick)
  - BackgroundFetchedEvent (onbackgroundfetched)
  - BackgroundFetchFailEvent (onbackgroundfetchfail)

Not all attributes are supported yet. Notably, the sequences of requests
and responses associated with a fetch will be exposed in a subsequent CL.

Tests are included, and are in addition to the IDL harness test in WPT.
I'm adding tests for the `fail` and `fetched` events in the next CL,
where they get Request and Response knowledge.

BUG= 692534 

Review-Url: https://codereview.chromium.org/2745573002
Cr-Commit-Position: refs/heads/master@{#456296}

[add] https://crrev.com/4c13484884ae6388d116d6d9d84c9fc42479630d/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-click-event.https.html
[add] https://crrev.com/4c13484884ae6388d116d6d9d84c9fc42479630d/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-event.https.html
[add] https://crrev.com/4c13484884ae6388d116d6d9d84c9fc42479630d/third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetch-click-event-worker.js
[add] https://crrev.com/4c13484884ae6388d116d6d9d84c9fc42479630d/third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetch-event-worker.js
[modify] https://crrev.com/4c13484884ae6388d116d6d9d84c9fc42479630d/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/4c13484884ae6388d116d6d9d84c9fc42479630d/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/4c13484884ae6388d116d6d9d84c9fc42479630d/third_party/WebKit/Source/bindings/modules/BUILD.gn
[modify] https://crrev.com/4c13484884ae6388d116d6d9d84c9fc42479630d/third_party/WebKit/Source/core/events/EventTypeNames.json5
[modify] https://crrev.com/4c13484884ae6388d116d6d9d84c9fc42479630d/third_party/WebKit/Source/modules/background_fetch/BUILD.gn
[add] https://crrev.com/4c13484884ae6388d116d6d9d84c9fc42479630d/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchClickEvent.cpp
[add] https://crrev.com/4c13484884ae6388d116d6d9d84c9fc42479630d/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchClickEvent.h
[add] https://crrev.com/4c13484884ae6388d116d6d9d84c9fc42479630d/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchClickEvent.idl
[add] https://crrev.com/4c13484884ae6388d116d6d9d84c9fc42479630d/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchClickEventInit.idl
[add] https://crrev.com/4c13484884ae6388d116d6d9d84c9fc42479630d/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchEvent.cpp
[add] https://crrev.com/4c13484884ae6388d116d6d9d84c9fc42479630d/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchEvent.h
[add] https://crrev.com/4c13484884ae6388d116d6d9d84c9fc42479630d/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchEvent.idl
[add] https://crrev.com/4c13484884ae6388d116d6d9d84c9fc42479630d/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchEventInit.idl
[add] https://crrev.com/4c13484884ae6388d116d6d9d84c9fc42479630d/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFailEvent.cpp
[add] https://crrev.com/4c13484884ae6388d116d6d9d84c9fc42479630d/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFailEvent.h
[add] https://crrev.com/4c13484884ae6388d116d6d9d84c9fc42479630d/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFailEvent.idl
[add] https://crrev.com/4c13484884ae6388d116d6d9d84c9fc42479630d/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFailEventInit.idl
[add] https://crrev.com/4c13484884ae6388d116d6d9d84c9fc42479630d/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEvent.cpp
[add] https://crrev.com/4c13484884ae6388d116d6d9d84c9fc42479630d/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEvent.h
[add] https://crrev.com/4c13484884ae6388d116d6d9d84c9fc42479630d/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEvent.idl
[add] https://crrev.com/4c13484884ae6388d116d6d9d84c9fc42479630d/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEventInit.idl
[add] https://crrev.com/4c13484884ae6388d116d6d9d84c9fc42479630d/third_party/WebKit/Source/modules/background_fetch/ServiceWorkerGlobalScopeBackgroundFetch.h
[add] https://crrev.com/4c13484884ae6388d116d6d9d84c9fc42479630d/third_party/WebKit/Source/modules/background_fetch/ServiceWorkerGlobalScopeBackgroundFetch.idl
[modify] https://crrev.com/4c13484884ae6388d116d6d9d84c9fc42479630d/third_party/WebKit/Source/modules/modules_idl_files.gni
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd

commit f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd
Author: peter <peter@chromium.org>
Date: Mon Mar 13 15:22:18 2017

Implement the Request/Response bits of Background Fetch

This CL implements the parts of the Background Fetch API that deal with
requests and responses, notably in the events. Following this, the Web
Exposed API that we're aiming for in MVP is implemented.

Tests for the `backgroundfetched` and `backgroundfetchfail` events have
been added, pending upstreaming to WPT like the others.

BUG= 692534 

Review-Url: https://codereview.chromium.org/2744873002
Cr-Commit-Position: refs/heads/master@{#456383}

[add] https://crrev.com/f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-fail-event.https.html
[add] https://crrev.com/f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetched-event.https.html
[add] https://crrev.com/f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd/third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetch-fail-event-worker.js
[add] https://crrev.com/f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd/third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetched-event-worker.js
[modify] https://crrev.com/f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd/third_party/WebKit/Source/modules/background_fetch/BUILD.gn
[modify] https://crrev.com/f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFailEvent.cpp
[modify] https://crrev.com/f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFailEvent.h
[modify] https://crrev.com/f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFailEvent.idl
[modify] https://crrev.com/f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFailEventInit.idl
[modify] https://crrev.com/f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRegistration.idl
[add] https://crrev.com/f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRequest.cpp
[add] https://crrev.com/f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRequest.h
[add] https://crrev.com/f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRequest.idl
[add] https://crrev.com/f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchSettledRequest.cpp
[add] https://crrev.com/f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchSettledRequest.h
[add] https://crrev.com/f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchSettledRequest.idl
[modify] https://crrev.com/f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEvent.cpp
[modify] https://crrev.com/f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEvent.h
[modify] https://crrev.com/f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEvent.idl
[modify] https://crrev.com/f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEventInit.idl
[modify] https://crrev.com/f0a182b5ebc9c86a6dd3df10cb0ebdbfb73c43dd/third_party/WebKit/Source/modules/modules_idl_files.gni

Comment 11 by miguelg@chromium.org, Mar 15 2017

Cc: miguelg@chromium.org
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3226ce85f3ba466797db44fe134abb8b898d2452

commit 3226ce85f3ba466797db44fe134abb8b898d2452
Author: peter <peter@chromium.org>
Date: Thu Mar 16 18:06:28 2017

Implement a Mojo service for Background Fetch

This CL lands the Mojo service that we intend to use for Background
Fetch. Everything but the fetch() event has been hooked up from the
renderer side, and will be received by a strongly binded service
implementation in the browser process.

The fetch() function will be implemented separately, as it will require
some plumbing to support the appropriate types for requests.

BUG= 692534 ,  692535 

Review-Url: https://codereview.chromium.org/2745243002
Cr-Commit-Position: refs/heads/master@{#457490}

[modify] https://crrev.com/3226ce85f3ba466797db44fe134abb8b898d2452/content/browser/BUILD.gn
[add] https://crrev.com/3226ce85f3ba466797db44fe134abb8b898d2452/content/browser/background_fetch/DEPS
[add] https://crrev.com/3226ce85f3ba466797db44fe134abb8b898d2452/content/browser/background_fetch/background_fetch_service_impl.cc
[add] https://crrev.com/3226ce85f3ba466797db44fe134abb8b898d2452/content/browser/background_fetch/background_fetch_service_impl.h
[modify] https://crrev.com/3226ce85f3ba466797db44fe134abb8b898d2452/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/3226ce85f3ba466797db44fe134abb8b898d2452/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/3226ce85f3ba466797db44fe134abb8b898d2452/content/browser/storage_partition_impl.h
[modify] https://crrev.com/3226ce85f3ba466797db44fe134abb8b898d2452/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/3226ce85f3ba466797db44fe134abb8b898d2452/third_party/WebKit/Source/modules/background_fetch/BUILD.gn
[add] https://crrev.com/3226ce85f3ba466797db44fe134abb8b898d2452/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchBridge.cpp
[add] https://crrev.com/3226ce85f3ba466797db44fe134abb8b898d2452/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchBridge.h
[modify] https://crrev.com/3226ce85f3ba466797db44fe134abb8b898d2452/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.cpp
[modify] https://crrev.com/3226ce85f3ba466797db44fe134abb8b898d2452/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.h
[modify] https://crrev.com/3226ce85f3ba466797db44fe134abb8b898d2452/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRegistration.cpp
[modify] https://crrev.com/3226ce85f3ba466797db44fe134abb8b898d2452/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEvent.cpp
[modify] https://crrev.com/3226ce85f3ba466797db44fe134abb8b898d2452/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEvent.h
[modify] https://crrev.com/3226ce85f3ba466797db44fe134abb8b898d2452/third_party/WebKit/public/BUILD.gn
[add] https://crrev.com/3226ce85f3ba466797db44fe134abb8b898d2452/third_party/WebKit/public/platform/modules/background_fetch/OWNERS
[add] https://crrev.com/3226ce85f3ba466797db44fe134abb8b898d2452/third_party/WebKit/public/platform/modules/background_fetch/background_fetch.mojom
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bdf346c6a54fc63be0a3f248631747c0a3745b7

commit 0bdf346c6a54fc63be0a3f248631747c0a3745b7
Author: peter <peter@chromium.org>
Date: Thu Mar 16 22:04:44 2017

Update Background Fetch IDLs following spec changes

Jake pushed two changes to the spec yesterday. This CL aligns our
implementation with them:

    https://github.com/WICG/background-fetch/commit/5d399383
    "Renaming in progress fetches to activeFetches, renaming settled
    fetches to fetches."

    https://github.com/WICG/background-fetch/commit/ffabe2fe
    "Fixing incorrect use of plurals."

BUG= 692534 

Review-Url: https://codereview.chromium.org/2751523008
Cr-Commit-Position: refs/heads/master@{#457576}

[modify] https://crrev.com/0bdf346c6a54fc63be0a3f248631747c0a3745b7/third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetch-fail-event-worker.js
[modify] https://crrev.com/0bdf346c6a54fc63be0a3f248631747c0a3745b7/third_party/WebKit/LayoutTests/http/tests/background_fetch/resources/background-fetched-event-worker.js
[modify] https://crrev.com/0bdf346c6a54fc63be0a3f248631747c0a3745b7/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/0bdf346c6a54fc63be0a3f248631747c0a3745b7/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/0bdf346c6a54fc63be0a3f248631747c0a3745b7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/0bdf346c6a54fc63be0a3f248631747c0a3745b7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/0bdf346c6a54fc63be0a3f248631747c0a3745b7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/0bdf346c6a54fc63be0a3f248631747c0a3745b7/third_party/WebKit/Source/modules/background_fetch/BUILD.gn
[modify] https://crrev.com/0bdf346c6a54fc63be0a3f248631747c0a3745b7/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFailEvent.cpp
[modify] https://crrev.com/0bdf346c6a54fc63be0a3f248631747c0a3745b7/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFailEvent.h
[modify] https://crrev.com/0bdf346c6a54fc63be0a3f248631747c0a3745b7/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFailEvent.idl
[modify] https://crrev.com/0bdf346c6a54fc63be0a3f248631747c0a3745b7/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFailEventInit.idl
[rename] https://crrev.com/0bdf346c6a54fc63be0a3f248631747c0a3745b7/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFetch.cpp
[rename] https://crrev.com/0bdf346c6a54fc63be0a3f248631747c0a3745b7/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFetch.h
[rename] https://crrev.com/0bdf346c6a54fc63be0a3f248631747c0a3745b7/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFetch.idl
[modify] https://crrev.com/0bdf346c6a54fc63be0a3f248631747c0a3745b7/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRegistration.idl
[add] https://crrev.com/0bdf346c6a54fc63be0a3f248631747c0a3745b7/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchSettledFetch.cpp
[add] https://crrev.com/0bdf346c6a54fc63be0a3f248631747c0a3745b7/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchSettledFetch.h
[rename] https://crrev.com/0bdf346c6a54fc63be0a3f248631747c0a3745b7/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchSettledFetch.idl
[delete] https://crrev.com/0c1ba3608548dd4d0ba411b3767fc3960c598810/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchSettledRequest.cpp
[delete] https://crrev.com/0c1ba3608548dd4d0ba411b3767fc3960c598810/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchSettledRequest.h
[modify] https://crrev.com/0bdf346c6a54fc63be0a3f248631747c0a3745b7/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEvent.cpp
[modify] https://crrev.com/0bdf346c6a54fc63be0a3f248631747c0a3745b7/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEvent.h
[modify] https://crrev.com/0bdf346c6a54fc63be0a3f248631747c0a3745b7/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEvent.idl
[modify] https://crrev.com/0bdf346c6a54fc63be0a3f248631747c0a3745b7/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEventInit.idl
[modify] https://crrev.com/0bdf346c6a54fc63be0a3f248631747c0a3745b7/third_party/WebKit/Source/modules/modules_idl_files.gni
Project Member

Comment 14 by bugdroid1@chromium.org, Mar 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef079770a54afefdb2248ad47143a216f8f6ed85

commit ef079770a54afefdb2248ad47143a216f8f6ed85
Author: peter <peter@chromium.org>
Date: Sun Mar 19 04:06:40 2017

Service Worker event dispatcher for Background Fetch

This CL implements the BackgroundFetchEventDispatcher and teaches it to
dispatch abort and click events. It then plumbs all the way down to
Blink to do so, after which it feeds back the result to the caller.

The `backgroundfetched` and `backgroundfetchfail` events rely on the
Request and Response objects to be available through Mojo; they will
follow in a subsequent CL.

TBR=avi (new file listed in BUILD.gn)
BUG= 692534 ,  692581 

Review-Url: https://codereview.chromium.org/2748213003
Cr-Commit-Position: refs/heads/master@{#457989}

[modify] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/content/browser/BUILD.gn
[add] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/content/browser/background_fetch/background_fetch_event_dispatcher.cc
[add] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/content/browser/background_fetch/background_fetch_event_dispatcher.h
[add] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/content/browser/background_fetch/background_fetch_event_dispatcher_unittest.cc
[modify] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/content/browser/service_worker/service_worker_metrics.cc
[modify] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/content/browser/service_worker/service_worker_metrics.h
[modify] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/content/common/service_worker/service_worker_event_dispatcher.mojom
[modify] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/content/renderer/service_worker/service_worker_type_converters.cc
[modify] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/content/renderer/service_worker/service_worker_type_converters.h
[modify] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/content/test/BUILD.gn
[modify] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchClickEvent.cpp
[modify] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchClickEvent.h
[modify] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchEvent.cpp
[modify] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchEvent.h
[modify] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFailEvent.cpp
[modify] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEvent.cpp
[modify] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h
[modify] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp
[modify] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h
[modify] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp
[modify] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h
[modify] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
[modify] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h
[modify] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
[modify] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h
[modify] https://crrev.com/ef079770a54afefdb2248ad47143a216f8f6ed85/tools/metrics/histograms/histograms.xml
Project Member

Comment 15 by bugdroid1@chromium.org, Mar 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da265efafd1b4eca88d17ebd5ec032053fd733bb

commit da265efafd1b4eca88d17ebd5ec032053fd733bb
Author: peter <peter@chromium.org>
Date: Mon Mar 20 18:17:42 2017

BackgroundFetchRegistration.abort() should return a Promise.

This aligns our implementation with the following change that was pushed
to the specification last week:

  https://github.com/WICG/background-fetch/commit/cad906d
  "abort() now returns a promise for a boolean"

In addition, it also sets default values on the BackgroundFetchOptions
dictionary which is required to support the fact that it's optional in
the call to BackgroundFetchManager.fetch().

BUG= 692534 

Review-Url: https://codereview.chromium.org/2762663002
Cr-Commit-Position: refs/heads/master@{#458125}

[modify] https://crrev.com/da265efafd1b4eca88d17ebd5ec032053fd733bb/content/browser/background_fetch/background_fetch_service_impl.cc
[modify] https://crrev.com/da265efafd1b4eca88d17ebd5ec032053fd733bb/content/browser/background_fetch/background_fetch_service_impl.h
[add] https://crrev.com/da265efafd1b4eca88d17ebd5ec032053fd733bb/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-registration-abort.https.html
[modify] https://crrev.com/da265efafd1b4eca88d17ebd5ec032053fd733bb/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchBridge.cpp
[modify] https://crrev.com/da265efafd1b4eca88d17ebd5ec032053fd733bb/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchBridge.h
[modify] https://crrev.com/da265efafd1b4eca88d17ebd5ec032053fd733bb/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.cpp
[modify] https://crrev.com/da265efafd1b4eca88d17ebd5ec032053fd733bb/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchOptions.idl
[modify] https://crrev.com/da265efafd1b4eca88d17ebd5ec032053fd733bb/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRegistration.cpp
[modify] https://crrev.com/da265efafd1b4eca88d17ebd5ec032053fd733bb/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRegistration.h
[modify] https://crrev.com/da265efafd1b4eca88d17ebd5ec032053fd733bb/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRegistration.idl
[modify] https://crrev.com/da265efafd1b4eca88d17ebd5ec032053fd733bb/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEvent.cpp
[modify] https://crrev.com/da265efafd1b4eca88d17ebd5ec032053fd733bb/third_party/WebKit/public/platform/modules/background_fetch/background_fetch.mojom
Project Member

Comment 16 by bugdroid1@chromium.org, Mar 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1ab5a9bd84f0a1cf5ebbd322124152bb4cd1323

commit a1ab5a9bd84f0a1cf5ebbd322124152bb4cd1323
Author: peter <peter@chromium.org>
Date: Fri Mar 24 13:59:53 2017

Implement BackgroundFetchManager.fetch() and struct traits

This implements the BackgroundFetchManager.fetch() method and sends it
to the browser process over IPC. Struct traits have been added for three
C++ types that are analogous to the Web exposed types:

  - BackgroundFetchOptions
    The options provided by the developer when starting the fetch.

  - BackgroundFetchRegistration
    The data associated with an in-progress background fetch.

  - IconDefinition
    The data associated with an individual icon definition. This will
    eventually move to a more generalized location.

What's still missing in the call is the sequence of Request objects.

BUG= 692534 ,  692535 

Review-Url: https://codereview.chromium.org/2762573003
Cr-Commit-Position: refs/heads/master@{#459412}

[modify] https://crrev.com/a1ab5a9bd84f0a1cf5ebbd322124152bb4cd1323/content/browser/background_fetch/OWNERS
[modify] https://crrev.com/a1ab5a9bd84f0a1cf5ebbd322124152bb4cd1323/content/browser/background_fetch/background_fetch_service_impl.cc
[modify] https://crrev.com/a1ab5a9bd84f0a1cf5ebbd322124152bb4cd1323/content/browser/background_fetch/background_fetch_service_impl.h
[modify] https://crrev.com/a1ab5a9bd84f0a1cf5ebbd322124152bb4cd1323/content/common/BUILD.gn
[add] https://crrev.com/a1ab5a9bd84f0a1cf5ebbd322124152bb4cd1323/content/common/background_fetch/DEPS
[add] https://crrev.com/a1ab5a9bd84f0a1cf5ebbd322124152bb4cd1323/content/common/background_fetch/OWNERS
[add] https://crrev.com/a1ab5a9bd84f0a1cf5ebbd322124152bb4cd1323/content/common/background_fetch/background_fetch_struct_traits.cc
[add] https://crrev.com/a1ab5a9bd84f0a1cf5ebbd322124152bb4cd1323/content/common/background_fetch/background_fetch_struct_traits.h
[add] https://crrev.com/a1ab5a9bd84f0a1cf5ebbd322124152bb4cd1323/content/common/background_fetch/background_fetch_struct_traits_unittest.cc
[add] https://crrev.com/a1ab5a9bd84f0a1cf5ebbd322124152bb4cd1323/content/common/background_fetch/background_fetch_types.cc
[add] https://crrev.com/a1ab5a9bd84f0a1cf5ebbd322124152bb4cd1323/content/common/background_fetch/background_fetch_types.h
[add] https://crrev.com/a1ab5a9bd84f0a1cf5ebbd322124152bb4cd1323/content/common/background_fetch/background_fetch_types.typemap
[modify] https://crrev.com/a1ab5a9bd84f0a1cf5ebbd322124152bb4cd1323/content/common/typemaps.gni
[modify] https://crrev.com/a1ab5a9bd84f0a1cf5ebbd322124152bb4cd1323/content/test/BUILD.gn
[modify] https://crrev.com/a1ab5a9bd84f0a1cf5ebbd322124152bb4cd1323/third_party/WebKit/Source/modules/background_fetch/BUILD.gn
[modify] https://crrev.com/a1ab5a9bd84f0a1cf5ebbd322124152bb4cd1323/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchBridge.cpp
[modify] https://crrev.com/a1ab5a9bd84f0a1cf5ebbd322124152bb4cd1323/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchBridge.h
[modify] https://crrev.com/a1ab5a9bd84f0a1cf5ebbd322124152bb4cd1323/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.cpp
[modify] https://crrev.com/a1ab5a9bd84f0a1cf5ebbd322124152bb4cd1323/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.h
[modify] https://crrev.com/a1ab5a9bd84f0a1cf5ebbd322124152bb4cd1323/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRegistration.cpp
[modify] https://crrev.com/a1ab5a9bd84f0a1cf5ebbd322124152bb4cd1323/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRegistration.h
[add] https://crrev.com/a1ab5a9bd84f0a1cf5ebbd322124152bb4cd1323/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchTypeConverters.cpp
[add] https://crrev.com/a1ab5a9bd84f0a1cf5ebbd322124152bb4cd1323/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchTypeConverters.h
[modify] https://crrev.com/a1ab5a9bd84f0a1cf5ebbd322124152bb4cd1323/third_party/WebKit/Source/modules/background_fetch/OWNERS
[modify] https://crrev.com/a1ab5a9bd84f0a1cf5ebbd322124152bb4cd1323/third_party/WebKit/public/platform/modules/background_fetch/background_fetch.mojom
Project Member

Comment 17 by bugdroid1@chromium.org, Mar 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b34b21e479145817c93e1e4870ed2e87376eac0

commit 9b34b21e479145817c93e1e4870ed2e87376eac0
Author: peter <peter@chromium.org>
Date: Fri Mar 24 17:12:17 2017

Convert Background Fetch' input to a WebServiceWorkerRequest vector

Developers can pass in either an individual USVString or Request object,
or a sequence of either. Convert the input provided by the developer to
a sequence of WebServiceWorkerRequest objects, which can (soon) be send
over Mojo to the browser process.

BUG= 692534 ,  692535 

Review-Url: https://codereview.chromium.org/2762243002
Cr-Commit-Position: refs/heads/master@{#459465}

[modify] https://crrev.com/9b34b21e479145817c93e1e4870ed2e87376eac0/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-manager-fetch.https.html
[modify] https://crrev.com/9b34b21e479145817c93e1e4870ed2e87376eac0/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/9b34b21e479145817c93e1e4870ed2e87376eac0/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchBridge.cpp
[modify] https://crrev.com/9b34b21e479145817c93e1e4870ed2e87376eac0/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchBridge.h
[modify] https://crrev.com/9b34b21e479145817c93e1e4870ed2e87376eac0/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.cpp
[modify] https://crrev.com/9b34b21e479145817c93e1e4870ed2e87376eac0/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.h
[modify] https://crrev.com/9b34b21e479145817c93e1e4870ed2e87376eac0/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.idl
[add] https://crrev.com/9b34b21e479145817c93e1e4870ed2e87376eac0/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManagerTest.cpp
Project Member

Comment 18 by bugdroid1@chromium.org, Mar 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d

commit 4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d
Author: peter <peter@chromium.org>
Date: Fri Mar 24 17:38:21 2017

Implement the BackgroundFetch{Fail,ed} Service Worker events

This CL implements the two final events part of the Background Fetch
API: backgroundfetchfail and backgroundfetched. They'll be dispatched
from the BackgroundFetchEventDispatcher, through the
ServiceWorkerEventDispatcher, to the renderer, where they'll run.

The BackgroundFetchSettledFetch structure has been defined in the
SWEventDispatcher's mojom file, but will move to its more appropriate
location in Blink when the ServiceWorkerFetchRequest/Response types
have been migrated to Mojo proper. This is in-progress.

BUG= 692534 ,  692581 

Review-Url: https://codereview.chromium.org/2767093004
Cr-Commit-Position: refs/heads/master@{#459469}

[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/content/browser/background_fetch/background_fetch_event_dispatcher.cc
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/content/browser/background_fetch/background_fetch_event_dispatcher.h
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/content/browser/background_fetch/background_fetch_event_dispatcher_unittest.cc
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/content/browser/service_worker/service_worker_metrics.cc
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/content/browser/service_worker/service_worker_metrics.h
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/content/common/background_fetch/background_fetch_struct_traits.cc
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/content/common/background_fetch/background_fetch_struct_traits.h
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/content/common/background_fetch/background_fetch_types.cc
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/content/common/background_fetch/background_fetch_types.h
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/content/common/background_fetch/background_fetch_types.typemap
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/content/common/service_worker/service_worker_event_dispatcher.mojom
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/content/common/service_worker/service_worker_event_dispatcher.typemap
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFailEvent.cpp
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFailEvent.h
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEvent.cpp
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEvent.h
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/third_party/WebKit/public/BUILD.gn
[add] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/third_party/WebKit/public/platform/modules/background_fetch/WebBackgroundFetchSettledFetch.h
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h
[modify] https://crrev.com/4b613c4cd7c83a70d4f176bcb6394b2a800bbd4d/tools/metrics/histograms/histograms.xml
Project Member

Comment 20 by bugdroid1@chromium.org, Mar 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ea74ef3873df9a1b97277a1ddc92414137ff1cd

commit 8ea74ef3873df9a1b97277a1ddc92414137ff1cd
Author: peter <peter@chromium.org>
Date: Mon Mar 27 22:20:56 2017

Hook up BackgroundFetchServiceImpl::Fetch() to start a fetch

This CL hooks up the browser-side mojo endpoint with the rest of the
Background Fetch system to actually start a new background fetch.

BUG= 692534 

Review-Url: https://codereview.chromium.org/2774343002
Cr-Commit-Position: refs/heads/master@{#459905}

[modify] https://crrev.com/8ea74ef3873df9a1b97277a1ddc92414137ff1cd/content/browser/background_fetch/background_fetch_context.cc
[modify] https://crrev.com/8ea74ef3873df9a1b97277a1ddc92414137ff1cd/content/browser/background_fetch/background_fetch_context.h
[modify] https://crrev.com/8ea74ef3873df9a1b97277a1ddc92414137ff1cd/content/browser/background_fetch/background_fetch_data_manager.cc
[modify] https://crrev.com/8ea74ef3873df9a1b97277a1ddc92414137ff1cd/content/browser/background_fetch/background_fetch_data_manager.h
[modify] https://crrev.com/8ea74ef3873df9a1b97277a1ddc92414137ff1cd/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[modify] https://crrev.com/8ea74ef3873df9a1b97277a1ddc92414137ff1cd/content/browser/background_fetch/background_fetch_embedded_worker_test_helper.cc
[modify] https://crrev.com/8ea74ef3873df9a1b97277a1ddc92414137ff1cd/content/browser/background_fetch/background_fetch_embedded_worker_test_helper.h
[modify] https://crrev.com/8ea74ef3873df9a1b97277a1ddc92414137ff1cd/content/browser/background_fetch/background_fetch_event_dispatcher_unittest.cc
[modify] https://crrev.com/8ea74ef3873df9a1b97277a1ddc92414137ff1cd/content/browser/background_fetch/background_fetch_job_controller.cc
[modify] https://crrev.com/8ea74ef3873df9a1b97277a1ddc92414137ff1cd/content/browser/background_fetch/background_fetch_job_controller.h
[modify] https://crrev.com/8ea74ef3873df9a1b97277a1ddc92414137ff1cd/content/browser/background_fetch/background_fetch_job_controller_unittest.cc
[modify] https://crrev.com/8ea74ef3873df9a1b97277a1ddc92414137ff1cd/content/browser/background_fetch/background_fetch_registration_id.cc
[modify] https://crrev.com/8ea74ef3873df9a1b97277a1ddc92414137ff1cd/content/browser/background_fetch/background_fetch_registration_id.h
[modify] https://crrev.com/8ea74ef3873df9a1b97277a1ddc92414137ff1cd/content/browser/background_fetch/background_fetch_service_impl.cc
[modify] https://crrev.com/8ea74ef3873df9a1b97277a1ddc92414137ff1cd/content/browser/background_fetch/background_fetch_service_impl.h
[modify] https://crrev.com/8ea74ef3873df9a1b97277a1ddc92414137ff1cd/content/browser/background_fetch/background_fetch_test_base.h
[modify] https://crrev.com/8ea74ef3873df9a1b97277a1ddc92414137ff1cd/content/browser/bad_message.h
[modify] https://crrev.com/8ea74ef3873df9a1b97277a1ddc92414137ff1cd/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/8ea74ef3873df9a1b97277a1ddc92414137ff1cd/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.cpp
[modify] https://crrev.com/8ea74ef3873df9a1b97277a1ddc92414137ff1cd/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRegistration.cpp
[modify] https://crrev.com/8ea74ef3873df9a1b97277a1ddc92414137ff1cd/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEvent.cpp
[modify] https://crrev.com/8ea74ef3873df9a1b97277a1ddc92414137ff1cd/third_party/WebKit/public/platform/modules/background_fetch/background_fetch.mojom
[modify] https://crrev.com/8ea74ef3873df9a1b97277a1ddc92414137ff1cd/tools/metrics/histograms/histograms.xml
Project Member

Comment 21 by bugdroid1@chromium.org, Mar 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16b9360d3fce4035802c4299fd2c8373d827cb53

commit 16b9360d3fce4035802c4299fd2c8373d827cb53
Author: peter <peter@chromium.org>
Date: Tue Mar 28 15:14:29 2017

Hook up the other Background Fetch Mojo methods with the system

All methods made available through the Mojo interface will now be
appropriately validated and routed through the Background Fetch system.

BUG= 692534 

Review-Url: https://codereview.chromium.org/2777183002
Cr-Commit-Position: refs/heads/master@{#460104}

[modify] https://crrev.com/16b9360d3fce4035802c4299fd2c8373d827cb53/content/browser/background_fetch/background_fetch_context.cc
[modify] https://crrev.com/16b9360d3fce4035802c4299fd2c8373d827cb53/content/browser/background_fetch/background_fetch_context.h
[modify] https://crrev.com/16b9360d3fce4035802c4299fd2c8373d827cb53/content/browser/background_fetch/background_fetch_job_controller.cc
[modify] https://crrev.com/16b9360d3fce4035802c4299fd2c8373d827cb53/content/browser/background_fetch/background_fetch_job_controller.h
[modify] https://crrev.com/16b9360d3fce4035802c4299fd2c8373d827cb53/content/browser/background_fetch/background_fetch_job_controller_unittest.cc
[modify] https://crrev.com/16b9360d3fce4035802c4299fd2c8373d827cb53/content/browser/background_fetch/background_fetch_registration_id.cc
[modify] https://crrev.com/16b9360d3fce4035802c4299fd2c8373d827cb53/content/browser/background_fetch/background_fetch_service_impl.cc
[modify] https://crrev.com/16b9360d3fce4035802c4299fd2c8373d827cb53/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-manager-get.https.html
[modify] https://crrev.com/16b9360d3fce4035802c4299fd2c8373d827cb53/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-manager-getTags.https.html
[modify] https://crrev.com/16b9360d3fce4035802c4299fd2c8373d827cb53/third_party/WebKit/LayoutTests/http/tests/background_fetch/background-fetch-registration-abort.https.html
[modify] https://crrev.com/16b9360d3fce4035802c4299fd2c8373d827cb53/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.cpp
[modify] https://crrev.com/16b9360d3fce4035802c4299fd2c8373d827cb53/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEvent.cpp

Comment 22 by peter@chromium.org, Mar 29 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment