New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 692486 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , All
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Unwanted contents are observed on the left border of scrollbar, while scrolling the list.

Reported by yfulgaon...@etouch.net, Feb 15 2017

Issue description

Chrome Version : 57.0.2987.54 (Official Build) e483b047ce7b13ffee6f490358cc7973a12599de-refs/branch-heads/2987@{#516} 32/64 bit
OS : Windows (7,8,10)

Test URL : http://www.gamestop.com/stores

What steps will reproduce the problem?
1. Launch chrome and navigate to above URL.
2. Drag down the scrollbar of 'Store Details' list and observe the left border of scrollbar (kindly review an attached screen cast).

Actual : Unwanted background contents are observed on the left border of scrollbar, while scrolling the list.
Expected : Background contents should not appear on the border of scrollbar while scrolling the 'Store Details' list.

This is a regression issue broken in ‘M-57’, below is the Manual Regression range and will soon update other info.
Good build : 57.0.2937.0
Bad build : 57.0.2938.0

Note : This is Windows OS specific issue and the same is working fine on Mac & Linux OS.
 
Actual_Result.mp4
1.9 MB View Download
Expected_Result.mp4
1.6 MB View Download
Labels: Needs-Bisect
Status: Untriaged (was: Unconfirmed)

Comment 2 by e...@chromium.org, Feb 15 2017

Components: -Blink>Layout Blink>Paint>Invalidation
Unable to reproduce but looks like a paint invalidation issue. Over to paint for further triage.
Labels: -Needs-Bisect hasbisect
Owner: flackr@chromium.org
Status: Assigned (was: Untriaged)
Narrow Bisect info :
https://chromium.googlesource.com/chromium/src/+log/ec34ad1ad06512ce1788542299cc8823919d415b..91a93770c4d935af7923428b7c00c39f988ee541?pretty=fuller&n=10000

Suspecting : r435280 from Narrow Bisect

@flackr : Please take a look.

Labels: OS-All
Status: Started (was: Assigned)
Looks like a low dpi rounding issue - attaching a minimal repro.
test.html
505 bytes View Download
Labels: -Pri-1 -M-57 BugSource-Chromium PaintTeamTriaged-20170428 M-60 Pri-2
As asked on the code review, what's the status?

Regardless, I don't think this is a P1 because web functionality is not lost and it's not too ugly.

Comment 7 by flackr@chromium.org, May 20 2017

After some discussion with Chris we decided that we should be constructing the composited layers to match the subpixel accumulated snapping. I've uploaded a new patch for review at https://chromium-review.googlesource.com/c/509175/.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b71f6a8eed67fb326ac00d673c810d0a053ad048

commit b71f6a8eed67fb326ac00d673c810d0a053ad048
Author: Robert Flack <flackr@chromium.org>
Date: Fri Jun 02 02:56:38 2017

Account for subpixel accumulation in pixel snapped border box size.

The subpixel accumulation can affect the pixel snapped border box size
of a paint layer. Take this into account when positioning or sizing for
this box's PaintLayer.

Bug:  692486 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I16f78d7105cd9e069d1de563ed81fd09245c1b35
Reviewed-on: https://chromium-review.googlesource.com/509175
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Chris harrelson <chrishtr@chromium.org>
Reviewed-by: Peter Mayo <petermayo@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476536}
[modify] https://crrev.com/b71f6a8eed67fb326ac00d673c810d0a053ad048/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[add] https://crrev.com/b71f6a8eed67fb326ac00d673c810d0a053ad048/third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-background-fractional-offset-expected.html
[add] https://crrev.com/b71f6a8eed67fb326ac00d673c810d0a053ad048/third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-background-fractional-offset.html
[add] https://crrev.com/b71f6a8eed67fb326ac00d673c810d0a053ad048/third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-content-fractional-offset-expected.html
[add] https://crrev.com/b71f6a8eed67fb326ac00d673c810d0a053ad048/third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-content-fractional-offset.html
[modify] https://crrev.com/b71f6a8eed67fb326ac00d673c810d0a053ad048/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/b71f6a8eed67fb326ac00d673c810d0a053ad048/third_party/WebKit/Source/core/layout/LayoutBox.h
[modify] https://crrev.com/b71f6a8eed67fb326ac00d673c810d0a053ad048/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/b71f6a8eed67fb326ac00d673c810d0a053ad048/third_party/WebKit/Source/core/paint/PaintLayer.cpp
[modify] https://crrev.com/b71f6a8eed67fb326ac00d673c810d0a053ad048/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/b71f6a8eed67fb326ac00d673c810d0a053ad048/third_party/WebKit/Source/core/paint/ScrollableAreaPainter.cpp

Status: Fixed (was: Started)

Sign in to add a comment