New issue
Advanced search Search tips

Issue 692484 link

Starred by 1 user
Status: Archived
Owner: ----
Closed: Jan 10
Cc:
torne@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Instead of relying on GOOGLE_CHROME_BUILD in a bunch of places - have it set more specific build-flags to enable features.

Project Member Reported by gsennton@chromium.org, Feb 15 2017 
GOOGLE_CHROME_BUILD in lots of places in the chromium code base, e.g. to enable minidump-generation. We should create more specific flags to enable certain features, and then have the GOOGLE_CHROME_BUILD flag turn those flags on (instead of directly checking GOOGLE_CHROME_BUILD).

Comment 1 by torne@chromium.org, Feb 15 2017 

There are probably existing bugs similar to this around; it's been discussed on chromium-dev at various times and in various forms. Not sure anyone has specifically mentioned the indirect feature flags. For most features the actual fix is to just make it depend on official-build and not the chrome branding, but crash/uma might be an exception.

Comment 2 by benhenry@google.com, Jan 10

Status: Archived (was: Untriaged)
Archiving P3s older than 1 year with no owner or component.
►

Sign in to add a comment