New issue
Advanced search Search tips

Issue 692464 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Fix memory leaks related to view::Combobox

Project Member Reported by dvadym@chromium.org, Feb 15 2017

Issue description

view::Combobox is not an owner of a model, ensure that the model is deleted properly. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f04263b4bf4d2d0cc447e0b162a837d60b2ba73

commit 3f04263b4bf4d2d0cc447e0b162a837d60b2ba73
Author: dvadym <dvadym@chromium.org>
Date: Wed Feb 15 11:42:15 2017

Fixed memory leak in Password Manager UI.

view::Combobox is not owner of a model, previously the model was not deleted in CredentialsSelectionView.

BUG= 692464 

Review-Url: https://codereview.chromium.org/2691323002
Cr-Commit-Position: refs/heads/master@{#450670}

[modify] https://crrev.com/3f04263b4bf4d2d0cc447e0b162a837d60b2ba73/chrome/browser/ui/views/passwords/credentials_selection_view.cc
[modify] https://crrev.com/3f04263b4bf4d2d0cc447e0b162a837d60b2ba73/chrome/browser/ui/views/passwords/credentials_selection_view.h

Status: Fixed (was: Started)

Sign in to add a comment