New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 692447 link

Starred by 2 users
Status: Fixed
Owner:
█ ecacho@google.com
Last visit > 30 days ago
Closed: Aug 2017
Cc:
mard...@chromium.org
█ lpromero@chromium.org
█ chiaravanone@chromium.org
█ manji@chromium.org
srahim@chromium.org
pinkerton@chromium.org
linds...@chromium.org
ios-bugs@chromium.org
songsuk@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Remove "Done" -> "Finished" string translation for U.K. English phones

Project Member Reported by pschaffner@chromium.org, Feb 15 2017 
I don't know when/why this manual translation crept in, but the [button] string should remain as "Done" for both dialects. This is desired for all instances (History, Bookmarks, Recent tabs, etc.).

While it might be better to say "Finished" [for modal tasks] in the U.K., the UIBarButtonSystemItem "done" case does not change based on [English] dialect, and that is what we should be using (or at least modeling our custom button after).

Comment 1 by mard...@chromium.org, Feb 15 2017

Cc: linds...@chromium.org manji@chromium.org pinkerton@chromium.org
Owner: chiaravanone@chromium.org
Status: Assigned (was: Untriaged)
Assinging to Chiara to get some clarity on "Done" vs. "Finished" for US vs. UK English. Are "Done" in en-US translated to "Finished" in en-UK in other Google Apps? 
Apple seems to keep "Done" for both locales in their apps and throughout the OS. 

Thanks.

Comment 2 by linds...@chromium.org, Mar 10 2017

Components: UI>Localization

Comment 3 by pschaffner@chromium.org, Apr 5 2017

Cc: srahim@chromium.org

Comment 4 by ecacho@google.com, Jul 11 2017

Cc: chiaravanone@chromium.org
Owner: ecacho@google.com
Hi,

Thanks for sending a report. I've sent this to our linguists for correction. Please see bug as reference: 

https://b.corp.google.com/issues/63582211

Comment 5 by mencinares@google.com, Aug 19 2017 

Hi,

This is now fixed in the translation and we're now just waiting for it to push to live version.

Regards

Comment 6 by mencinares@google.com, Aug 19 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment