New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 692444 link

Starred by 4 users
Status: WontFix
Owner: ----
Closed: Mar 2017
Cc:
tommi@chromium.org
guidou@chromium.org
█ perkj@chromium.org
█ mbjorge@chromium.org
grunell@chromium.org
webrtc-testing@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Clean up ENABLE_WEBRTC define

Project Member Reported by kjellander@chromium.org, Feb 15 2017 
I'm suggesting we clean up the enable_webrtc GN variable [1] and the ENABLE_WEBRTC define. 

AFAIK there's no point building with WebRTC disabled and that configuration keeps breaking ( bug 667527 ,  bug 240988 ) since no bots are building with enable_webrtc=false.

perkj/tommi: do you know anyone that might be using this? You're the only ones except lally@ that showed up when I did git blame digging into where enable_webrtc was originally added...

[1]: https://cs.chromium.org/chromium/src/media/media_options.gni?rcl=d0f1bb54f393f66586c7e85ccddfb314a146be61&l=52

Comment 1 by perkj@chromium.org, Feb 15 2017 

I think it was added before WebRTC went into Chrome Stable (M27?) and was
later used by Android before Android supported WebRTC.
Is it used by IOS builds?

Comment 2 by guidou@chromium.org, Feb 16 2017

Cc: guidou@chromium.org mbjorge@chromium.org
cc mbjorge@, who has filed  issue 667546  to create a bot with enable_webrtc=false for cast audio. Perhaps that's a use case for WebRTC disabled.

Comment 3 by mbjorge@chromium.org, Feb 16 2017 

Thanks for the heads up. Let me take a look and see what the status is here. I believe we ultimately want to move to supporting webrtc on all our platforms, but we do explicitly set enable_webrtc false for some of them currently.

Comment 4 by mbjorge@chromium.org, Feb 16 2017 

Looks like we need to keep enable_webrtc around. Building with enable_webrtc=true adds 2.5MB to our stripped user builds, which is a huge bump for our builds that are already pushing the limits of size on devices.

I think best action is for me to put  issue 667546  higher on my priorty list and get a bot building with enable_webrtc=false

Comment 5 by guidou@chromium.org, Mar 6 2017

Status: WontFix (was: Untriaged)
Marking as WontFix as per comment #4.
►

Sign in to add a comment