Add monitoring to luci's GCE client library |
||||||||
Issue descriptionhttps://chromium.googlesource.com/external/github.com/luci/luci-py/+/master/appengine/components/components/gce.py We need the standard HTTP request monitoring we have elsewhere.
,
Jul 6 2017
,
Jul 7 2017
Removing Infra>Monitoring since this is an alert update to a specific service and not a monitoring pipeline issue. Assigned to Infra>Platform>MachineProvider
,
Jun 2 2018
Friendly ping. This would be really nice to have. Is anyone looking into this?
,
Aug 21
Assigned to Erik to triage. Friendly ping, this is a P2 for cit-pm-45
,
Aug 23
,
Aug 28
,
Aug 31
Where do you get this "standard HTTP request monitoring"? I wasn't aware that any of our apps had monitoring on outbound requests. For example, here are the graphs we have for cr-buildbucket: https://viceroy.corp.google.com/chrome_infra/Appengine/cr-buildbucket I see incoming HTTP requests, incoming API requests, and outbound requests made by the Buildbucket client, but I don't see any metrics for outbound requests made by the server. In fact, the entire appengine/components/components/net.py module, which is used to make all outbound requests from our Python apps, doesn't have any instrumentation at all. That's not to say we can't instrument it, but adding instrumentation to net.py is roughly equivalent to instrumenting every Python service we have, which sounds great, but it also sounds like a large undertaking. Anyways, I think we need some equivalent of this (which is for client tools) for servers: https://chromium.googlesource.com/infra/luci/luci-py/+/master/client/third_party/infra_libs/instrumented_requests.py |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by benhenry@chromium.org
, May 24 2017