New issue
Advanced search Search tips

Issue 692431 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 690292



Sign in to add a comment

Add monitoring to luci's GCE client library

Project Member Reported by dsansome@chromium.org, Feb 15 2017

Issue description

Labels: cit-pm-45
Components: Infra>Monitoring
Owner: ----
Status: Available (was: Assigned)

Comment 3 by efoo@chromium.org, Jul 7 2017

Components: -Infra>Monitoring
Labels: Ops-AddMonitoring
Removing Infra>Monitoring since this is an alert update to a specific service and not a monitoring pipeline issue. Assigned to Infra>Platform>MachineProvider

Comment 4 by efoo@chromium.org, Jun 2 2018

Labels: -Pri-3 Pri-2
Friendly ping. This would be really nice to have. Is anyone looking into this? 
Owner: estaab@chromium.org
Assigned to Erik to triage. Friendly ping, this is a P2 for cit-pm-45
Cc: -smut@chromium.org estaab@chromium.org
Owner: s...@google.com
Status: Assigned (was: Available)
Labels: cit-pm-91
Cc: s...@google.com
Labels: -cit-pm-91 chops-pm-91
Owner: ----
Status: Available (was: Assigned)
Where do you get this "standard HTTP request monitoring"? I wasn't aware that any of our apps had monitoring on outbound requests. For example, here are the graphs we have for cr-buildbucket:
https://viceroy.corp.google.com/chrome_infra/Appengine/cr-buildbucket

I see incoming HTTP requests, incoming API requests, and outbound requests made by the Buildbucket client, but I don't see any metrics for outbound requests made by the server. In fact, the entire appengine/components/components/net.py module, which is used to make all outbound requests from our Python apps, doesn't have any instrumentation at all.

That's not to say we can't instrument it, but adding instrumentation to net.py is roughly equivalent to instrumenting every Python service we have, which sounds great, but it also sounds like a large undertaking.

Anyways, I think we need some equivalent of this (which is for client tools) for servers:
https://chromium.googlesource.com/infra/luci/luci-py/+/master/client/third_party/infra_libs/instrumented_requests.py

Sign in to add a comment