New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 692425 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
User never visited
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 690292



Sign in to add a comment

Impose a safety check on the number of instance templates in the config.

Project Member Reported by dsansome@chromium.org, Feb 15 2017

Issue description

To protect against something crazy happening.  It looks like this limit should be ~10 or so for now, but of course it can be raised later as needed.
 

Comment 1 by s...@google.com, Feb 16 2017

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/4ac1c3735889aa3e743cf2d9ad23f65998a87f73

commit 4ac1c3735889aa3e743cf2d9ad23f65998a87f73
Author: smut <smut@google.com>
Date: Thu Feb 16 23:05:02 2017

Enforce limits on configs

10 for instance templates (arbitrarily chosen based on current usage) and 1000 for instances per instance group (GCE-enforced limit).

BUG= 692425 , 692428 

Review-Url: https://codereview.chromium.org/2698153002

[modify] https://crrev.com/4ac1c3735889aa3e743cf2d9ad23f65998a87f73/appengine/gce-backend/config.py
[modify] https://crrev.com/4ac1c3735889aa3e743cf2d9ad23f65998a87f73/appengine/gce-backend/config_test.py

Comment 3 by s...@google.com, Feb 16 2017

Status: Fixed (was: Started)

Sign in to add a comment