Issue metadata
Sign in to add a comment
|
Keyboard shortcuts stopped working for tabs/windows etc
Reported by
mich...@wearejh.com,
Feb 15 2017
|
||||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3012.0 Safari/537.36 Steps to reproduce the problem: 1. Try to switch tab, close tab/window, open tab/window using the keyboard shortcuts What is the expected behavior? It should switch/close/open as expected What went wrong? It does nothing Did this work before? Yes Chrome version: 58.0.3012.0 Channel: canary OS Version: OS X 10.11.6 Flash Version:
,
Feb 15 2017
,
Feb 15 2017
Same issue here on chrome canary 58.0.3013.0 mac. Makes canary mostly unusable on mac.
,
Feb 16 2017
Issue 692148 has been merged into this issue.
,
Feb 16 2017
Are there particular sites where this doesn't work?
,
Feb 16 2017
Are you by chance running in a fullscreen browser window?
,
Feb 16 2017
Keyboard shortcuts are broken in fullscreen but work when not in fullscreen. The menu items show up disabled.
,
Feb 16 2017
You are probably looking for a change made after 449895 (known good), but no later than 449896 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/1a8d5f3805dbae5242cf7dce14df3807344dae37..3c7af99a93f4b4837b2fbee5cb66697f66ccf241 There is only one revision, "Disable browser key reservation in fullscreen mode". I think we should revert it. macOS fullscreen is not like fullscreen on other platforms. It's more like "maximize". Disable browser key reservation in fullscreen mode In intent to implement https://goo.gl/4tJ32G, we decided to deliver browser shortcuts to the websites, so a web page can provide almost consistent user experience as a native application. To ensure there is no security risk, a simple and safe approach is to allow websites to capture browser reserved keyboard combinations in full screen mode only. This does not apply to the keys to exit fullscreen (F11) or exit the application (ESC). BUG= 680809 Review-Url: https://codereview.chromium.org/2636013002 Cr-Commit-Position: refs/heads/master@{#449896}
,
Feb 16 2017
Fix is already in the CQ: https://codereview.chromium.org/2698013004/.
,
Feb 16 2017
The change in c#9 does *not* fix the problem. The bottom line is that keyboard shortcuts should work in fullscreen when the top chrome is visible. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by mich...@wearejh.com
, Feb 15 2017