New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 692401 link

Starred by 1 user
Status: Verified
Owner:
akahuang@chromium.org
Closed: Apr 2017
Cc:
█ chuntsen@chromium.org
█ kitching@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

VSWR: test time cycle is too long.

Project Member Reported by akahuang@chromium.org, Feb 15 2017 
The testing time for 2 antenna is about 180 seconds, which is much longer than before. The root cause of the issue is that testlog updates the JSON session for each point, and the size of the data in VSWR test is about 1600.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/ec792fef9a642e8821dfa01f4694024fc80af7d0

commit ec792fef9a642e8821dfa01f4694024fc80af7d0
Author: Chih-Yu Huang <akahuang@google.com>
Date: Wed Feb 15 16:20:55 2017

testlog: update session once when logging series data.

Originally, testlog updates the session to JSON file when logging each
point. In VSWR pytest, we record the trace data which has 1600 points.
That means we need to update the session 1600 times, which takes lots
of time.
In this CL, we only update the session once after logging all the data
point. Thus, the test time is much shorter.

BUG= chromium:692401 
TEST=make test

Change-Id: I3d44a19975a81b931755b615bd17468ed1df35ac
Reviewed-on: https://chromium-review.googlesource.com/443007
Commit-Ready: Chih-Yu Huang <akahuang@chromium.org>
Tested-by: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: Chun-Tsen Kuo <chuntsen@chromium.org>

[modify] https://crrev.com/ec792fef9a642e8821dfa01f4694024fc80af7d0/py/test/pytests/vswr/vswr.py
[modify] https://crrev.com/ec792fef9a642e8821dfa01f4694024fc80af7d0/py/test/testlog.py

Comment 2 by akahuang@chromium.org, Apr 20 2017

Status: Verified (was: Assigned)
The issue is fixed by #1.
►

Sign in to add a comment