New issue
Advanced search Search tips

Issue 692400 link

Starred by 1 user
Status: Fixed
Owner:
tkent@chromium.org
Closed: Feb 2017
Cc:
editing-dev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 683066



Sign in to add a comment

Selection API: collapse*(), deleteFromDocument(), extend(), setBaseAndExtent(), and selectAllChildren() should operate DOM Range

Project Member Reported by tkent@chromium.org, Feb 15 2017 
Chrome Version: ToT
OS: All but iOS

What steps will reproduce the problem?
(1) Run tests in http://w3c-test.org/selection/.

What is the expected result?
Small number of failures.

What happens instead?
Large number of failures.

Please use labels and text to provide additional information.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de65c2b24fc750fd8aee253b2be3600bf1a6555b

commit de65c2b24fc750fd8aee253b2be3600bf1a6555b
Author: tkent <tkent@chromium.org>
Date: Thu Feb 16 06:24:59 2017

Selection API: setBaseAndExtent() and selectAllChildren() should create new Range based on the specified nodes.

* ConsoleViewport._textOffsetInNode():
  It supported only Text node |container|. This CL adds Element support.

This CL removes the following tests because they are covered
by external/wpt/selection/:
 - editing/selection/getRangeAt.html
 - editing/selection/select_all/select_all_html.html
 - editing/selection/set_base_and_extent/set_base_and_extent_html.html

This CL fixes 2056 sub-tests in external/wpt/selection/.

BUG= 692400 

Review-Url: https://codereview.chromium.org/2695193002
Cr-Commit-Position: refs/heads/master@{#450876}

[modify] https://crrev.com/de65c2b24fc750fd8aee253b2be3600bf1a6555b/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/de65c2b24fc750fd8aee253b2be3600bf1a6555b/third_party/WebKit/LayoutTests/editing/pasteboard/smart-paste-008.html
[modify] https://crrev.com/de65c2b24fc750fd8aee253b2be3600bf1a6555b/third_party/WebKit/LayoutTests/editing/selection/dump-as-markup-expected.txt
[modify] https://crrev.com/de65c2b24fc750fd8aee253b2be3600bf1a6555b/third_party/WebKit/LayoutTests/editing/selection/focus-contenteditable-iframe-expected.txt
[delete] https://crrev.com/90cfee2509916bf517552bd6f69acb9d5086aeaf/third_party/WebKit/LayoutTests/editing/selection/getRangeAt-expected.txt
[delete] https://crrev.com/90cfee2509916bf517552bd6f69acb9d5086aeaf/third_party/WebKit/LayoutTests/editing/selection/getRangeAt.html
[modify] https://crrev.com/de65c2b24fc750fd8aee253b2be3600bf1a6555b/third_party/WebKit/LayoutTests/editing/selection/legal-positions.html
[delete] https://crrev.com/90cfee2509916bf517552bd6f69acb9d5086aeaf/third_party/WebKit/LayoutTests/editing/selection/select_all/select_all_html.html
[modify] https://crrev.com/de65c2b24fc750fd8aee253b2be3600bf1a6555b/third_party/WebKit/LayoutTests/editing/selection/selection_remove_children.html
[modify] https://crrev.com/de65c2b24fc750fd8aee253b2be3600bf1a6555b/third_party/WebKit/LayoutTests/editing/selection/set_base_and_extent/crossing_editable_boundary.html
[delete] https://crrev.com/90cfee2509916bf517552bd6f69acb9d5086aeaf/third_party/WebKit/LayoutTests/editing/selection/set_base_and_extent/set_base_and_extent_html.html
[modify] https://crrev.com/de65c2b24fc750fd8aee253b2be3600bf1a6555b/third_party/WebKit/LayoutTests/editing/undo/remove-css-property-and-remove-style-expected.txt
[delete] https://crrev.com/90cfee2509916bf517552bd6f69acb9d5086aeaf/third_party/WebKit/LayoutTests/external/wpt/selection/selectAllChildren-expected.txt
[modify] https://crrev.com/de65c2b24fc750fd8aee253b2be3600bf1a6555b/third_party/WebKit/LayoutTests/external/wpt/selection/setBaseAndExtent-expected.txt
[modify] https://crrev.com/de65c2b24fc750fd8aee253b2be3600bf1a6555b/third_party/WebKit/LayoutTests/fast/text/pre-wrap-trailing-tab-expected.txt
[modify] https://crrev.com/de65c2b24fc750fd8aee253b2be3600bf1a6555b/third_party/WebKit/LayoutTests/fast/text/pre-wrap-trailing-tab.html
[modify] https://crrev.com/de65c2b24fc750fd8aee253b2be3600bf1a6555b/third_party/WebKit/LayoutTests/platform/mac/fast/css/first-letter-rtc-crash-expected.txt
[delete] https://crrev.com/90cfee2509916bf517552bd6f69acb9d5086aeaf/third_party/WebKit/LayoutTests/platform/win/external/wpt/selection/selectAllChildren-expected.txt
[modify] https://crrev.com/de65c2b24fc750fd8aee253b2be3600bf1a6555b/third_party/WebKit/Source/core/editing/DOMSelection.cpp
[modify] https://crrev.com/de65c2b24fc750fd8aee253b2be3600bf1a6555b/third_party/WebKit/Source/core/editing/DOMSelection.h
[modify] https://crrev.com/de65c2b24fc750fd8aee253b2be3600bf1a6555b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewport.js
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d81e25a23b11c7193b09b3e2f4d69f3d06d31a6

commit 4d81e25a23b11c7193b09b3e2f4d69f3d06d31a6
Author: tkent <tkent@chromium.org>
Date: Thu Feb 16 14:55:38 2017

Selection API: extend() should operate DOM Ranges.

This CL fixes 1,856 tests in external/wpt/selection/.

BUG= 692400 

Review-Url: https://codereview.chromium.org/2704443002
Cr-Commit-Position: refs/heads/master@{#450962}

[modify] https://crrev.com/4d81e25a23b11c7193b09b3e2f4d69f3d06d31a6/third_party/WebKit/LayoutTests/editing/assert_selection.html
[modify] https://crrev.com/4d81e25a23b11c7193b09b3e2f4d69f3d06d31a6/third_party/WebKit/LayoutTests/editing/execCommand/crash-indenting-list-item.html
[modify] https://crrev.com/4d81e25a23b11c7193b09b3e2f4d69f3d06d31a6/third_party/WebKit/LayoutTests/editing/execCommand/format-block-multiple-paragraphs-in-pre.html
[modify] https://crrev.com/4d81e25a23b11c7193b09b3e2f4d69f3d06d31a6/third_party/WebKit/LayoutTests/editing/execCommand/format-block-multiple-paragraphs.html
[modify] https://crrev.com/4d81e25a23b11c7193b09b3e2f4d69f3d06d31a6/third_party/WebKit/LayoutTests/editing/selection/character-data-mutation.html
[modify] https://crrev.com/4d81e25a23b11c7193b09b3e2f4d69f3d06d31a6/third_party/WebKit/LayoutTests/editing/selection/document-mutation.html
[rename] https://crrev.com/4d81e25a23b11c7193b09b3e2f4d69f3d06d31a6/third_party/WebKit/LayoutTests/external/wpt/selection/extend-00-expected.txt
[add] https://crrev.com/4d81e25a23b11c7193b09b3e2f4d69f3d06d31a6/third_party/WebKit/LayoutTests/external/wpt/selection/extend-20-expected.txt
[modify] https://crrev.com/4d81e25a23b11c7193b09b3e2f4d69f3d06d31a6/third_party/WebKit/LayoutTests/external/wpt/selection/extend-40-expected.txt
[modify] https://crrev.com/4d81e25a23b11c7193b09b3e2f4d69f3d06d31a6/third_party/WebKit/LayoutTests/fast/dynamic/move-node-with-selection.html
[delete] https://crrev.com/5fdb85e384dd972552e22622350d12ff8492c686/third_party/WebKit/LayoutTests/platform/win/external/wpt/selection/extend-20-expected.txt
[modify] https://crrev.com/4d81e25a23b11c7193b09b3e2f4d69f3d06d31a6/third_party/WebKit/Source/core/editing/DOMSelection.cpp
[modify] https://crrev.com/4d81e25a23b11c7193b09b3e2f4d69f3d06d31a6/third_party/WebKit/Source/core/editing/DOMSelection.h
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1227e8921776ed2ba4b5497a228f2e2c4143ed23

commit 1227e8921776ed2ba4b5497a228f2e2c4143ed23
Author: tkent <tkent@chromium.org>
Date: Fri Feb 17 10:24:48 2017

Selection API: collapse() should recreate an internal Range.

This CL fixes 1,354 tests in external/wpt/selection/.

Some existing tests needs to check visual caret position. So this CL introduces
internals.visibleSelection{AnchorNode,AnchorOffset,FocusNode,FocusOffset} for
them.

BUG= 692400 

Review-Url: https://codereview.chromium.org/2697313005
Cr-Commit-Position: refs/heads/master@{#451277}

[modify] https://crrev.com/1227e8921776ed2ba4b5497a228f2e2c4143ed23/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/1227e8921776ed2ba4b5497a228f2e2c4143ed23/third_party/WebKit/LayoutTests/editing/deleting/typing_one_character_delete_crash.html
[modify] https://crrev.com/1227e8921776ed2ba4b5497a228f2e2c4143ed23/third_party/WebKit/LayoutTests/editing/pasteboard/display-block-on-spans-expected.txt
[modify] https://crrev.com/1227e8921776ed2ba4b5497a228f2e2c4143ed23/third_party/WebKit/LayoutTests/editing/pasteboard/paste-text-with-style-expected.txt
[modify] https://crrev.com/1227e8921776ed2ba4b5497a228f2e2c4143ed23/third_party/WebKit/LayoutTests/editing/selection/collapse/collapse_before_select.html
[modify] https://crrev.com/1227e8921776ed2ba4b5497a228f2e2c4143ed23/third_party/WebKit/LayoutTests/editing/selection/collapse/collapse_document_in_design_mode.html
[modify] https://crrev.com/1227e8921776ed2ba4b5497a228f2e2c4143ed23/third_party/WebKit/LayoutTests/editing/selection/collapse/collapse_html_to_editable_body.html
[modify] https://crrev.com/1227e8921776ed2ba4b5497a228f2e2c4143ed23/third_party/WebKit/LayoutTests/editing/selection/collapse/table-caret-2.html
[modify] https://crrev.com/1227e8921776ed2ba4b5497a228f2e2c4143ed23/third_party/WebKit/LayoutTests/editing/selection/collapse/table-caret-3.html
[modify] https://crrev.com/1227e8921776ed2ba4b5497a228f2e2c4143ed23/third_party/WebKit/LayoutTests/editing/selection/home-end-expected.txt
[modify] https://crrev.com/1227e8921776ed2ba4b5497a228f2e2c4143ed23/third_party/WebKit/LayoutTests/editing/selection/modify_move/resources/move-by-word-visually.js
[modify] https://crrev.com/1227e8921776ed2ba4b5497a228f2e2c4143ed23/third_party/WebKit/LayoutTests/editing/selection/move-left-right.html
[modify] https://crrev.com/1227e8921776ed2ba4b5497a228f2e2c4143ed23/third_party/WebKit/LayoutTests/editing/selection/skip-not-adjacent-contenteditable-expected.txt
[modify] https://crrev.com/1227e8921776ed2ba4b5497a228f2e2c4143ed23/third_party/WebKit/LayoutTests/editing/selection/skip-not-adjacent-contenteditable.html
[modify] https://crrev.com/1227e8921776ed2ba4b5497a228f2e2c4143ed23/third_party/WebKit/LayoutTests/editing/selection/table-caret-1.html
[modify] https://crrev.com/1227e8921776ed2ba4b5497a228f2e2c4143ed23/third_party/WebKit/LayoutTests/editing/selection/unrendered-001.html
[modify] https://crrev.com/1227e8921776ed2ba4b5497a228f2e2c4143ed23/third_party/WebKit/LayoutTests/editing/selection/unrendered-space.html
[modify] https://crrev.com/1227e8921776ed2ba4b5497a228f2e2c4143ed23/third_party/WebKit/LayoutTests/external/wpt/selection/collapse-00-expected.txt
[modify] https://crrev.com/1227e8921776ed2ba4b5497a228f2e2c4143ed23/third_party/WebKit/LayoutTests/external/wpt/selection/collapse-30-expected.txt
[modify] https://crrev.com/1227e8921776ed2ba4b5497a228f2e2c4143ed23/third_party/WebKit/Source/core/editing/DOMSelection.cpp
[modify] https://crrev.com/1227e8921776ed2ba4b5497a228f2e2c4143ed23/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/1227e8921776ed2ba4b5497a228f2e2c4143ed23/third_party/WebKit/Source/core/testing/Internals.h
[modify] https://crrev.com/1227e8921776ed2ba4b5497a228f2e2c4143ed23/third_party/WebKit/Source/core/testing/Internals.idl

Comment 6 by tkent@chromium.org, Feb 20 2017

Summary: Selection API: collapse*(), deleteFromDocument(), extend(), setBaseAndExtent(), and selectAllChildren() should operate DOM Range (was: Selection API: collapse*(), extend(), setBaseAndExtent(), and selectAllChildren() should operate DOM Range)
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2db9622432f02cef305a8e7870793394992e2b41

commit 2db9622432f02cef305a8e7870793394992e2b41
Author: tkent <tkent@chromium.org>
Date: Mon Feb 20 16:00:56 2017

Selection API: deleteFromDocument() should refer to a registered Range.

This CL fixes 22 tests in external/wpt/selection/.

BUG= 692400 

Review-Url: https://codereview.chromium.org/2709483002
Cr-Commit-Position: refs/heads/master@{#451633}

[delete] https://crrev.com/bcc2246dd6c9f56186e23e11811d06707cde5735/third_party/WebKit/LayoutTests/external/wpt/selection/deleteFromDocument-expected.txt
[modify] https://crrev.com/2db9622432f02cef305a8e7870793394992e2b41/third_party/WebKit/Source/core/editing/DOMSelection.cpp
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1de8912f43f6ed0ec035aa46b93ad831b59cbd67

commit 1de8912f43f6ed0ec035aa46b93ad831b59cbd67
Author: cfroussios <cfroussios@chromium.org>
Date: Mon Feb 20 17:52:58 2017

Revert of Selection API: collapseToStart() and collapseToEnd() should recreate a Range. (patchset #3 id:40001 of https://codereview.chromium.org/2704963002/ )

Reason for revert:
Suspected cause of failure
Test:
fast/css/first-letter-rtc-crash.html

See bug  http://crbug.com/694307 

Original issue's description:
> Selection API: collapseToStart() and collapseToEnd() should recreate a Range.
>
> This CL fixes 46 tests in external/wpt/selection/.
>
> BUG= 692400 
>
> Review-Url: https://codereview.chromium.org/2704963002
> Cr-Commit-Position: refs/heads/master@{#451630}
> Committed: https://chromium.googlesource.com/chromium/src/+/716c489b25ad9529994fc83be70b8c33b2f3b486

TBR=yosin@chromium.org,yoichio@chromium.org,tkent@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 692400 

Review-Url: https://codereview.chromium.org/2708763002
Cr-Commit-Position: refs/heads/master@{#451646}

[modify] https://crrev.com/1de8912f43f6ed0ec035aa46b93ad831b59cbd67/third_party/WebKit/LayoutTests/external/wpt/selection/collapseToStartEnd-expected.txt
[modify] https://crrev.com/1de8912f43f6ed0ec035aa46b93ad831b59cbd67/third_party/WebKit/LayoutTests/fast/css/first-letter-rtc-crash-expected.txt
[modify] https://crrev.com/1de8912f43f6ed0ec035aa46b93ad831b59cbd67/third_party/WebKit/Source/core/editing/DOMSelection.cpp

Comment 11 by tkent@chromium.org, Feb 20 2017

Labels: M-58
Status: Fixed (was: Started)
►

Sign in to add a comment