New issue
Advanced search Search tips

Issue 692384 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

camera_HAL3 test should verify camera orientation is 0

Project Member Reported by wuchengli@chromium.org, Feb 15 2017

Issue description

Now that we added a hardware requirement that the top of the back camera should match the top of the display in tablet mode. Let's add a check in arc-camera.eclass to enforce this.

third_party/chromiumos-overlay/eclass/arc-camera.eclass

 
Ping. Any update for this? Or maybe we should use autotest to test this?
Cc: jcliang@chromium.org henryhsu@chromium.org
Owner: hywu@chromium.org
MIPI cameras may not have this file. Let's add a test in camera_HAL3 to verify the camera orientation is 0.
Summary: camera_HAL3 test should verify camera orientation is 0 (was: arc-camera.eclass should verify camera orientation is 0)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/arc-camera/+/f82b665b9419205a2a690ad75d367de1f3425f63

commit f82b665b9419205a2a690ad75d367de1f3425f63
Author: Daniel Hung-yu Wu <hywu@google.com>
Date: Sat Mar 25 10:51:13 2017

camera3_test: verify camera orientation

Verify that the camera orientaion is 0, i.e. the top of the camera
should match the top of display.

BUG= chromium:692384 
TEST='emerge-kevin arc-camera3-test'
     'arc_camera3_test --gtest_filter=Camera3DeviceTest/*'

Change-Id: Ib93f5d409480be46b28c519c6cd46a7dcea8a774
Reviewed-on: https://chromium-review.googlesource.com/458461
Commit-Ready: Hung-yu Wu <hywu@chromium.org>
Tested-by: Hung-yu Wu <hywu@chromium.org>
Reviewed-by: Ricky Liang <jcliang@chromium.org>

[modify] https://crrev.com/f82b665b9419205a2a690ad75d367de1f3425f63/camera3_test/camera3_device_test.cc
[modify] https://crrev.com/f82b665b9419205a2a690ad75d367de1f3425f63/camera3_test/camera3_device_fixture.h

Status: Fixed (was: Assigned)

Comment 6 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment