New issue
Advanced search Search tips

Issue 692360 link

Starred by 12 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task
Launch-Security: NA

Blocking:
issue 618746



Sign in to add a comment

inert attribute

Project Member Reported by aboxhall@chromium.org, Feb 15 2017

Issue description

Change description:
Implement the inert attribute. https://github.com/WICG/inert#spec

Changes to API surface:
HTML: add a global `inert` attribute.

Links:
Public standards discussion: https://discourse.wicg.io/t/inert-attribute/1838

Support in other browsers:
Internet Explorer: No public signals.
Firefox: Tentative support (https://discourse.wicg.io/t/inert-attribute/1838/30)
Safari: Some support (https://discourse.wicg.io/t/inert-attribute/1838/47)


 
Description: Show this description
Components: Blink>HTML
Blocking: 618746

Comment 4 by est...@chromium.org, Feb 20 2017

Labels: Launch-Security-NA
No security concerns.
Project Member

Comment 5 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2

commit cca67d31f4a0b4ec2c20090a8bfc38c464274ab2
Author: aboxhall <aboxhall@chromium.org>
Date: Wed May 24 03:47:53 2017

Implement the inert attribute: https://github.com/WICG/inert#tldr

https://discourse.wicg.io/t/inert-attribute/1838/

BUG=692360

Review-Url: https://codereview.chromium.org/2088453002
Cr-Commit-Position: refs/heads/master@{#474153}

[modify] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/LayoutTests/external/wpt/html/dom/elements/elements-in-the-dom/historical.html
[add] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/LayoutTests/fast/dom/inert/inert-does-not-match-disabled-selector.html
[add] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/LayoutTests/fast/dom/inert/inert-focus-in-frames.html
[add] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/LayoutTests/fast/dom/inert/inert-in-shadow-dom.html
[add] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/LayoutTests/fast/dom/inert/inert-inlines.html
[add] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/LayoutTests/fast/dom/inert/inert-label-focus.html
[add] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/LayoutTests/fast/dom/inert/inert-node-is-uneditable.html
[add] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/LayoutTests/fast/dom/inert/inert-node-is-unfocusable.html
[add] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/LayoutTests/fast/dom/inert/inert-node-is-unselectable.html
[add] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/LayoutTests/fast/dom/inert/resources/dialog-layout.css
[add] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/LayoutTests/fast/dom/inert/resources/inert-focus-in-frames-frame1.html
[modify] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodes-expected.txt
[modify] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodes.html
[delete] https://crrev.com/54bf385aa6becac4aeecd2bf79604bc9421b6306/third_party/WebKit/LayoutTests/platform/linux/inspector-protocol/accessibility/accessibility-ignoredNodes-expected.txt
[delete] https://crrev.com/54bf385aa6becac4aeecd2bf79604bc9421b6306/third_party/WebKit/LayoutTests/platform/win/inspector-protocol/accessibility/accessibility-ignoredNodes-expected.txt
[modify] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/Source/core/dom/Node.h
[modify] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/Source/core/dom/Text.cpp
[modify] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/Source/core/html/HTMLAttributeNames.json5
[modify] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/Source/core/html/HTMLElement.cpp
[modify] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/Source/core/html/HTMLElement.idl
[modify] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js
[modify] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp
[modify] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h
[modify] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h
[modify] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
[modify] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h
[modify] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp
[modify] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h
[modify] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
[modify] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h
[modify] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp
[modify] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
[modify] https://crrev.com/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2/tools/metrics/histograms/enums.xml

Project Member

Comment 6 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e353755ef5c7e109ddf2370ebacc39377924fc55

commit e353755ef5c7e109ddf2370ebacc39377924fc55
Author: vitaliii <vitaliii@chromium.org>
Date: Wed May 24 12:22:48 2017

Revert of "Implement the inert attribute"

The revert did not apply cleanly, there were conflicts in:
- third_party/WebKit/Source/core/frame/UseCounter.h
- tools/metrics/histograms/enums.xml

Reason for revert:
The new added tests leak. See  crbug.com/725815 .

Original issue's description:
> Implement the inert attribute: https://github.com/WICG/inert#tldr
>
> https://discourse.wicg.io/t/inert-attribute/1838/
>
> BUG=692360
> Review-Url: https://codereview.chromium.org/2088453002
> Cr-Commit-Position: refs/heads/master@{#474153}
> Committed: https://chromium.googlesource.com/chromium/src/+/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2

TBR=aboxhall@chromium.org,hayato@chromium.org,dglazkov@chromium.org,esprehn@chromium.org,dmazzoni@chromium.org,kochi@chromium.org
BUG=692360, 725815 

Review-Url: https://codereview.chromium.org/2902133002
Cr-Commit-Position: refs/heads/master@{#474259}

[modify] https://crrev.com/e353755ef5c7e109ddf2370ebacc39377924fc55/third_party/WebKit/LayoutTests/external/wpt/html/dom/elements/elements-in-the-dom/historical.html
[delete] https://crrev.com/a61ab21892d351e22b39b2a17c2b9948f6866525/third_party/WebKit/LayoutTests/fast/dom/inert/inert-does-not-match-disabled-selector.html
[delete] https://crrev.com/a61ab21892d351e22b39b2a17c2b9948f6866525/third_party/WebKit/LayoutTests/fast/dom/inert/inert-focus-in-frames.html
[delete] https://crrev.com/a61ab21892d351e22b39b2a17c2b9948f6866525/third_party/WebKit/LayoutTests/fast/dom/inert/inert-in-shadow-dom.html
[delete] https://crrev.com/a61ab21892d351e22b39b2a17c2b9948f6866525/third_party/WebKit/LayoutTests/fast/dom/inert/inert-inlines.html
[delete] https://crrev.com/a61ab21892d351e22b39b2a17c2b9948f6866525/third_party/WebKit/LayoutTests/fast/dom/inert/inert-label-focus.html
[delete] https://crrev.com/a61ab21892d351e22b39b2a17c2b9948f6866525/third_party/WebKit/LayoutTests/fast/dom/inert/inert-node-is-uneditable.html
[delete] https://crrev.com/a61ab21892d351e22b39b2a17c2b9948f6866525/third_party/WebKit/LayoutTests/fast/dom/inert/inert-node-is-unfocusable.html
[delete] https://crrev.com/a61ab21892d351e22b39b2a17c2b9948f6866525/third_party/WebKit/LayoutTests/fast/dom/inert/inert-node-is-unselectable.html
[delete] https://crrev.com/a61ab21892d351e22b39b2a17c2b9948f6866525/third_party/WebKit/LayoutTests/fast/dom/inert/resources/dialog-layout.css
[delete] https://crrev.com/a61ab21892d351e22b39b2a17c2b9948f6866525/third_party/WebKit/LayoutTests/fast/dom/inert/resources/inert-focus-in-frames-frame1.html
[modify] https://crrev.com/e353755ef5c7e109ddf2370ebacc39377924fc55/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodes-expected.txt
[modify] https://crrev.com/e353755ef5c7e109ddf2370ebacc39377924fc55/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodes.html
[add] https://crrev.com/e353755ef5c7e109ddf2370ebacc39377924fc55/third_party/WebKit/LayoutTests/platform/linux/inspector-protocol/accessibility/accessibility-ignoredNodes-expected.txt
[add] https://crrev.com/e353755ef5c7e109ddf2370ebacc39377924fc55/third_party/WebKit/LayoutTests/platform/win/inspector-protocol/accessibility/accessibility-ignoredNodes-expected.txt
[modify] https://crrev.com/e353755ef5c7e109ddf2370ebacc39377924fc55/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/e353755ef5c7e109ddf2370ebacc39377924fc55/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/e353755ef5c7e109ddf2370ebacc39377924fc55/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/e353755ef5c7e109ddf2370ebacc39377924fc55/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/e353755ef5c7e109ddf2370ebacc39377924fc55/third_party/WebKit/Source/core/dom/Node.h
[modify] https://crrev.com/e353755ef5c7e109ddf2370ebacc39377924fc55/third_party/WebKit/Source/core/dom/Text.cpp
[modify] https://crrev.com/e353755ef5c7e109ddf2370ebacc39377924fc55/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/e353755ef5c7e109ddf2370ebacc39377924fc55/third_party/WebKit/Source/core/html/HTMLAttributeNames.json5
[modify] https://crrev.com/e353755ef5c7e109ddf2370ebacc39377924fc55/third_party/WebKit/Source/core/html/HTMLElement.cpp
[modify] https://crrev.com/e353755ef5c7e109ddf2370ebacc39377924fc55/third_party/WebKit/Source/core/html/HTMLElement.idl
[modify] https://crrev.com/e353755ef5c7e109ddf2370ebacc39377924fc55/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js
[modify] https://crrev.com/e353755ef5c7e109ddf2370ebacc39377924fc55/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp
[modify] https://crrev.com/e353755ef5c7e109ddf2370ebacc39377924fc55/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h
[modify] https://crrev.com/e353755ef5c7e109ddf2370ebacc39377924fc55/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h
[modify] https://crrev.com/e353755ef5c7e109ddf2370ebacc39377924fc55/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
[modify] https://crrev.com/e353755ef5c7e109ddf2370ebacc39377924fc55/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h
[modify] https://crrev.com/e353755ef5c7e109ddf2370ebacc39377924fc55/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp
[modify] https://crrev.com/e353755ef5c7e109ddf2370ebacc39377924fc55/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h
[modify] https://crrev.com/e353755ef5c7e109ddf2370ebacc39377924fc55/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
[modify] https://crrev.com/e353755ef5c7e109ddf2370ebacc39377924fc55/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h
[modify] https://crrev.com/e353755ef5c7e109ddf2370ebacc39377924fc55/third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp
[modify] https://crrev.com/e353755ef5c7e109ddf2370ebacc39377924fc55/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
[modify] https://crrev.com/e353755ef5c7e109ddf2370ebacc39377924fc55/tools/metrics/histograms/enums.xml

Project Member

Comment 7 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58a3e83e1325c8a366941564ca8ce096bb1345df

commit 58a3e83e1325c8a366941564ca8ce096bb1345df
Author: aboxhall <aboxhall@chromium.org>
Date: Thu May 25 07:10:02 2017

Implement the inert attribute: https://github.com/WICG/inert#tldr

https://discourse.wicg.io/t/inert-attribute/1838/

BUG=692360

Review-Url: https://codereview.chromium.org/2088453002
Cr-Original-Commit-Position: refs/heads/master@{#474153}
Committed: https://chromium.googlesource.com/chromium/src/+/cca67d31f4a0b4ec2c20090a8bfc38c464274ab2
Review-Url: https://codereview.chromium.org/2088453002
Cr-Commit-Position: refs/heads/master@{#474598}

[modify] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/LayoutTests/LeakExpectations
[modify] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/LayoutTests/external/wpt/html/dom/elements/elements-in-the-dom/historical.html
[add] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/LayoutTests/fast/dom/inert/inert-does-not-match-disabled-selector.html
[add] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/LayoutTests/fast/dom/inert/inert-focus-in-frames.html
[add] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/LayoutTests/fast/dom/inert/inert-in-shadow-dom.html
[add] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/LayoutTests/fast/dom/inert/inert-inlines.html
[add] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/LayoutTests/fast/dom/inert/inert-label-focus.html
[add] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/LayoutTests/fast/dom/inert/inert-node-is-uneditable.html
[add] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/LayoutTests/fast/dom/inert/inert-node-is-unfocusable.html
[add] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/LayoutTests/fast/dom/inert/inert-node-is-unselectable.html
[add] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/LayoutTests/fast/dom/inert/resources/dialog-layout.css
[add] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/LayoutTests/fast/dom/inert/resources/inert-focus-in-frames-frame1.html
[modify] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodes-expected.txt
[modify] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodes.html
[delete] https://crrev.com/933dc3199a9418e3c5b1d14d681d976867e8e4f9/third_party/WebKit/LayoutTests/platform/linux/inspector-protocol/accessibility/accessibility-ignoredNodes-expected.txt
[delete] https://crrev.com/933dc3199a9418e3c5b1d14d681d976867e8e4f9/third_party/WebKit/LayoutTests/platform/win/inspector-protocol/accessibility/accessibility-ignoredNodes-expected.txt
[modify] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/Source/core/dom/Node.h
[modify] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/Source/core/dom/Text.cpp
[modify] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/Source/core/html/HTMLAttributeNames.json5
[modify] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/Source/core/html/HTMLElement.cpp
[modify] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/Source/core/html/HTMLElement.idl
[modify] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js
[modify] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp
[modify] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h
[modify] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h
[modify] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
[modify] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h
[modify] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp
[modify] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h
[modify] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
[modify] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h
[modify] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp
[modify] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
[modify] https://crrev.com/58a3e83e1325c8a366941564ca8ce096bb1345df/tools/metrics/histograms/enums.xml

Labels: -M-58 M-60

Comment 9 by owe...@chromium.org, Sep 12 2017

Labels: migrated-launch-owp Type-Task
This issue has been automatically relabelled type=task because type=launch-owp issues are now officially deprecated. The deprecation is because they were creating confusion about how to get launch approvals, which should be instead done via type=launch issues.

We recommend this issue be used for implementation tracking (for public visibility), but if you already have an issue for that, you may mark this as duplicate.

For more details see here: https://docs.google.com/document/d/1JA6RohjtZQc26bTrGoIE_bSXGXUDQz8vc6G0n_sZJ2o/edit

For any questions, please contact owencm, sshruthi, larforge
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fd5ad7ea2d63dc6cb9b8d5db35df7cf86789b8c

commit 9fd5ad7ea2d63dc6cb9b8d5db35df7cf86789b8c
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Wed Aug 08 01:16:00 2018

Add WPT tests for inert

Bug: 692360
Change-Id: Ie549ed3d33bd7f2cb7c5be070f931e29a2cb106b
Reviewed-on: https://chromium-review.googlesource.com/1139846
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Philip J├Ągenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581425}
[modify] https://crrev.com/9fd5ad7ea2d63dc6cb9b8d5db35df7cf86789b8c/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/9fd5ad7ea2d63dc6cb9b8d5db35df7cf86789b8c/third_party/WebKit/LayoutTests/external/wpt/dom/inert/inert-does-not-match-disabled-selector.html
[add] https://crrev.com/9fd5ad7ea2d63dc6cb9b8d5db35df7cf86789b8c/third_party/WebKit/LayoutTests/external/wpt/html/editing/focus/inert/inert-does-not-match-disabled-selector.html
[add] https://crrev.com/9fd5ad7ea2d63dc6cb9b8d5db35df7cf86789b8c/third_party/WebKit/LayoutTests/external/wpt/html/editing/focus/inert/inert-in-shadow-dom.html
[add] https://crrev.com/9fd5ad7ea2d63dc6cb9b8d5db35df7cf86789b8c/third_party/WebKit/LayoutTests/external/wpt/html/editing/focus/inert/inert-inlines.html
[add] https://crrev.com/9fd5ad7ea2d63dc6cb9b8d5db35df7cf86789b8c/third_party/WebKit/LayoutTests/external/wpt/html/editing/focus/inert/inert-label-focus.html
[add] https://crrev.com/9fd5ad7ea2d63dc6cb9b8d5db35df7cf86789b8c/third_party/WebKit/LayoutTests/external/wpt/html/editing/focus/inert/inert-node-is-uneditable.html
[add] https://crrev.com/9fd5ad7ea2d63dc6cb9b8d5db35df7cf86789b8c/third_party/WebKit/LayoutTests/external/wpt/html/editing/focus/inert/inert-node-is-unfocusable.html
[add] https://crrev.com/9fd5ad7ea2d63dc6cb9b8d5db35df7cf86789b8c/third_party/WebKit/LayoutTests/external/wpt/html/editing/focus/inert/inert-node-is-unselectable.html

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bf523b1e10aa27c631906f70f7b3153d7390b83

commit 5bf523b1e10aa27c631906f70f7b3153d7390b83
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Thu Aug 30 01:43:21 2018

Move inert tests to top level directory and rename with .tentative

Remove duplicate test which ended up in editing/focus/inert.

Bug: 692360
Change-Id: I25571a7e731cd8ce5f1fce85e9d246939b78690b
Reviewed-on: https://chromium-review.googlesource.com/1168267
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Philip J├Ągenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587399}
[modify] https://crrev.com/5bf523b1e10aa27c631906f70f7b3153d7390b83/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/b41c6ba8f62374e6516d6582f552749252674a25/third_party/WebKit/LayoutTests/external/wpt/html/editing/focus/inert/inert-does-not-match-disabled-selector.html
[rename] https://crrev.com/5bf523b1e10aa27c631906f70f7b3153d7390b83/third_party/WebKit/LayoutTests/external/wpt/inert/inert-does-not-match-disabled-selector.tentative.html
[rename] https://crrev.com/5bf523b1e10aa27c631906f70f7b3153d7390b83/third_party/WebKit/LayoutTests/external/wpt/inert/inert-in-shadow-dom.tentative.html
[rename] https://crrev.com/5bf523b1e10aa27c631906f70f7b3153d7390b83/third_party/WebKit/LayoutTests/external/wpt/inert/inert-inlines.tentative.html
[rename] https://crrev.com/5bf523b1e10aa27c631906f70f7b3153d7390b83/third_party/WebKit/LayoutTests/external/wpt/inert/inert-label-focus.tentative.html
[rename] https://crrev.com/5bf523b1e10aa27c631906f70f7b3153d7390b83/third_party/WebKit/LayoutTests/external/wpt/inert/inert-node-is-uneditable.tentative.html
[rename] https://crrev.com/5bf523b1e10aa27c631906f70f7b3153d7390b83/third_party/WebKit/LayoutTests/external/wpt/inert/inert-node-is-unfocusable.tentative.html
[rename] https://crrev.com/5bf523b1e10aa27c631906f70f7b3153d7390b83/third_party/WebKit/LayoutTests/external/wpt/inert/inert-node-is-unselectable.tentative.html

Sign in to add a comment