New issue
Advanced search Search tips

Issue 692357 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 248653



Sign in to add a comment

window_features.mojom.h flake on Google Chrome ChromeOS

Project Member Reported by scottmg@chromium.org, Feb 15 2017

Issue description

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/29370/steps/compile/logs/stdio

[14576/33431] CXX obj/components/ntp_tiles/ntp_tiles/field_trial.o
[14577/33431] CXX obj/chrome/browser/chromeos/printing/printing/printers_manager_factory.o
FAILED: obj/chrome/browser/chromeos/printing/printing/printers_manager_factory.o 
/b/c/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/browser/chromeos/printing/printing/printers_manager_factory.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DENABLE_WAYLAND_SERVER=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DOFFICIAL_BUILD -DGOOGLE_CHROME_BUILD -DENABLE_MEDIA_ROUTER=1 -DCR_CLANG_REVISION=\"289944-2\" -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNO_UNWIND_TABLES -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DOS_CHROMEOS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -I../.. -Igen -I../../build/linux/ubuntu_precise_amd64-sysroot/usr/include/glib-2.0 -I../../build/linux/ubuntu_precise_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../third_party/khronos -I../../gpu -I../../build/linux/ubuntu_precise_amd64-sysroot/usr/include/dbus-1.0 -I../../build/linux/ubuntu_precise_amd64-sysroot/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -fno-strict-aliasing -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -fdebug-prefix-map=/b/c/b/Google_Chrome_ChromeOS/src=. -m64 -march=x86-64 -pthread -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-block-capture-autoreleasing -O2 -fno-ident -fdata-sections -ffunction-sections -g2 --sysroot=../../build/linux/ubuntu_precise_amd64-sysroot -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -fvisibility-inlines-hidden -std=gnu++11 -Wno-reserved-user-defined-literal -fno-rtti -fno-exceptions -c ../../chrome/browser/chromeos/printing/printers_manager_factory.cc -o obj/chrome/browser/chromeos/printing/printing/printers_manager_factory.o
In file included from ../../chrome/browser/chromeos/printing/printers_manager_factory.cc:14:
In file included from ../../chrome/browser/profiles/profile.h:18:
../../content/public/browser/content_browser_client.h:36:10: fatal error: 'third_party/WebKit/public/web/window_features.mojom.h' file not found
#include "third_party/WebKit/public/web/window_features.mojom.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.


At first glance, content/public/browser has a public_deps of third_party/WebKit/public:mojo_bindings, so I'm not immediately sure why that file's not generated.
 
Might actually be due to https://codereview.chromium.org/2695133002/, need to set up a CrOS build to check that.

Comment 2 by skau@chromium.org, Feb 15 2017

I can't seem to replicate this failure.  What configuration is that buildbot using?
From https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/29370/steps/generate_build_files/logs/stdio

Writing """\
goma_dir = "/b/c/cipd/goma"
is_chrome_branded = true
is_debug = false
is_official_build = true
target_os = "chromeos"
use_goma = true
""" to /b/c/b/Google_Chrome_ChromeOS/src/out/Release/args.gn.

I haven't tried to make specific repro myself yet.
Status: WontFix (was: Assigned)
https://codereview.chromium.org/2695133002/ was reverted, so I will WontFix this until/unless it happens again.

Sign in to add a comment