"CrSettingsLanguagesTest.Languages" is flaky |
|||||
Issue description"CrSettingsLanguagesTest.Languages" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 7 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLAsSBUZsYWtlIiFDclNldHRpbmdzTGFuZ3VhZ2VzVGVzdC5MYW5ndWFnZXMM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Feb 15 2017
,
Feb 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b1c1e4ac1c6f5dc92f861554448c85c037556d6 commit 5b1c1e4ac1c6f5dc92f861554448c85c037556d6 Author: perkj <perkj@chromium.org> Date: Wed Feb 15 10:22:29 2017 Disabled flakey test CrSettingsLanguagesTest.Languages The test has been flaky on Win and Linux. BUG= 692356 TBR=dbeam@chromium.org Review-Url: https://codereview.chromium.org/2695213002 Cr-Commit-Position: refs/heads/master@{#450650} [modify] https://crrev.com/5b1c1e4ac1c6f5dc92f861554448c85c037556d6/chrome/test/data/webui/settings/cr_settings_browsertest.js
,
Mar 23 2017
,
Apr 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc1c102b111b5107384ff8a2cbf806870966a49c commit bc1c102b111b5107384ff8a2cbf806870966a49c Author: dpapad <dpapad@chromium.org> Date: Sat Apr 15 01:41:46 2017 MD Settings: Make disabled CrSettingsLanguagesTest.Languages succeed locally. This is the 1st step of deflaking and eventually re-enabling those tests. Since they have been fully disabled for a while, the change made at https://codereview.chromium.org/2779873003 (after the tests were disabled), causes the tests to always fail (<settings-languages> initialization moved from created() to attached()). This CL does not re-enable those tests, because there is more work to get there (for example using a test browser proxy) BUG= 692356 Review-Url: https://codereview.chromium.org/2819053002 Cr-Commit-Position: refs/heads/master@{#464846} [modify] https://crrev.com/bc1c102b111b5107384ff8a2cbf806870966a49c/chrome/test/data/webui/settings/languages_tests.js
,
Apr 17 2017
,
Apr 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb8e8df2be632be5824072b96b3159bc2dacbab3 commit eb8e8df2be632be5824072b96b3159bc2dacbab3 Author: dpapad <dpapad@chromium.org> Date: Wed Apr 19 17:45:26 2017 MD Settings: Languages; limit platform specific code to the respective platform. languages_page.js has a lot of platform specific code, but it was not properly marked, so it was being included in unrelated platforms. This CLs cleans up the code such that is only included in the platforms that it is actually used. - chromeos - chromeos or is_win - not is_macosx This is a step towards deflaking/re-enabling the corresponding tests(for example this makes it clear which platforms need a browser proxy abstraction). BUG= 692356 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2822863002 Cr-Commit-Position: refs/heads/master@{#465662} [modify] https://crrev.com/eb8e8df2be632be5824072b96b3159bc2dacbab3/chrome/browser/resources/settings/languages_page/languages.js [modify] https://crrev.com/eb8e8df2be632be5824072b96b3159bc2dacbab3/chrome/browser/resources/settings/languages_page/languages_page.js [modify] https://crrev.com/eb8e8df2be632be5824072b96b3159bc2dacbab3/chrome/browser/resources/settings/languages_page/languages_types.js [modify] https://crrev.com/eb8e8df2be632be5824072b96b3159bc2dacbab3/chrome/browser/ui/webui/settings/languages_handler.cc [modify] https://crrev.com/eb8e8df2be632be5824072b96b3159bc2dacbab3/chrome/browser/ui/webui/settings/md_settings_ui.cc
,
Apr 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a1f5619eb05b1d0833c061edd68e7294878604e commit 3a1f5619eb05b1d0833c061edd68e7294878604e Author: dpapad <dpapad@chromium.org> Date: Thu Apr 20 01:41:34 2017 MD Settings: Use a browser proxy from the languages page. Re-enable test. - Add a languages_browser_proxy.js - Put chrome.send, languageSettingsPrivate and inputMethodsPrivate behind the proxy. - Use the proxy to interact with the browser (both chrome.send and private APIs). - Implement a fake InputMethodPrivate API and update tests to use it (previously tests had been calling to the prod chrome.inputMethodPrivate API). - Re-enable CrSettingsLanguagesTest.Languages. BUG= 692356 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2827553002 Cr-Commit-Position: refs/heads/master@{#465853} [modify] https://crrev.com/3a1f5619eb05b1d0833c061edd68e7294878604e/chrome/browser/resources/settings/languages_page/compiled_resources2.gyp [modify] https://crrev.com/3a1f5619eb05b1d0833c061edd68e7294878604e/chrome/browser/resources/settings/languages_page/languages.html [modify] https://crrev.com/3a1f5619eb05b1d0833c061edd68e7294878604e/chrome/browser/resources/settings/languages_page/languages.js [add] https://crrev.com/3a1f5619eb05b1d0833c061edd68e7294878604e/chrome/browser/resources/settings/languages_page/languages_browser_proxy.html [add] https://crrev.com/3a1f5619eb05b1d0833c061edd68e7294878604e/chrome/browser/resources/settings/languages_page/languages_browser_proxy.js [modify] https://crrev.com/3a1f5619eb05b1d0833c061edd68e7294878604e/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/3a1f5619eb05b1d0833c061edd68e7294878604e/chrome/test/data/webui/settings/cr_settings_browsertest.js [add] https://crrev.com/3a1f5619eb05b1d0833c061edd68e7294878604e/chrome/test/data/webui/settings/fake_input_method_private.js [modify] https://crrev.com/3a1f5619eb05b1d0833c061edd68e7294878604e/chrome/test/data/webui/settings/languages_tests.js
,
Apr 20 2017
CrSettingsLanguagesTest.Languages has not flaked at all since it was re-enabled yesterday, see [1]. I am closing this issue for now. [1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=CrSettingsLanguagesTest.Languages |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by perkj@chromium.org
, Feb 15 2017