New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 692351 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

[TTS] Client control for a server-side experiment

Project Member Reported by donnd@chromium.org, Feb 15 2017

Issue description

We're rolling out an update to the Contextual Search server, but need a client switch to control it and evaluate its impact on client usage.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/917adcfaa04e622273c5a64694fa578e03ac58ff

commit 917adcfaa04e622273c5a64694fa578e03ac58ff
Author: donnd <donnd@chromium.org>
Date: Thu Feb 16 00:48:10 2017

[TTS] Add server control from a field_trial param.

Add support to set the contextual cards integration version
explictly from a field trial param.

This will let us control a server-side feature from the field
trial config and evaluate client usage differences.

BUG= 692351 

Review-Url: https://codereview.chromium.org/2697513005
Cr-Commit-Position: refs/heads/master@{#450845}

[modify] https://crrev.com/917adcfaa04e622273c5a64694fa578e03ac58ff/chrome/browser/android/contextualsearch/contextual_search_delegate.cc
[modify] https://crrev.com/917adcfaa04e622273c5a64694fa578e03ac58ff/chrome/browser/android/contextualsearch/contextual_search_field_trial.cc
[modify] https://crrev.com/917adcfaa04e622273c5a64694fa578e03ac58ff/chrome/browser/android/contextualsearch/contextual_search_field_trial.h

Comment 2 by donnd@chromium.org, Feb 17 2017

Labels: Merge-Request-57
We'd like to merge this change to M-57 to allow us to do a server experiment under client control in the upcoming cycle.  It's a small safe change that just affects Contextual Search, but not strictly required for M-57.
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 17 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 17 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83cfdcf158a2ce8f9efa5ad68a69dd2e4455cc9e

commit 83cfdcf158a2ce8f9efa5ad68a69dd2e4455cc9e
Author: Donn Denman <donnd@google.com>
Date: Fri Feb 17 17:35:16 2017

[TTS] Add server control from a field_trial param.

Add support to set the contextual cards integration version
explictly from a field trial param.

This will let us control a server-side feature from the field
trial config and evaluate client usage differences.

BUG= 692351 

Review-Url: https://codereview.chromium.org/2697513005
Cr-Commit-Position: refs/heads/master@{#450845}
(cherry picked from commit 917adcfaa04e622273c5a64694fa578e03ac58ff)

Review-Url: https://codereview.chromium.org/2700943004 .
Cr-Commit-Position: refs/branch-heads/2987@{#576}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/83cfdcf158a2ce8f9efa5ad68a69dd2e4455cc9e/chrome/browser/android/contextualsearch/contextual_search_delegate.cc
[modify] https://crrev.com/83cfdcf158a2ce8f9efa5ad68a69dd2e4455cc9e/chrome/browser/android/contextualsearch/contextual_search_field_trial.cc
[modify] https://crrev.com/83cfdcf158a2ce8f9efa5ad68a69dd2e4455cc9e/chrome/browser/android/contextualsearch/contextual_search_field_trial.h

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d9a101aacc4bc19bb2082a050ae2604fd368b85

commit 2d9a101aacc4bc19bb2082a050ae2604fd368b85
Author: donnd <donnd@chromium.org>
Date: Thu Mar 02 03:31:48 2017

[TTS] Update Test config for server experiment.

Adds sending the client-controlled experiment flag for the
current experiment (use "First Coca Card") so that gets test
coverage and is enabled for developer builds.

BUG= 692351 

Review-Url: https://codereview.chromium.org/2724983002
Cr-Commit-Position: refs/heads/master@{#454164}

[modify] https://crrev.com/2d9a101aacc4bc19bb2082a050ae2604fd368b85/testing/variations/fieldtrial_testing_config.json

Comment 6 by donnd@chromium.org, Mar 6 2017

Status: Fixed (was: Started)

Sign in to add a comment