New issue
Advanced search Search tips

Issue 692335 link

Starred by 1 user
Status: Fixed
Owner:
jeffcarp@chromium.org
Closed: Feb 2017
Cc:
tkent@chromium.org
qyears...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

wpt-import fails with TypeError: coercing to Unicode: need string or buffer, memoized found

Project Member Reported by falken@chromium.org, Feb 15 2017 
I'm trying to roll wpt.

$ third_party/WebKit/Tools/Scripts/wpt-import wpt
Cloning repo: https://chromium.googlesource.com/external/w3c/web-platform-tests.git
Local path: /work/chrome/src/third_party/WebKit/wpt
Traceback (most recent call last):
  File "third_party/WebKit/Tools/Scripts/wpt-import", line 17, in <module>
    host.exit(importer.main())
  File "/work/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 79, in main
    commits = self.exportable_but_not_exported_commits(temp_repo_path)
  File "/work/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 165, in exportable_but_not_exported_commits
    _, chromium_commit = local_wpt.most_recent_chromium_commit()
  File "/work/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py", line 61, in most_recent_chromium_commit
    chromium_commit = ChromiumCommit(self.host, position=position)
  File "/work/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py", line 31, in __init__
    sha = self.position_to_sha(position)
  File "/work/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py", line 51, in position_to_sha
    ], cwd=absolute_chromium_dir).strip()
  File "/work/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 340, in run_command
    close_fds=self._should_close_fds())
  File "/work/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 413, in popen
    return subprocess.Popen(string_args, **kwargs)
  File "/usr/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
TypeError: coercing to Unicode: need string or buffer, memoized found

Comment 1 by jeffcarp@chromium.org, Feb 15 2017 

This was my mistake - a CL to fix it should be landing soon or have already landed. Let me check (currently on mobile)

Can you try on ToT?

Comment 2 by jeffcarp@chromium.org, Feb 15 2017

Owner: jeffcarp@chromium.org
Status: Started (was: Untriaged)
It's in the CQ. Apologies for the disruption.
https://codereview.chromium.org/2690343003

Comment 3 by jeffcarp@chromium.org, Feb 15 2017 

This should be fixed now. Can you verify?

Comment 4 by qyears...@chromium.org, Feb 15 2017

Status: Fixed (was: Started)
Behavior now is:

$ third_party/WebKit/Tools/Scripts/wpt-import wpt
Cloning repo: https://chromium.googlesource.com/external/w3c/web-platform-tests.git
Local path: /usr/local/google/home/qyearsley/chromium/src/third_party/WebKit/wpt
There were exportable but not-yet-exported commits:
  https://chromium.googlesource.com/chromium/src/+/a97d64509b72ffc3f69ab86d57b2d45536a8b60f
Aborting import to prevent clobbering these commits.
Deleting temp repo directory /usr/local/google/home/qyearsley/chromium/src/third_party/WebKit/wpt.


That is, this particular error is fixed, but if you want to run the wpt-import script now, you must add the flag --ignore-exportable-commits, and then after importing, locally revert any changes which conflict with r450654.

Comment 5 by falken@chromium.org, Feb 16 2017 

Yes, I see the same thing as comment 4.

Comment 6 by foolip@chromium.org, Jul 3 2017

Components: Blink>Infra>Ecosystem

Comment 7 by foolip@chromium.org, Jul 3 2017

Components: -Blink>Infra>Predictability
►

Sign in to add a comment