Issue 692334 link

Starred by 2 users

Issue metadata

Status:	Verified
Owner:	steve...@chromium.org
Closed:	Feb 2017
Cc:	tommycli@chromium.org █ rookrishna@chromium.org tbuck...@chromium.org █ tdander...@chromium.org bettes@chromium.org dhadd...@chromium.org steve...@chromium.org jdufault@chromium.org abod...@chromium.org dpa...@chromium.org
Components:	UI>Settings
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Bug
M-58

Blocking:
issue 684849

Audit status area links to settings pages

Project Member Reported by steve...@chromium.org, Feb 15 2017

Issue description

We need to make sure that all settings links in the status area open the correct page or subpage.

Tom/Allen - Is the desired behavior for settings with subpages like Bluetooth and Display is to open the subpage instead of just scroll to the top level section?

Here are status area pages with potential settings links:
* IME
* Bluetooth
* Internet
* VPN
* Stylus
* A11y
*

Comment 1 by steve...@chromium.org, Feb 15 2017

* IME - Goes to "Languages and input" section, which seems correct since they expand.
* Bluetooth: Goes to section, -> subpage.
* Internet: Goes to section (correct)
* VPN: Goes to Internet, correct for now (will eventually go to VPN subpage when  issue 673944  is complete)
* Stylus: Goes to main page -> Go to stylus subpage
* A11y: Goes to section (correct)

We also have these links from notifications, which are correct:
* Display: Goes to display subpage
* Date & Time: Goes to Date and time section (correct)
* Power: Currently goes to main page -> Go to device section (will eventually go to power subpage when  issue 633455  is completed)
* Language: Goes to "Languages and input" section (correct)

Comment 2 by steve...@chromium.org, Feb 15 2017

Cc: rookrishna@chromium.org abod...@chromium.org jdufault@chromium.org steve...@chromium.org dhadd...@chromium.org tdander...@chromium.org

 Issue 691036  has been merged into this issue.

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9197c8376975f8d99d785f2ed0190ccf4758c578

commit 9197c8376975f8d99d785f2ed0190ccf4758c578
Author: stevenjb <stevenjb@chromium.org>
Date: Fri Feb 17 00:00:43 2017

MD Settings: Fix subpage URLS for CrOS

This includes some consistency cleanup for url names, and a few
changes to maintain compatability with current/old settings.

BUG= 692334 

Review-Url: https://codereview.chromium.org/2697723006
Cr-Commit-Position: refs/heads/master@{#451144}

[modify] https://crrev.com/9197c8376975f8d99d785f2ed0190ccf4758c578/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
[modify] https://crrev.com/9197c8376975f8d99d785f2ed0190ccf4758c578/chrome/browser/browser_about_handler.cc
[modify] https://crrev.com/9197c8376975f8d99d785f2ed0190ccf4758c578/chrome/browser/ui/ash/system_tray_client.cc
[modify] https://crrev.com/9197c8376975f8d99d785f2ed0190ccf4758c578/chrome/browser/ui/chrome_pages.cc
[modify] https://crrev.com/9197c8376975f8d99d785f2ed0190ccf4758c578/chrome/browser/ui/webui/bidi_checker_web_ui_test.cc
[modify] https://crrev.com/9197c8376975f8d99d785f2ed0190ccf4758c578/chrome/common/url_constants.cc
[modify] https://crrev.com/9197c8376975f8d99d785f2ed0190ccf4758c578/chrome/common/url_constants.h

Comment 4 by steve...@chromium.org, Feb 17 2017

Status: Fixed (was: Started)

Comment 5 by abod...@chromium.org, Feb 21 2017

Status: Verified (was: Fixed)

ChromeOs:9304.0.0/Chrome:58.0.3015.0

►

Issue 692334 link

Issue metadata

Audit status area links to settings pages

Issue description

Comment 1 by steve...@chromium.org, Feb 15 2017

Comment 1 Deleted

Comment 2 by steve...@chromium.org, Feb 15 2017

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Feb 17 2017

Comment 3 Deleted

Comment 4 by steve...@chromium.org, Feb 17 2017

Comment 4 Deleted

Comment 5 by abod...@chromium.org, Feb 21 2017

Comment 5 Deleted

Sign in to add a comment