New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 692324 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

mash: Check failure in WindowTreeClient for Quick Launch on root process teardown

Project Member Reported by jamescook@chromium.org, Feb 15 2017

Issue description

chrome ToT on linux desktop
Run chrome --mash
Kill content_browser, which makes the root chrome --mash exit

[2113:2113:0214/171937.812882:961643431047:FATAL:window_tree_client.cc(341)] Check failed: !change->window() || windows_.count(change->window()->server_id()) > 0. 
#0 0x7f4c5ebc9cb7 base::debug::StackTrace::StackTrace()
#1 0x7f4c5ebeaeea logging::LogMessage::~LogMessage()
#2 0x7f4c5a15bc28 aura::WindowTreeClient::ScheduleInFlightChange()
#3 0x7f4c5a15e5fc aura::WindowTreeClient::OnWindowMusRemoveChild()
#4 0x7f4c5a169bc7 aura::Window::~Window()
#5 0x7f4c5a16a2c9 aura::Window::~Window()
#6 0x7f4c5a15a618 aura::WindowTreeClient::~WindowTreeClient()
#7 0x7f4c5a15ade9 aura::WindowTreeClient::~WindowTreeClient()
#8 0x7f4c59654b07 views::MusClient::~MusClient()
#9 0x7f4c59654d29 views::MusClient::~MusClient()
#10 0x7f4c5964b5bf views::AuraInit::~AuraInit()
#11 0x7f4c6003fce1 mash::quick_launch::QuickLaunch::~QuickLaunch()
#12 0x7f4c6003fd79 mash::quick_launch::QuickLaunch::~QuickLaunch()
#13 0x7f4c60b9ca83 service_manager::ServiceContext::~ServiceContext()
#14 0x7f4c60b9cab9 service_manager::ServiceContext::~ServiceContext()
#15 0x7f4c60033214 mash::MashPackagedService::~MashPackagedService()
#16 0x7f4c60b9ca83 service_manager::ServiceContext::~ServiceContext()
#17 0x7f4c5f7e2cd2 MashRunner::StartChildApp()
#18 0x7f4c5f7e424c _ZN4base8internal7InvokerINS0_9BindStateIM10MashRunnerFvN4mojo16InterfaceRequestIN15service_manager5mojom7ServiceEEEEJNS0_17UnretainedWrapperIS3_EEEEEFvS9_EE3RunEPNS0_13BindStateBaseEOS9_
#19 0x7f4c600b1790 service_manager::RunStandaloneService()
#20 0x7f4c5f7e1e47 MashRunner::RunChild()
#21 0x7f4c5f7e1d65 MashRunner::Run()
#22 0x7f4c5f7e2d6c MashMain()
#23 0x7f4c5f7e0240 ChromeMain
#24 0x7f4c55d9ef45 __libc_start_main
#25 0x7f4c5f7e00bd <unknown>

Maybe this needs some kind of code path to trigger an exit if its window is torn down?

 

Comment 1 by sky@chromium.org, Feb 15 2017

Owner: sky@chromium.org
Status: Started (was: Untriaged)
Based on the stack this happens in the case of a leak. Jonathan recently converted the attempt at cleanup to a CHECK. I have no doubt the quick launch isn't deleting the widget it creates in the case of shutdown.
Cc: jonr...@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32e074e42207bf161510aba4c4b5539d0818d2f1

commit 32e074e42207bf161510aba4c4b5539d0818d2f1
Author: sky <sky@chromium.org>
Date: Wed Feb 15 21:50:22 2017

chromeos: Makes ~QuickLaunch delete widgets

BUG= 692324 
TEST=none
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2691363004
Cr-Commit-Position: refs/heads/master@{#450815}

[modify] https://crrev.com/32e074e42207bf161510aba4c4b5539d0818d2f1/mash/quick_launch/quick_launch.cc

Comment 4 by sky@chromium.org, Feb 15 2017

Status: Fixed (was: Started)

Comment 5 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 6 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 8 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment