Issue metadata
Sign in to add a comment
|
Search engines documentation does not match code |
||||||||||||||||||
Issue descriptionThe documentation on https://developer.chrome.com/extensions/settings_override#search_provider is not correct. For example, the "short_name" field for search engines is not documented here, but is required by the code to accept an entry (see https://cs.chromium.org/chromium/src/components/search_engines/template_url_data_util.cc?l=27 ). Other documentation, such as whether certain fields are optional if "prepopulate_id" is specified, also does not match the code. I don't know whether this is a documentation bug or a code bug, but the two need to be brought into sync. Not sure if this is the right venue for this.
,
Feb 17 2017
Well, that's an interesting function. I wasn't aware that this "preprocessing" step occurred. Good to know. That resolves both issues I cited, as if there's a prepopulate ID, we use the prepopulate data for all the initial values and just overwrite them. Is this codepath also traversed for cases where people set search engines by policy? If not, that should also be checked to see if the documentation and code match. I don't know if you know where that is. Feel free to morph or close this as appropriate.
,
Feb 17 2017
I don't know much about setting search engines by policy - I think they're fairly different paths. bartfab@ or atwilson@ might know more (or know who would). I think that documentation is somewhere around here: http://dev.chromium.org/administrators/policy-list-3#DefaultSearchProvider All search engines set through extensions (or transitively through policy-installed extensions) would go through this path. Remove extensions component, since it seems like the extensions side is okay. (I can't find a policy component to replace it with, strangely...)
,
Jan 10
Downgrading P2s that haven't been modified in more than 6 months, which have no component or owner. |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by rdevlin....@chromium.org
, Feb 17 2017