New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 692289 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 634270



Sign in to add a comment

Mark more EME APIs using SecureContext

Project Member Reported by xhw...@chromium.org, Feb 15 2017

Issue description

This is a followup of  issue 672605 . 

Today some EME APIs were marked using SecureContext:
- requestMediaKeySystemAccess
- setMediaKeys
- MediaKeys interface

Based on the EME spec, we should mark all EME APIs using SecureContext. Today this is not possible due to some implementation limitations around SecureContext. See https://chromiumcodereview.appspot.com/2651413002/ for discussions.

This issue will track the remaining work of marking EME APIs using SecureContext.


 
Labels: EME-compat
Note that there are a couple things that are exposed to insecure contexts in the spec. See https://github.com/w3c/encrypted-media/issues/289 and https://github.com/w3c/encrypted-media/pull/294.

Comment 2 by xhw...@chromium.org, Jun 14 2017

Owner: xhw...@chromium.org
Labels: M-67
Status: Assigned (was: Available)

Comment 4 by xhw...@chromium.org, Mar 23 2018

Labels: -M-67 M-68
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4aa5b9723da8be74457f17c108e63465b79a77f4

commit 4aa5b9723da8be74457f17c108e63465b79a77f4
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Sun Apr 29 06:21:02 2018

media: Mark more EME APIs with SecureContext

Previously this was only partially done due to  issue 634270 . Now that
issue has been fixed and we can mark more EME APIs with SecureContext.

In the current EME spec, there are 9 APIs marked with SecureContext.
This CL makes sure all of them are marked with SecureContext in Blink
IDL.

Also mark getStatusForPolicy() (not in EME spec yet) with SecureContext.

Bug:  692289 
Test: Manually tested and verified no MediaKey* exposed in http://
Change-Id: If976d30b3371c4be2bcd33ab61268f21145232a1
Reviewed-on: https://chromium-review.googlesource.com/1030760
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554666}
[modify] https://crrev.com/4aa5b9723da8be74457f17c108e63465b79a77f4/third_party/blink/renderer/modules/encryptedmedia/html_media_element_encrypted_media.idl
[modify] https://crrev.com/4aa5b9723da8be74457f17c108e63465b79a77f4/third_party/blink/renderer/modules/encryptedmedia/media_key_message_event.idl
[modify] https://crrev.com/4aa5b9723da8be74457f17c108e63465b79a77f4/third_party/blink/renderer/modules/encryptedmedia/media_key_session.idl
[modify] https://crrev.com/4aa5b9723da8be74457f17c108e63465b79a77f4/third_party/blink/renderer/modules/encryptedmedia/media_key_status_map.idl
[modify] https://crrev.com/4aa5b9723da8be74457f17c108e63465b79a77f4/third_party/blink/renderer/modules/encryptedmedia/media_key_system_access.idl
[modify] https://crrev.com/4aa5b9723da8be74457f17c108e63465b79a77f4/third_party/blink/renderer/modules/encryptedmedia/media_keys_get_status_for_policy.idl

Comment 6 by xhw...@chromium.org, Apr 30 2018

Status: Fixed (was: Assigned)

Sign in to add a comment