When we run tests without setting bootstrap variables, we will run into NotBootstrappedError when we want to upload test results through logdog.
This makes it difficult for sherrifs if not other people, see for example https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FAndroid_Tests%2F38566%2F%2B%2Frecipes%2Fsteps%2Fchrome_public_test_apk_on_Android%2F0%2Fstdout
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de2df28c86b13227040aba5f9f5a1d1f869b81eb commit de2df28c86b13227040aba5f9f5a1d1f869b81eb Author: hzl <hzl@google.com> Date: Wed Mar 15 03:14:52 2017 Use logdog butler subcommand to run tests. Previously we ran tests, without setting butler environment variables. This will run into NotBootstrappedError when we try to upload test results through logdog. In this cl, we use logdog butler subcommand to run tests, which will set butler environment variables before hand. BUG= 692287 Review-Url: https://codereview.chromium.org/2695963003 Cr-Commit-Position: refs/heads/master@{#456976} [modify] https://crrev.com/de2df28c86b13227040aba5f9f5a1d1f869b81eb/PRESUBMIT.py [modify] https://crrev.com/de2df28c86b13227040aba5f9f5a1d1f869b81eb/build/android/BUILD.gn [modify] https://crrev.com/de2df28c86b13227040aba5f9f5a1d1f869b81eb/build/android/test_runner.py [modify] https://crrev.com/de2df28c86b13227040aba5f9f5a1d1f869b81eb/build/android/test_wrapper/logdog_wrapper.py [add] https://crrev.com/de2df28c86b13227040aba5f9f5a1d1f869b81eb/build/android/test_wrapper/logdog_wrapper.pydeps [modify] https://crrev.com/de2df28c86b13227040aba5f9f5a1d1f869b81eb/build/config/android/internal_rules.gni [modify] https://crrev.com/de2df28c86b13227040aba5f9f5a1d1f869b81eb/testing/buildbot/chromium.android.json [modify] https://crrev.com/de2df28c86b13227040aba5f9f5a1d1f869b81eb/testing/buildbot/chromium.linux.json [modify] https://crrev.com/de2df28c86b13227040aba5f9f5a1d1f869b81eb/tools/mb/mb.py
de2df28c86b13227040aba5f9f5a1d1f869b81eb caused breakage of the android_optional_gpu_tests_rel tryserver in Issue 701625 . Consequently I'm adding it to the CQ_INCLUDE_TRYBOTS for this directory.
Which directory do you mean? //build/android/?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21e01b56c633426f1a1b73f09405298963dc9d6d commit 21e01b56c633426f1a1b73f09405298963dc9d6d Author: ynovikov <ynovikov@chromium.org> Date: Wed Mar 15 18:54:45 2017 Update logdog butler revision on GPU.FYI bots BUG= 692287 TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2749193005 Cr-Commit-Position: refs/heads/master@{#457153} [modify] https://crrev.com/21e01b56c633426f1a1b73f09405298963dc9d6d/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/21e01b56c633426f1a1b73f09405298963dc9d6d/testing/buildbot/chromium.gpu.fyi.json
Linked to wrong bug accidentally.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d58d09ff7ef678920db1110ae5a0230f7d7cdb52 commit d58d09ff7ef678920db1110ae5a0230f7d7cdb52 Author: hzl <hzl@google.com> Date: Wed Mar 15 23:15:35 2017 Revert of Use logdog butler subcommand to run tests. (patchset #42 id:820001 of https://codereview.chromium.org/2695963003/ ) Reason for revert: Increases time by a great deal. Original issue's description: > Use logdog butler subcommand to run tests. > > Previously we ran tests, without setting butler environment variables. > This will run into NotBootstrappedError when we try to upload test > results through logdog. > > In this cl, we use logdog butler subcommand to run tests, which will set > butler environment variables before hand. > > BUG= 692287 > > Review-Url: https://codereview.chromium.org/2695963003 > Cr-Commit-Position: refs/heads/master@{#456976} > Committed: https://chromium.googlesource.com/chromium/src/+/de2df28c86b13227040aba5f9f5a1d1f869b81eb TBR=mikecase@chromium.org,dnj@chromium.org,jbudorick@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 692287 Review-Url: https://codereview.chromium.org/2749643008 Cr-Commit-Position: refs/heads/master@{#457257} [modify] https://crrev.com/d58d09ff7ef678920db1110ae5a0230f7d7cdb52/PRESUBMIT.py [modify] https://crrev.com/d58d09ff7ef678920db1110ae5a0230f7d7cdb52/build/android/BUILD.gn [modify] https://crrev.com/d58d09ff7ef678920db1110ae5a0230f7d7cdb52/build/android/test_runner.py [modify] https://crrev.com/d58d09ff7ef678920db1110ae5a0230f7d7cdb52/build/android/test_wrapper/logdog_wrapper.py [delete] https://crrev.com/3a8dda52afa9518898222bf0781add1243e2a33e/build/android/test_wrapper/logdog_wrapper.pydeps [modify] https://crrev.com/d58d09ff7ef678920db1110ae5a0230f7d7cdb52/build/config/android/internal_rules.gni [modify] https://crrev.com/d58d09ff7ef678920db1110ae5a0230f7d7cdb52/testing/buildbot/chromium.android.json [modify] https://crrev.com/d58d09ff7ef678920db1110ae5a0230f7d7cdb52/testing/buildbot/chromium.linux.json [modify] https://crrev.com/d58d09ff7ef678920db1110ae5a0230f7d7cdb52/tools/mb/mb.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ad3437632699fb98fdd46a3ba6ad8d63cf10ee5 commit 1ad3437632699fb98fdd46a3ba6ad8d63cf10ee5 Author: hzl <hzl@google.com> Date: Tue Mar 21 00:58:23 2017 (Reland) Use logdog butler subcommand to run tests. Previously we ran tests, without setting butler environment variables. This will run into NotBootstrappedError when we try to upload test results through logdog. In this cl, we use logdog butler subcommand to run tests, which will set butler environment variables before hand. BUG= 692287 Review-Url: https://codereview.chromium.org/2695963003 Cr-Commit-Position: refs/heads/master@{#456976} Committed: https://chromium.googlesource.com/chromium/src/+/de2df28c86b13227040aba5f9f5a1d1f869b81eb patch from issue 2695963003 at patchset 820001 (http://crrev.com/2695963003#ps820001) Review-Url: https://codereview.chromium.org/2753993002 Cr-Commit-Position: refs/heads/master@{#458264} [modify] https://crrev.com/1ad3437632699fb98fdd46a3ba6ad8d63cf10ee5/PRESUBMIT.py [modify] https://crrev.com/1ad3437632699fb98fdd46a3ba6ad8d63cf10ee5/build/android/BUILD.gn [modify] https://crrev.com/1ad3437632699fb98fdd46a3ba6ad8d63cf10ee5/build/android/pylib/android/logdog_logcat_monitor.py [modify] https://crrev.com/1ad3437632699fb98fdd46a3ba6ad8d63cf10ee5/build/android/pylib/local/device/local_device_instrumentation_test_run.py [modify] https://crrev.com/1ad3437632699fb98fdd46a3ba6ad8d63cf10ee5/build/android/test_runner.py [modify] https://crrev.com/1ad3437632699fb98fdd46a3ba6ad8d63cf10ee5/build/android/test_wrapper/logdog_wrapper.py [add] https://crrev.com/1ad3437632699fb98fdd46a3ba6ad8d63cf10ee5/build/android/test_wrapper/logdog_wrapper.pydeps [modify] https://crrev.com/1ad3437632699fb98fdd46a3ba6ad8d63cf10ee5/build/config/android/internal_rules.gni [modify] https://crrev.com/1ad3437632699fb98fdd46a3ba6ad8d63cf10ee5/testing/buildbot/chromium.android.json [modify] https://crrev.com/1ad3437632699fb98fdd46a3ba6ad8d63cf10ee5/testing/buildbot/chromium.linux.json [modify] https://crrev.com/1ad3437632699fb98fdd46a3ba6ad8d63cf10ee5/tools/mb/mb.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86ea5a365e6c928bca676dd4621e6d9ef848e357 commit 86ea5a365e6c928bca676dd4621e6d9ef848e357 Author: jbudorick <jbudorick@chromium.org> Date: Wed Mar 22 00:13:49 2017 Revert of (Reland) Use logdog butler subcommand to run tests. (patchset #18 id:340001 of https://codereview.chromium.org/2753993002/ ) Reason for revert: https://build.chromium.org/p/chromium.android/builders/Marshmallow%2064%20bit%20Tester/builds/10403 Original issue's description: > (Reland) Use logdog butler subcommand to run tests. > > Previously we ran tests, without setting butler environment variables. > This will run into NotBootstrappedError when we try to upload test > results through logdog. > > In this cl, we use logdog butler subcommand to run tests, which will set > butler environment variables before hand. > > BUG= 692287 > > Review-Url: https://codereview.chromium.org/2695963003 > Cr-Commit-Position: refs/heads/master@{#456976} > Committed: https://chromium.googlesource.com/chromium/src/+/de2df28c86b13227040aba5f9f5a1d1f869b81eb > > patch from issue 2695963003 at patchset 820001 (http://crrev.com/2695963003#ps820001) > > Review-Url: https://codereview.chromium.org/2753993002 > Cr-Commit-Position: refs/heads/master@{#458264} > Committed: https://chromium.googlesource.com/chromium/src/+/1ad3437632699fb98fdd46a3ba6ad8d63cf10ee5 TBR=dpranke@chromium.org,hzl@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 692287 Review-Url: https://codereview.chromium.org/2767633003 Cr-Commit-Position: refs/heads/master@{#458607} [modify] https://crrev.com/86ea5a365e6c928bca676dd4621e6d9ef848e357/PRESUBMIT.py [modify] https://crrev.com/86ea5a365e6c928bca676dd4621e6d9ef848e357/build/android/BUILD.gn [modify] https://crrev.com/86ea5a365e6c928bca676dd4621e6d9ef848e357/build/android/pylib/android/logdog_logcat_monitor.py [modify] https://crrev.com/86ea5a365e6c928bca676dd4621e6d9ef848e357/build/android/pylib/local/device/local_device_instrumentation_test_run.py [modify] https://crrev.com/86ea5a365e6c928bca676dd4621e6d9ef848e357/build/android/test_runner.py [modify] https://crrev.com/86ea5a365e6c928bca676dd4621e6d9ef848e357/build/android/test_wrapper/logdog_wrapper.py [delete] https://crrev.com/e6a40e45351bffdd6ba8c0797f1e3a9818f03fc2/build/android/test_wrapper/logdog_wrapper.pydeps [modify] https://crrev.com/86ea5a365e6c928bca676dd4621e6d9ef848e357/build/config/android/internal_rules.gni [modify] https://crrev.com/86ea5a365e6c928bca676dd4621e6d9ef848e357/testing/buildbot/chromium.android.json [modify] https://crrev.com/86ea5a365e6c928bca676dd4621e6d9ef848e357/testing/buildbot/chromium.linux.json [modify] https://crrev.com/86ea5a365e6c928bca676dd4621e6d9ef848e357/tools/mb/mb.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b15df5f68a23a7c75af0e09ee52b4add1a6f1d6 commit 9b15df5f68a23a7c75af0e09ee52b4add1a6f1d6 Author: hzl <hzl@google.com> Date: Thu Mar 23 23:43:04 2017 (Reland) Use logdog butler subcommand to run tests. Previously we ran tests, without setting butler environment variables. This will run into NotBootstrappedError when we try to upload test results through logdog. In this cl, we use logdog butler subcommand to run tests, which will set butler environment variables before hand. BUG= 692287 Review-Url: https://codereview.chromium.org/2695963003 Cr-Commit-Position: refs/heads/master@{#456976} Committed: https://chromium.googlesource.com/chromium/src/+/de2df28c86b13227040aba5f9f5a1d1f869b81eb patch from issue 2695963003 at patchset 820001 (http://crrev.com/2695963003#ps820001) Review-Url: https://codereview.chromium.org/2767833002 Cr-Commit-Position: refs/heads/master@{#459281} [modify] https://crrev.com/9b15df5f68a23a7c75af0e09ee52b4add1a6f1d6/PRESUBMIT.py [modify] https://crrev.com/9b15df5f68a23a7c75af0e09ee52b4add1a6f1d6/build/android/BUILD.gn [modify] https://crrev.com/9b15df5f68a23a7c75af0e09ee52b4add1a6f1d6/build/android/pylib/android/logdog_logcat_monitor.py [modify] https://crrev.com/9b15df5f68a23a7c75af0e09ee52b4add1a6f1d6/build/android/pylib/local/device/local_device_instrumentation_test_run.py [modify] https://crrev.com/9b15df5f68a23a7c75af0e09ee52b4add1a6f1d6/build/android/test_runner.py [modify] https://crrev.com/9b15df5f68a23a7c75af0e09ee52b4add1a6f1d6/build/android/test_wrapper/logdog_wrapper.py [add] https://crrev.com/9b15df5f68a23a7c75af0e09ee52b4add1a6f1d6/build/android/test_wrapper/logdog_wrapper.pydeps [modify] https://crrev.com/9b15df5f68a23a7c75af0e09ee52b4add1a6f1d6/build/config/android/internal_rules.gni [modify] https://crrev.com/9b15df5f68a23a7c75af0e09ee52b4add1a6f1d6/testing/buildbot/chromium.android.fyi.json [modify] https://crrev.com/9b15df5f68a23a7c75af0e09ee52b4add1a6f1d6/testing/buildbot/chromium.android.json [modify] https://crrev.com/9b15df5f68a23a7c75af0e09ee52b4add1a6f1d6/testing/buildbot/chromium.linux.json [modify] https://crrev.com/9b15df5f68a23a7c75af0e09ee52b4add1a6f1d6/tools/mb/mb.py
Comment 1 by mattcary@chromium.org
, Feb 24 2017